Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07f0c6ac-f195-e598-4649-e88ad5e76005@infradead.org>
Date:   Thu, 13 Jul 2023 12:04:54 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m
Content-Language: en-US
To:     Jim Cromie <jim.cromie@gmail.com>, jbaron@akamai.com,
        daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org
Cc:     jani.nikula@intel.com, ville.syrjala@linux.intel.com,
        seanpaul@chromium.org, robdclark@gmail.com,
        gregkh@linuxfoundation.org
References: <20230713163626.31338-1-jim.cromie@gmail.com>
 <20230713163626.31338-21-jim.cromie@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230713163626.31338-21-jim.cromie@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jim,

On 7/13/23 09:36, Jim Cromie wrote:
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
>  lib/Kconfig.debug | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index d4fbbcc395d2..82d11ac63758 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2696,13 +2696,14 @@ config TEST_STATIC_KEYS
>  
>  config TEST_DYNAMIC_DEBUG
>  	tristate "Build test-dynamic-debug module"
> +	default m

You need to justify such a change, and since it's not required
for running the system, I don't think it should be 'm'.

>  	depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
>  	help
>  	  This module works/demo's the dyndbg's classmap API, by
>  	  creating 2 classes: a DISJOINT classmap (like DRM.debug)
>  	  and a LEVELS/VERBOSE classmap (where 2>1).
>  
> -	  If unsure, say N.
> +	  If unsure, say N.  If bored/curious, say M
>  
>  config TEST_KMOD
>  	tristate "kmod stress tester"

-- 
~Randy