Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 20:46:16 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: hisilicon,cpuctrl: Merge
 "hisilicon,hix5hd2-clock" into parent binding
Message-ID: <20230713-encounter-earmuff-ca0edd40e57b@spud>
References: <20230707210700.869060-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="adCi25htn3vGAWbH"
Content-Disposition: inline
In-Reply-To: <20230707210700.869060-1-robh@kernel.org>
Precedence: bulk


--adCi25htn3vGAWbH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 07, 2023 at 03:07:00PM -0600, Rob Herring wrote:
> -Each clock is assigned an identifier and client nodes use this identifier
> -to specify the clock which they consume.

> -All these identifier could be found in <dt-bindings/clock/hix5hd2-clock.h>.

Might've been nice to preserve the reference to the header containing
the defines?

Either way, this seems to have sat for a bit so,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

--adCi25htn3vGAWbH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLBUiAAKCRB4tDGHoIJi
0quRAQDmc+bJ5QjRN9aDgaZD7JitN5GsZ1G7TexzypuR9ELl/wD+In6o2DXNID7x
VIoDxySl+hzN+FrFvzXAHfutd9X6kAI=
=DQuz
-----END PGP SIGNATURE-----

--adCi25htn3vGAWbH--