Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 16:33:24 -0400
From:   Josef Bacik <josef@toxicpanda.com>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        nbd@other.debian.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3] nbd: automatically load module on genl access
Message-ID: <20230713203324.GA338010@perftesting>
References: <20230713-b4-nbd-genl-v3-1-226cbddba04b@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230713-b4-nbd-genl-v3-1-226cbddba04b@weissschuh.net>
Precedence: bulk

On Thu, Jul 13, 2023 at 09:29:35PM +0200, Thomas Wei?schuh wrote:
> Add a module alias to nbd.ko that allows the generic netlink core to
> automatically load the module when netlink messages for nbd are
> received.
> 
> This frees the user from manually having to load the module before using
> nbd functionality via netlink.
> If the system policy allows it this can even be used to load the nbd
> module from containers which would otherwise not have access to the
> necessary module files to do a normal "modprobe nbd".
> 
> For example this avoids the following error when using nbd-client:
> 
> $ nbd-client localhost 10809 /dev/nbd0
> ...
> Error: Couldn't resolve the nbd netlink family, make sure the nbd module is loaded and your nbd driver supports the netlink interface.
> 
> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>

Reviewed-by: Josef Bacik <josef@toxicpadna.com>

Thanks,

Josef