Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51511be4-2b74-0d21-e029-97e7c5335d21@intel.com>
Date:   Thu, 13 Jul 2023 15:36:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 net-next 00/10] Introduce ndo_hwtstamp_get() and
 ndo_hwtstamp_set()
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Maxim Georgiev <glipus@gmail.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        =?UTF-8?Q?K=c3=b6ry_Maincent?= <kory.maincent@bootlin.com>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Vadim Fedorenko <vadim.fedorenko@linux.dev>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Hangbin Liu <liuhangbin@gmail.com>,
        "Russell King" <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "Jay Vosburgh" <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "Wei Fang" <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        <UNGLinuxDriver@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Daniel Machon <daniel.machon@microchip.com>,
        Simon Horman <simon.horman@corigine.com>,
        Casper Andersson <casper.casan@gmail.com>,
        Sergey Organov <sorganov@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230713121907.3249291-1-vladimir.oltean@nxp.com>
 <f4193401-8f61-8f8d-a85c-e513e64e90fa@intel.com>
 <20230713223353.wfo4xarh4jpfynjp@skbuf>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230713223353.wfo4xarh4jpfynjp@skbuf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3NTUVdFQndQMEpCUWdSUFBSRUcrbE1zTncwNGVtamszS0pqYnpTODhYTGpq?=
 =?utf-8?B?Y2tRNG1qT094ZXNIa1RDZCthNjNqcENqV0JKL3U5T0R4OEJ3czVwRG0vOUxu?=
 =?utf-8?B?bTF1MmFWTDRsNFVza1hxOVpRUWM2c01id2NrcGtoaC8wR2VvSCt0bGt3ajBv?=
 =?utf-8?B?ZDgxbzU0MlBtTWpsdnVZY1RpTENRMGNCV3ArNXcycVM3TkVnWTVPN1Z2aUw1?=
 =?utf-8?B?MWx1RXRQMzM4Vk8wS1F5Yk0yS2VWMldnY1dXUVdxRWU4U0w3cEg5UXp2Qjcx?=
 =?utf-8?B?L2xyN0NkbGtZNlpBNmZHdGYzYTJycVFIV2MvZllvL0FzRHpTMndnY0dvZHla?=
 =?utf-8?B?K0FoQmV2Q3VYSHRieDRSTURubjN1RElqM2xLRXZNaXpGS3oxQVAxL3Fjd015?=
 =?utf-8?B?dHlnL0Jkb013ZHJkNmMrVFM3UGlVWVNqNTVsS2JkbkRoTVhKcVkxTE80SEph?=
 =?utf-8?B?L1l5QmZXU1UvYk94Wmhyb3ZDcnJJR2NIRWtPdFVvMjVBY0RJNDFua2xJZms2?=
 =?utf-8?B?T1BEaUtoRVNtcWlqYkdXYUpLcmRSSXlDWHVudm80eVNTU29GU1U3V1o5Z3lN?=
 =?utf-8?B?SDdRSGxJV1A5U2IzYUxtaE82ZVlSK3duU3BUNlZVUnRSNFNmMnJpSXpiSEFT?=
 =?utf-8?B?Y0E3azAvM1FJNS9EcU1qVXpyYVlxRm56Wi9UNlI3ank0aWV4T2hPTmZvRG9p?=
 =?utf-8?B?UW1xcDRvb0ZSck5nRHJPVGdMWmFKMExGRk9KRnNoelRYcXB5ME5GaktrWVRq?=
 =?utf-8?B?amVhcFRDczR3bmtCbW4rZ3dRNE1wYXFlNkRxWTUvZ2pkeTJTNVlxRUFEY2Nn?=
 =?utf-8?B?Z1BjRllkSG05UHdPaHQ1UTFGclRvR3pOb1RvemFhVlV4c2lWMHB6WmJVdHRr?=
 =?utf-8?B?NEpubjllNXhzNlFTWlBMTldGOEJHNjl1b3lyU05lbW94dS92cSt2clNCazBS?=
 =?utf-8?B?b3pKR0lJdEtJUGNIMWFxQ3VSVHZITENUMTFNK3VFbVpIZEhyU1pqOG9oR1k1?=
 =?utf-8?B?bHlhZDVaTkRpVFlkZFliMkpKeXVLS1ladkU1Nm40alkwbHFBVzkxaVZneEht?=
 =?utf-8?B?cVFDN3J4Nk8xWEJ1QWhYVXdJeHlLbllmeHRxUXVTME5VYmVnVlVNcjhSbXMr?=
 =?utf-8?B?ZTdQSGhUYnkwbDl1NDdpeHRkeWdZZXFrdGxuRi8raTh2aHJ4bzc0aWZPanlY?=
 =?utf-8?B?STFoay9JMG8vZ1JEdThZOTlES3dTdVNhMkpobGZTSndQSFZ4UW5MQzZiWjZz?=
 =?utf-8?B?a3IwRGMzaHdmSFJpSDlRR1NUd3psRHdMOTYxb2pWTGZ1aVlFakFna2NRcm8v?=
 =?utf-8?B?ZWcvNW41aTJ2WkdpYVVublVLZ205UGhHbkJhNUJTbmNqUUNiNDdQdzlZWFln?=
 =?utf-8?B?cUtpOGYrd3h1bURmVDVhR0ZJeG13RUhSbHZJdTI1NktvMVRXTnRhYnpNYkNp?=
 =?utf-8?B?TGVxbXJlRWRBK0JETUFHdkhZYi9RcUdHbWtkVU51djBIODlaNzk2Vk15TzUz?=
 =?utf-8?B?THN4dXhLYmlJK1JsWEFlVXByZDZMb2JBTk5ZdTh0Sm9teDlVZFRTL09aMk1T?=
 =?utf-8?B?Q3FkVzZSK2VPSkdGcEw5T3BMbXd6TzJDSzBBV2M3eGRrWTR3MmZ0eUNMVmRR?=
 =?utf-8?B?dUhOaTdRTzk4d2JVUVRwL0JsbTJuYTdjUUdKSUwyanU4bUs4eVNEeXJjMXhM?=
 =?utf-8?B?WDZ4MXdzQm5rblR0TU1oUUw2T2FzY3ZDR2JueXhrcGZkclJxVFRQOTdPak5x?=
 =?utf-8?B?aGw3VXE3QUVrRW5Ua3RXN2hSSEY3OXZWbitNSlZqblNFbno2Ulg4elQ3czhD?=
 =?utf-8?B?Q091NFcybGVCeWhhckR5SUJXNThlM244cm4vMmVBV1NKZlMvc1E4T2JEUUo0?=
 =?utf-8?B?cGZHdGxZQm9salJZY1AvL1ZNYnFDVTVpT0JPM1FJY0ovWkRjd01uT2F6dCtS?=
 =?utf-8?B?QVA1UUVhRk0wdXlRdWRJaFVkRTZqeng2K1Q2R3pHQUpQWlpuNzArZ01FYW4x?=
 =?utf-8?B?Y3JmTElkcWhLWVdYVUFCNGRnY2h3QnhWWGRCVHBoclJoUldwQVR4ZFFrdnFI?=
 =?utf-8?B?R0pUdGxadmlsS2tCYm15QXMzSWswWDFTdFowT3Z0YXM1UGYxQzR5M1V6Yk9C?=
 =?utf-8?B?NTFOV0xzTit4cFBQMm9ROFpRZTd3UDhLVm1ob09MVDRLQ3lldldpTURWdnVR?=
 =?utf-8?B?b2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d6ffe9e-091a-4dc0-7b7f-08db83f18db5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 22:36:09.1988
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FSG4zpyrRetgfgllOMhqeE0vRwk/NkmARPnhpwJWFsGX0G+Kugei357DfJODCHnDs6vSp1uEgylr0Oj09Swds2BmfG8/uhTdhvQznxzkYcY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5096
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/13/2023 3:33 PM, Vladimir Oltean wrote:
> On Thu, Jul 13, 2023 at 02:50:39PM -0700, Jacob Keller wrote:
>> On 7/13/2023 5:18 AM, Vladimir Oltean wrote:
>>> Based on previous RFCs from Maxim Georgiev:
>>> https://lore.kernel.org/netdev/20230502043150.17097-1-glipus@gmail.com/
>>>
>>> this series attempts to introduce new API for the hardware timestamping
>>> control path (SIOCGHWTSTAMP and SIOCSHWTSTAMP handling).
>>>
>>> I don't have any board with phylib hardware timestamping, so I would
>>> appreciate testing (especially on lan966x, the most intricate
>>> conversion). I was, however, able to test netdev level timestamping,
>>> because I also have some more unsubmitted conversions in progress:
>>>
>>> https://github.com/vladimiroltean/linux/commits/ndo-hwtstamp-v7
>>>
>>> I hope that the concerns expressed in the comments of previous series
>>> were addressed, and that Köry Maincent's series:
>>> https://lore.kernel.org/netdev/20230406173308.401924-1-kory.maincent@bootlin.com/
>>> can make progress in parallel with the conversion of the rest of drivers.
>>>
>>
>> This series looks good to me, nice cleanup and reducing some boiler
>> plate code is excellent.
>>
>> I'd like to convert the Intel drivers too, but I am not sure when I can
>> commit to doing that as I have a lot on my plate presently.
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> 
> Thanks for the review. The conversion of Intel drivers is in the Github
> link I had posted.

Oh nice!