Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4193401-8f61-8f8d-a85c-e513e64e90fa@intel.com>
Date:   Thu, 13 Jul 2023 14:50:39 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 net-next 00/10] Introduce ndo_hwtstamp_get() and
 ndo_hwtstamp_set()
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, <netdev@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Maxim Georgiev <glipus@gmail.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        =?UTF-8?Q?K=c3=b6ry_Maincent?= <kory.maincent@bootlin.com>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Vadim Fedorenko <vadim.fedorenko@linux.dev>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Hangbin Liu <liuhangbin@gmail.com>,
        "Russell King" <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "Jay Vosburgh" <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "Wei Fang" <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        <UNGLinuxDriver@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Daniel Machon <daniel.machon@microchip.com>,
        Simon Horman <simon.horman@corigine.com>,
        Casper Andersson <casper.casan@gmail.com>,
        Sergey Organov <sorganov@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230713121907.3249291-1-vladimir.oltean@nxp.com>
Content-Language: en-US
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230713121907.3249291-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cURtdEgxYTRmUVowQXJzTXVwck5jZFJ3eldiL25zazFWczdadXNwVUErWWVa?=
 =?utf-8?B?VEUycjR4KzdzTk12U1M0ZzlTbE1CWWhTNWxvdnFUZFUwSlJKM1BuMVZpT1Zn?=
 =?utf-8?B?aVZUYW9RUjkwNDJwcmZ4Vkk0SE40UzVKNm5LWkZPYlFVU2NMNjMyWnJBR0R3?=
 =?utf-8?B?VVd0NUliUHRWV0Z4SjlXelV6cS9mbzI1RkpaQ2VMN0dGNlpCNlZGNGlkMm9y?=
 =?utf-8?B?Sm5VY2tsTjNFdmlhVG9QTXAwMlRTMjFUNFhYQW1zS2Nub056alltUzlMSm1n?=
 =?utf-8?B?Y0dqL1Y4Mk0zQ0VuL3R5M3lNRFl4MUZaZ1hXb2UrdDdpS2VqbHlNWGx6V09S?=
 =?utf-8?B?RDVYS1J1TjlpRlJnWVE5cEdvTVdqbktnUXRKc05BNEczVUMrNTF0UkdDQTMv?=
 =?utf-8?B?blQrMHhJRC8zYTV5UnJzOXZjbUMzQU9La2JaVUc2WmM3RnNJQ1VneVZTTEQ0?=
 =?utf-8?B?TXd2SlFCMjRDRU56SEpvUTdWdlNxYmRNdjIyeGJWOXVucEpzY21FRmE4Z01l?=
 =?utf-8?B?M2RzRC9zcHdhYzIweGkvTEdPSHNhWkpJQU94NklRWWtuakZFMU5FNzRNKzN1?=
 =?utf-8?B?aSt2bU9GYWhLT2tSMUtFc1lSRWNhZXNFdTdCN0RSNEk0T0VXcGxlUzVwMy9X?=
 =?utf-8?B?Z0hJa1FHSmtodWRqSHR0N3RBYXpjb1NZMlpOaGd1elk2Vk1rdXJpdm5Xb0xZ?=
 =?utf-8?B?azNyWm5na1ZjS2w3VDFKSVBzS2ZEY0VKcU9Sd1hRQWZyc2w3Nkw3M1JidXd6?=
 =?utf-8?B?Njl3ckZOWCtQYndCRk1wY3QzK1ZNR0JWVythaDN1VkxaRmJTYkp4M1dJWS93?=
 =?utf-8?B?cWNmbVlIQlZTa1BRSkVWODBOWG0zS3RxeXdybDZoZzYraGVHNjl3Y01BSEg0?=
 =?utf-8?B?Nzh4czRidTRqSVM1V2UwY2lNZ0ZXb0VGM0ZOUHlsaXhoWHgrdlA5RnM0TkZw?=
 =?utf-8?B?ck5abFgxbTlYejVJMFhtcVlXbFJBZXN4dGNrSk5Bb0VHOGplOTV6c0lHK2dL?=
 =?utf-8?B?VFRaS0VLS3ZDRGtRbHdzTUUxcUx3R1dsWmM2UHlEYUxJMkJnRFBBdUFDeFVC?=
 =?utf-8?B?TGd3enM0QnEveTFYSWlOUjQvVFJaNUk3eWFZY3NuVE43YnpBdlBqUFoxWXJr?=
 =?utf-8?B?NXdFWlRNNC90eWhZNUsrVUxIc3lSWnUra2Z6K3RNTUJzSngrTDNIOTRQWnhI?=
 =?utf-8?B?M2draldyZzlYcDFFOWpZTURtblV3dWJsMjdVQXlYUWlSb3hIdDE2dFRyOEMw?=
 =?utf-8?B?YU4za0k2ZVpEMUl1UlN4RnlQUml4N3BxWHFiSDA3TXB3U2ptQi84dy83Mml2?=
 =?utf-8?B?MjJKTDlsclBjTmEveHVGbldIM1FPWUFSMzJ4Skx5cXlVZjl5NVg2aGFLdEl0?=
 =?utf-8?B?d0lVbzJ4L1dDUUVBTURSUU01R25GdldSOHlLbW4vMUJDSXhFanpVZUxpYWhB?=
 =?utf-8?B?UmVMaVFPdjhNY0NmWmtUK2V2aEpZZWtUUm9Zb2JodkQyM0ltWXBKbTlFYzk2?=
 =?utf-8?B?NFY3U3oyQjlvQkxlNGZ6YjU2dzNiRmRQSUVOVnBONlhneUlpdmZ5ZGxRTGdh?=
 =?utf-8?B?UEg0a2d0VFhUT1ZlWUtNdFErVjZqY2FtN1N2WnhTZVBBL2FFNWxzWG1nQzdU?=
 =?utf-8?B?eTdxQ2J1L1BQQWE1WXlRZVZiVXprUVBnOUJCQUdIazhiRXE2cCsvek5ibUVG?=
 =?utf-8?B?NzhNZ3dVMmxWV0o0dmZNMC9Zekt1L1l0TmltR21lci9nbGMxMTdTTjBzcEtE?=
 =?utf-8?B?dHNFMW1lczBSb3dUU21Gak9rSXByZ0JYUVVwNlJlbHBkQzhDMDA1ZGlGQnRl?=
 =?utf-8?B?c29yK3RYejd1c2U2QlFiUUdoZ1E3WENDR2lrMmZpekMxZnBUSDRtU09RVHVt?=
 =?utf-8?B?Z3d2Y0ZZQTcyQXg5eDJhbnNFMW5EQU5tT24vVzBpeDlRWWlCRXNsUTBpQzJU?=
 =?utf-8?B?VmUwejhMeU1yRVNlQk5kNHY3d0ZpRzV6UGo2MWZXSUpZY1FTVC9oMURxN04w?=
 =?utf-8?B?YzJYei9OVjNyWG1pRHBJbTlKVGV5MnFiQzBLdGxUbGp2dlVpaXpjYTB2b2lu?=
 =?utf-8?B?M0JvODdvaVZ2d1hnOUVuVW5kalhPSjlvcUVnaGd5bkZRcjloTnB1Q0t5QzJV?=
 =?utf-8?B?cjJFVElFZFJIZ3d6MDhHV29ReXpKOC9OQlJHdDlhc0FPVTZWdnJieHlFajNj?=
 =?utf-8?B?Y3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca8c6a3-7520-4491-36cf-08db83eb33e4
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 21:50:41.5348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zgujhc8dw1nqlZP9rlxEehgDuMO8E0+x2XKGf+igv/3JocE/exanU2d8TYiYcLthISefuADHMH5YoyoN/MsDZ0X8ILL3Vdv2TW3YYET3U7g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5701
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/13/2023 5:18 AM, Vladimir Oltean wrote:
> Based on previous RFCs from Maxim Georgiev:
> https://lore.kernel.org/netdev/20230502043150.17097-1-glipus@gmail.com/
> 
> this series attempts to introduce new API for the hardware timestamping
> control path (SIOCGHWTSTAMP and SIOCSHWTSTAMP handling).
> 
> I don't have any board with phylib hardware timestamping, so I would
> appreciate testing (especially on lan966x, the most intricate
> conversion). I was, however, able to test netdev level timestamping,
> because I also have some more unsubmitted conversions in progress:
> 
> https://github.com/vladimiroltean/linux/commits/ndo-hwtstamp-v7
> 
> I hope that the concerns expressed in the comments of previous series
> were addressed, and that Köry Maincent's series:
> https://lore.kernel.org/netdev/20230406173308.401924-1-kory.maincent@bootlin.com/
> can make progress in parallel with the conversion of the rest of drivers.
> 

This series looks good to me, nice cleanup and reducing some boiler
plate code is excellent.

I'd like to convert the Intel drivers too, but I am not sure when I can
commit to doing that as I have a lot on my plate presently.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Maxim Georgiev (5):
>   net: add NDOs for configuring hardware timestamping
>   net: add hwtstamping helpers for stackable net devices
>   net: vlan: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set()
>   net: macvlan: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set()
>   net: bonding: convert to ndo_hwtstamp_get() / ndo_hwtstamp_set()
> 
> Vladimir Oltean (5):
>   net: fec: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
>   net: fec: delete fec_ptp_disable_hwts()
>   net: sparx5: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
>   net: lan966x: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
>   net: remove phy_has_hwtstamp() -> phy_mii_ioctl() decision from
>     converted drivers
> 
>  drivers/net/bonding/bond_main.c               | 105 ++++++----
>  drivers/net/ethernet/freescale/fec.h          |   6 +-
>  drivers/net/ethernet/freescale/fec_main.c     |  41 ++--
>  drivers/net/ethernet/freescale/fec_ptp.c      |  43 ++--
>  .../ethernet/microchip/lan966x/lan966x_main.c |  61 ++++--
>  .../ethernet/microchip/lan966x/lan966x_main.h |  12 +-
>  .../ethernet/microchip/lan966x/lan966x_ptp.c  |  34 ++--
>  .../ethernet/microchip/sparx5/sparx5_main.h   |   9 +-
>  .../ethernet/microchip/sparx5/sparx5_netdev.c |  35 +++-
>  .../ethernet/microchip/sparx5/sparx5_ptp.c    |  24 ++-
>  drivers/net/macvlan.c                         |  34 ++--
>  include/linux/net_tstamp.h                    |  28 +++
>  include/linux/netdevice.h                     |  25 +++
>  net/8021q/vlan_dev.c                          |  27 ++-
>  net/core/dev_ioctl.c                          | 183 +++++++++++++++++-
>  15 files changed, 480 insertions(+), 187 deletions(-)
>