Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69a1669a-25c5-3bb1-4d73-00079ef9d2ee@intel.com>
Date:   Thu, 13 Jul 2023 15:44:41 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 02/19] selftests/resctrl: Don't leak buffer in
 fill_cache()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Colin Ian King" <colin.i.king@gmail.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWVFM0lVQmR4bk4wdHNjdHpFS0REMGRFNk9tck5WbUVwSWdlZG5zT0VmSDZu?=
 =?utf-8?B?NjBqVDVObVZNOEJjeFZKVnNGa3BjM0Rud3BYY1VKU0hlcStzcVNVVVJPQTMr?=
 =?utf-8?B?RUY0N2tXNnFodVV1ekp2THIvQnJCSHoxSkpmS2gwaUlEMUZPc2U0NDllUHlJ?=
 =?utf-8?B?Wk9VZk9IRldDZVkrN3RWN3ZrSUJJNzJYRkpjMmF5eG1sMC8raU8zRVE4TCtt?=
 =?utf-8?B?RFViSEhiZlJrQk1zSXJ5OWJhd1dDZGc5bE5EcDNyT29oLzg2Yno3Zk5JdVBD?=
 =?utf-8?B?b3MxUzVJYzNZZkpFWUVCUy9sdUpzSnVLNk5HK1pxK1BGdll3ank1ZFdoVm1m?=
 =?utf-8?B?MUVwVUdRdm5jdUN0R1BaN3NWVXFhMld0Q01Wc2dwdTh5U3FEM0NkbmRLQWxp?=
 =?utf-8?B?MDh6UUdaQ3BCRlpMb0lIbUl6T1hreGRQVHZ4Y1JRVk03UFVtSHpHWFJHblpR?=
 =?utf-8?B?WWhYamlpOXhvSVBCREltYkFXcXYzZmgzSUJKdzRUdFNYcUN4dmcvcHkxZHVC?=
 =?utf-8?B?Y0oyVEpQaXA1NGlmV2tDOStFR1ZxVW83UmdMVUFjMzVla3FUbDdmQ1NBMjBu?=
 =?utf-8?B?YTVoM3FhRld2QXEvNER3TmZDcEpFM2drS0VsK0EwTTZXNGYxVVBIdkVwSW5h?=
 =?utf-8?B?ajI5UEVzTXNFUDlhZlU1ZytDb1hGQW9qWk1pT3Qrb25QZmJVdWE1V1RMNm1B?=
 =?utf-8?B?MFNQTlNzajFtVEQ4Z1VrOTRmMDRhL2UzYjNOVmhVK2N0Mnd2NUx5VWpGZXg4?=
 =?utf-8?B?MkU0MGorRnc0QTFlY01JSVQ2VVdyN0dybnNYS2xWenQvQ0FSMnkwd0thZjA4?=
 =?utf-8?B?K0ZlQ1p4bzZlaXo4dHNYTk1rTW9pOEdtdFcwMEF3VmRHZEcwT0wzOXBiMlZR?=
 =?utf-8?B?WFRKbE1RODFrWVpiMDJDQUJrbGhQam00bnNmeVRjaStzaGduNDdIVDIzWkIy?=
 =?utf-8?B?cEI5MXJ6VDdwQVIvTDkxYnZsTDFlN0J3ZVdNVy96Rml6cE8yNUZqd3hHZXZV?=
 =?utf-8?B?NGNyeC9KN3FZd0pvcEVaZzc2S2hlYmtoeE0xbkx6MS9vZ25qanJuSmQ1LzJW?=
 =?utf-8?B?R2tiT1ZOS1NTY0pVMTZrT2FmMUlsSjhZRkVoRHZOb2lrcWxza1o4L2Z2U2Fw?=
 =?utf-8?B?Y2FUc0gySDZPUEhScGZXQ1Vmb2EwbjVJNHhCazFKdE1jaU1zUzQxUHZtamxE?=
 =?utf-8?B?bllzeUM3OGJmNHRnM0grdWpua0pqUnJwQi9rcFd0V2xVbitxbUlEdzlLUTBX?=
 =?utf-8?B?bGxiZzE2bVV4UVRqQ3YrSkU1MjIzSHhGOGg2NTFrWnhIMVZtTlJBdzJzdW5w?=
 =?utf-8?B?WkRlbjUyeE5sZzRTMzBBaGlwZWxNQ1dyRXJaVlU5dnhMNU9xYnVvT1RKYUpK?=
 =?utf-8?B?akswRXRaREZxVWNXOUIvaTdRNkZtSm9vNHJKbU9nQlcvanRmT2x0cEN0NVg5?=
 =?utf-8?B?VU9ySDRKSXRhaThiblJpQWZKQ01IUE9mVExxMGJ3TzExdnd2NUIvMnRHSUo4?=
 =?utf-8?B?M0FpdDU2UUt1N3ZUU1hYamRxWEMwTkZzL0x3YTZLbkg3SW5lQUJhNk01YXF6?=
 =?utf-8?B?bm1FZ282UnVrZjMwVStBcWxlMGdKaS9jam80dUg3alBibld1UlUvY3hoc3A3?=
 =?utf-8?B?Si91cU5MRFdnYXQ5WHNVSkZ2d2JFMGdBSXJyY0R0MzdWSWM4aGQ4ajQ4eU5G?=
 =?utf-8?B?T0RCRUd0MHAxdEt4bExvaG1tUGU1YmwyclBHMWZmNUpGZnlCTzkxSjk0S25L?=
 =?utf-8?B?WTJxRUhSaXU4eHZVaVYwc0NvdWQ2UnBhNm80N1R6eTN0OWRPSTRIM3RORHJB?=
 =?utf-8?B?dWhoY1RMcFdxemhmRTR6WW1CeUkzaldQd04zOVFJT2pqZjBHY21pRy9ZVkVm?=
 =?utf-8?B?RmhTRFFPNkhVOUlDME9RVjlPZ1dsWmY2amZGdzJubWRnckNtcWNYZnUzYnZj?=
 =?utf-8?B?S1VCVVhJa3gvWWJieGhhUG80WlZDQkh1ZTdlbFk1bnlyOFg5SEtiK3ZuVUYw?=
 =?utf-8?B?NjFrN3krRm0yRjk5OFZPekRueVFwbTIwMEl5RzFvdVVMa3V0U05MZjRNYmlP?=
 =?utf-8?B?ZkZhK3Jsc0JWMSthd3VuNE9tSkoxS0RNZS93UTlYRnBjc29WWUU3MG5xcHNj?=
 =?utf-8?B?ejA0SjZzd2VJRlkwSExPRk1oQUs4MnA3Q2VKRDBJckFGaFkxL2hFNFhOSUNp?=
 =?utf-8?B?S3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 841738b9-85ad-4854-3c43-08db83f2c053
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 22:44:43.6212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HwyVtZYy8TFLn1zhM2EPyQMNRMtX699ZNw9jlzPUWC4QYXhI3UkPSJJDJT71z1LjCQCO4aQggdoIL8UxfSHIsrSpoamdOfPUx+qOV1+gRfU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7370
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> The error path in fill_cache() does return before the allocated buffer
> is freed leaking the buffer.
> 
> The leak was introduced when fill_cache_read() started to return errors
> in c7b607fa9325 ("selftests/resctrl: Fix null pointer dereference on

Could you please prefix the sha with "commit" to get a clean
checkpatch.pl check?

> open failed"), before that both fill functions always returned 0.
> 
> Move free() earlier to prevent the mem leak.
> 
> Fixes: c7b607fa9325 ("selftests/resctrl: Fix null pointer dereference on open failed")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you for catching this.

With the changelog update:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette