Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59fd7956-caf8-03de-10a5-f37036219134@intel.com>
Date:   Thu, 13 Jul 2023 15:55:18 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 06/19] selftests/resctrl: Move resctrl FS mount/umount
 to higher level
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-7-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-7-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU1Vd1JJY1NBVlIzNXdkeFpESzJSZ21PRUJYTWh5V0F3d3JRRkhpc0hVYVhT?=
 =?utf-8?B?eUppeSswRDY2MTlFUkYzREk1eTRHNUM5V0owM0NXNW45Mk92TDFvS1R5U3Zr?=
 =?utf-8?B?eWdLdHZGakdxT1NwYzRqR0lkRXRkdjZ5SmhTMjFKa3Y5MjMvTE1jeG9VaTls?=
 =?utf-8?B?QkVYak5XMDlONFZBazFuTW5iblZiZFIwWmgwTEQ1T1hOZlQyck9iemdoMnRl?=
 =?utf-8?B?S01yUGhTRFJNUU1Bbk50c01xcHVwaC9EMks0cDBzTWRGRnhXSmZVcjQ2bmt0?=
 =?utf-8?B?Skx6Y0NLMDlyVTlXSFBDLzRsV1lkcXRrdXlZN3FzVkRTREtqTjBDeFlUZmRJ?=
 =?utf-8?B?UVIrVXVnSEg3MXpjOUwzVmFyRWVwRUdESkxFN2tNRkNCdi8xMEtNQmU2MWY4?=
 =?utf-8?B?K01EeWFXbEtSbGJrUWRVNldySHBENTlyRDFHd3JQb0xIWGFJL1ZKR0xJMmZi?=
 =?utf-8?B?TjlOdVBBbVdsTzgyTGM4Z0NUVkZBVEgvTFU0NXdNREs3SDNjM0dIeThldEoz?=
 =?utf-8?B?eld5ZlVPaWcrRUVlVVBwM0FjcHQyQTcySjZrUmQ0eHZ1QXNFR0ZCVURUd25Q?=
 =?utf-8?B?WmhMaWZjRFpCMWxiRzcwdTh0S0ZLdXNremQ0SEdqL0kzOXp2QVl3L0EyY2ZK?=
 =?utf-8?B?eHdOREtqbW43TVovTnptdHV5alJOUVNsYmdjOGgvMmVadlpmbDRPRUFrL3Fs?=
 =?utf-8?B?bWs0Z3c5WkE2VzdTY3lHY3lYY2ZHTTUycmRhLzFsMWN1NGdGb25NY0lmdDFh?=
 =?utf-8?B?ckJoR2ZBYmJXQ1RZNUVWdHFDbGpzWldJNVhhK3NIMzd4UXhhQ1VBOWttbHcw?=
 =?utf-8?B?by9DZWcrVTFORjR6MVZrMUVSb2p3TktIOW9mTUZXYnVrZGMrODEzOUIxUFNU?=
 =?utf-8?B?azNQamJJdllITkZFVkJ0ZnBpS0dIQ1ErNUJHQkwrOHV2SzdOUG43RVJxZEpN?=
 =?utf-8?B?WjB2Uml0bElWT0FnUUhXY3lXYjlrQnkrMHNqNGlseTJuT1NzODR0TXYvU0lr?=
 =?utf-8?B?dlFkckpQN1JXNmY1ZWo0dnhwblR6NGg4ZFB6TGpVTkliM3p0ZVAvTWRzcnFh?=
 =?utf-8?B?L1FJcEViV1lhVDF3Sm9nVVhiazZ3ZVIraFJReGdKYUVmWDlTOHQ2NnltdVQx?=
 =?utf-8?B?Q0Y5UmlMaTNROUg0TlEvcVdBNGRWQS8zVllhVXhad1poVXc2cTdTcllScXR2?=
 =?utf-8?B?Y3lWc3VxYWh6L0FuWUhmdEhzUTFlSmVBWGVaYTcxOWRjdWYyNWNxWi9HOWRK?=
 =?utf-8?B?NjBlWGpDblpXUm43RVcvYkdNTW9uQVVYOGIxTWtGMDBHUE5LUTdIbVVBeXp1?=
 =?utf-8?B?dHpJR2RBcmFwYzJZMlZKOXdudklDOXRNbEV3d05idVVySmt2VHFDOG9tejF1?=
 =?utf-8?B?b0VGL25RTERJWjUyQ1c5TVdKWkFNTlcxZTB6ZXZTQVZDYWpsRXFZRTZUcXZV?=
 =?utf-8?B?bG00OG5waEdMMVc2emdCcmxDclJxSjV0MWY2Mm93OUFJMWFNYVAzQVRxUU9k?=
 =?utf-8?B?VUlycjZuN2p1eDJsUjdENGJsazNSMU1QL1hic1NWVWRBM3NmeGtZeWdKRXBP?=
 =?utf-8?B?OTFOZ29XaWJJVTJEaU5ydlhUeHEraDdJdHlwdTMrK2ZOaEdFN1NTUGZCZ1Fj?=
 =?utf-8?B?UGh0Mk5rbVhhOGF1eVh0dGFPaGZrbTAwRXVoMWFZa3pUVzVlc0cyN2dBSEVp?=
 =?utf-8?B?bnVzTHJqT0xoVnJ4NERCc0RWMDViRURERStMcnA3MmZidndwOWZ2dXJSK2pN?=
 =?utf-8?B?WkwvSTRWcnpQdTNPZVlOU290OTUweWF5Y1preVBFS1V2VG1lZ0xwbDRidDNl?=
 =?utf-8?B?bkxIbmpLQWF4QUtjOFY5QmZ4TnoxVElzT1kxVXVKMHdIOHF5eGxzTVJuMXYv?=
 =?utf-8?B?aytmc3hJNW53M3dYbFVnamJ4Vjc5V2UrTFQ5b1cwUzlGOThSUGFjYnk4dXVy?=
 =?utf-8?B?T1E4Yld0SHpQSUVOQ1UwSmhIWVNFMU03VFVPV21CRkVhSFVleDJ6MEExa1pi?=
 =?utf-8?B?N1V1a3B5V253dG14a3A5WkZRUjhTajZ1dTZzOHNXVk1qMzZ3dDBVQkpCL3FV?=
 =?utf-8?B?ZkxUMDMydmwxZE9JMkUrL21hVDRiT3VIVXFQRmQzVDhnTnBCdklaUUNhcDB3?=
 =?utf-8?B?UVUyTWZBRE9NNjErMERQT0gvSDlveWkrTFpjdWZ0RkUyc3NyRWcyWHJtTThE?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 623b805e-bb70-49aa-9b3a-08db83f43b99
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 22:55:19.9350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qzJwfE4U+d8kAFXQqoF8SL6fLrND6cv4eq6C7gG7FJ2/kMVsFlGjhxKu0IVmeFbdfBEvrMv3TeQodW0WLNDWsXO/16niWhFM8O9amGBJak0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4689
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> A few places currently lack umounting resctrl FS on error paths:
>   - cmt_resctrl_val() has multiple error paths with direct return.
>   - cat_perf_miss_val() has multiple error paths with direct return.
> In addition, validate_resctrl_feature_request() is called by
> run_mbm_test() and run_mba_test(). Neither MBA nor MBM test tries to
> umount resctrl FS.
> 
> Each and every test does require resctrl FS to be present already for
> feature check. Thus, it makes sense to just mount it on higher level in
> resctrl_tests.c and properly pair it with umount.
> 
> Move resctrl FS (re)mount/unmount into each test function in
> resctrl_tests.c. Make feature validation to simply check that resctrl
> FS is mounted.
> 
> Fixes: 91db4fd9019a ("selftests/resctrl: Remove duplicate codes that clear each test result file")

Could you please elaborate how this commit is the culprit?


Reinette