Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d86980f-ad9f-0676-011a-41a4625318a6@intel.com>
Date:   Thu, 13 Jul 2023 16:01:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 11/19] selftests/resctrl: Remove duplicated preparation
 for span arg
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-12-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnI2M0Y3VmRiRXNIc1hTQjVoTkFDQS9TejNHbU9RbjFiU1JUekREdzUrMk5u?=
 =?utf-8?B?Vmt6RVE3Z29DU1oyaHJpSk41UC9tbUkvZ1p4cXJxOUppVnoyOWErOFRIVnU0?=
 =?utf-8?B?djJsMVZCRytBSHIyeU1wNnI2eE9mYS9lY29DUUF3QlRNYjFjdWd0VFVXRDBQ?=
 =?utf-8?B?RHd2WHRKVDB6azhIM2grck1LeTBjeGV2ODc4UjdsQUg2ejhZckpIZWp4a2NP?=
 =?utf-8?B?aGpVam9CdnZrNFBENmZPZFlVRmdSb2ZQQU5aTWd6TDJVNXJIamRnRWtuVDIx?=
 =?utf-8?B?NWU5N0VWU1ZROHhpS2ZrQ3dLM0FrYUZvcDVVSll5OXdwMGw4d2hXSFlPbGc3?=
 =?utf-8?B?dlFteHptZkFhODlzOE5RMzZQd0VBM241TVBUeFlJVVphQ2VHNGxHZ2NDN25j?=
 =?utf-8?B?dEFXTENCT2FZTUNIM2M5U1FoZzZHNzRGQzd6Q2IzazkwVndDYkdVZUtUVzB1?=
 =?utf-8?B?N0JmbjhHQlJxVHFYdytmS2orTUMrTlEvbjRlYWFkbXFKZSsxaEFqUCt3bDFH?=
 =?utf-8?B?WForV0p0VUdyaDluMmJkWmNpMXgyaVp6b2ZiemtZeDJhQmhlSkVMVnVRTDAv?=
 =?utf-8?B?TlVRWUx6ZEd2UWNHVlhMdHhKWXU5QUZjYko5NlMrMW1Eb0d3L1VOemtyUjVU?=
 =?utf-8?B?L3ovRkN4dnNqZmZMNWxkeE02OFloc0dnenJqM1BRZUxVdTJiTm9HeUFoTEVq?=
 =?utf-8?B?ZVViV1RFUWd0MnUvZHhtMXNvaTJ1Y0hYMTM3L2xqaW9QWk1RK3c4QzB2ckUr?=
 =?utf-8?B?VHJxaWhaNWxRLzVrOFhaMytXWnVFaTB1RytSNXhlRmFyZ2ZwaGRsajhYemcw?=
 =?utf-8?B?RVM1N0tHdzg4TVJaWGhRNkV3TEUrb2pCKzlzSVRNZE9mSlZzUUJVUFhaMXpw?=
 =?utf-8?B?K1dhUjdSejA5UjNhYmtPOW1pTjlTOC8wWUZoVmhVZHQweEs2Wjhiek5Mck83?=
 =?utf-8?B?SnVYRVYvNkVLKzZCL0ZZSDQvbk1sejg3Z1FlekE2Z2trZ0VYaE44bCtuZkhQ?=
 =?utf-8?B?Z2xKb0tiWG9hWHZGdXhKYnA1ZExGeENJQkVwYVY2blI5VFk2M2VDQW4wQWd6?=
 =?utf-8?B?QWVjcTFwWEM2c1FmSkV1Rmd4Y0NyMVh3c2JCOGVFcEdheVhVTTlIa0hraGtE?=
 =?utf-8?B?QWF1NVQ5Smc4NDlNZ1hRUjZQaHkvTWorVDVhNHdrcXFDMFRoeDJES1ZDbHZT?=
 =?utf-8?B?YnIrT245dDZGUUNkazRpekIySEFWa1NxQXpxN3dOTExCcUpwYzV2UDk1MEhL?=
 =?utf-8?B?ZWhvOFZsK1p6OUhNSGs4K2ZoQVBiQU11TU5OVEhEUGc1cVhsMmo2b2xSMGw3?=
 =?utf-8?B?eVZBaklmbVIvVzduWXJKRXNjRnIwTld3STUyN3dkNUdUQnhpTHVlVUkvdzdi?=
 =?utf-8?B?WlNvekQyRXZOUCtiYVBueGIydkEybWZqeHNlVmN4VFJ2MzV0V0JQYldOUm1X?=
 =?utf-8?B?YVVTSnhoTlU2Wk5ZRVYvaEZvVU01cS93Y3Rhd0tjaG1BL2w2QkV3M2lJMDF2?=
 =?utf-8?B?VjVoUjE2RE9tRG5nMGp2MDRWWFZKVlh3ZlJiL1hjRWJYUW5PWTFEUmNQRTdM?=
 =?utf-8?B?NkJtdTFJMWNWUzhHU0VnOSs1dm5kTUZkLzhDRVpRZHRFWjhKYXh2UnlrU3pu?=
 =?utf-8?B?M2d1cjNoU3JXUDRhUjFDaFdxMDBKMTErQmozN2JEdHdDUXNMd0JCQkpaRkht?=
 =?utf-8?B?YmRNeDE2TDF4d2xMQy9jelNmOEhFS3FwbjRtTm9NNTcvY1ZCelpoTHhwd1Nl?=
 =?utf-8?B?eUxJc1lkNWpWV2hDUmZocVpTY2hxTWxLSTZHTXA1QjVpNUZHT3dyT1Nuakxq?=
 =?utf-8?B?ZUhmVU9DK3FjcmJTaTN0SUJub2FGdmthV0NnNGxjOG5yQ0dSWDZ1Z2MyL242?=
 =?utf-8?B?TENaN0UxN3RUK2x0VCs2V1Y4R3RyM2J6L0NUL09FNVFCdWJIdllhMzMwRUhw?=
 =?utf-8?B?bXNMbkZnS2tCZHJMaUFuT2NtbVN3UGRkT1ZMclVuU0svNGpNNFZLRjZQUGc2?=
 =?utf-8?B?YjllYU5ROFdHYW5GWHl3VkNtMDdDekVqbExqaXBSNGpFcmoyMEMrT0Fxcmk0?=
 =?utf-8?B?UnZLK3ZybVpRazlCVkdIWDhMVFlCcUo1U3YwMkY0dEJNSCtHWFNOdEdaMWNV?=
 =?utf-8?B?MWkwRXlnbS84RzJqbktGUFdkS1E1VlU5L3dEK2ozSG05dXBWc0pCV1NweDRl?=
 =?utf-8?B?SkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d0dbae49-1d02-47c1-ae85-08db83f52823
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:01:56.7874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tEB9XJg6b6UqUCmw84hVF7SN8iXDX5d18WrOcvmU+5oWQkLl+Hs7k9J3WgJ2dA693wHQHDvqqjNbDKVADmFjK5gCfMuDrYOXqehPb+5iIcM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5586
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> When no benchmark_cmd is given, benchmark_cmd[1] is set to span in
> main(). There's no need to do it again in run_mba_test().
> 
> Remove the duplicated preparation for span argument into
> benchmark_cmd[1] from run_mba_test(). After this, the has_ben and span
> arguments to run_mba_test() can be removed.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette