Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22a61125-a0b9-f432-218f-cb467d1ef379@intel.com>
Date:   Thu, 13 Jul 2023 16:07:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 14/19] selftests/resctrl: Improve parameter consistency
 in fill_buf
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-15-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-15-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmcvUjVRWWVtNEpjdTlidlRVYkk4VElOclhJcWxKZWVydFp0VnVPWGlYSkFF?=
 =?utf-8?B?Nnp2R204eTVSdXFzdGRtWGhTY0puVnlwdllEVGtySW1oemVDRkcveG91WjNN?=
 =?utf-8?B?UGRDNDZFM05lSGNteklSeVlETXBvZGJyQytKS28yOUU0QkxPQnEwYXlZdE4w?=
 =?utf-8?B?TGhYYm1yUHZWSFhFSnk2WkRoTkp1S0sweTBiNndTK1NGZXBUVEwyaG0zK0l4?=
 =?utf-8?B?a1JRRldidjlTaklXV3Z3cHd1SllkRlJFeVNtWmZ3cVFkME1WaG1jSzY5QXlh?=
 =?utf-8?B?R056a2ZMdXJtNjdLS2w5ZzA4bDYrbGZhUGtVM0dzeHloZURHMkV6QUZoekcv?=
 =?utf-8?B?cnI0dm4yWWFwb1JLeGZsVjlaeCtkMDdjVXhZUkpVRzJ6aHhCdzBXVUJPWkVJ?=
 =?utf-8?B?c3VxckNqWnBFZllLb1BZMWJvT2dBZU12VXJtYUxTRTZrVXR5VnE2amx1WFJE?=
 =?utf-8?B?c1VUN0hDaFFiZTRrUytnL09aRmNETGpyeTh6SHF6MFJCTENFMGxEZElSL25n?=
 =?utf-8?B?dDNXYWp1NnBFN3d5a0dTanpQRERXRDNFMjJkam4ybGNMMGF6Q2dRWi9zeDVI?=
 =?utf-8?B?dVBkNnR4UUFGOEk4Q0xmc2Zsc3JQOFhDNW9BSnM1YUdwZmhhN3NWZ25wTDRm?=
 =?utf-8?B?anJ2RGtFNzVuNThGaERmZGV6d2NqRUV2Z2pSWFk2blVSQWdMVEdJeW9NUUNL?=
 =?utf-8?B?Z1Q4T0NPOW5xamhzL2RkVGhGcWJLTUs3NEsrR2NBUUkvU1dteC9MckN0bGtw?=
 =?utf-8?B?R3BhSnk1UFNNaTQ2eFBtVlNyUlY0eFo0NmNJdjJYUCtiNERUbTNqK3FDcVRU?=
 =?utf-8?B?ZHRiRVNoOFBvNk9OTDFzazBYR29pMlhNNytzZnltUmp0cWFqbTNjRno4dkJN?=
 =?utf-8?B?TUs5ZHpWMFZHYXQrMFp6WlBOZWltUmNGMVdzaVFBSTYxbUppQjN0Nm1TaTBB?=
 =?utf-8?B?ZHkwdjRZdHNUNXNzOGZOVnV2dXlRdWZJdkRiZjlicjdhVjltajJYMmN5LzJH?=
 =?utf-8?B?Y05KUnUzS1ZQYjNqNk01cytBQWNSdTcxZTZzQk1zaFZQRVEvY2ZYeER2QjdO?=
 =?utf-8?B?b2NybGlLczZBSkFTNm9DbEh5RkFySmZpRmtodjZsRVUyVEc1cjVJaEVrektK?=
 =?utf-8?B?OUtodkJldFhBN0xwb05uUEM4TGlGemYxM2VQUDlwbElGVEtmN2VyMDU3bG8x?=
 =?utf-8?B?Qk1ldW1tN1k0Ym1vTFpMakRWa2tKd3ZhcnhVRWRYaitmMHFIcUhvWEIrOGVY?=
 =?utf-8?B?RFh1SHJiZmRqQnF6WWp5QldmWVBLUTRqVGNtcXgyYXRXYkNleHhHZ2t0YjYy?=
 =?utf-8?B?OHhtRGppL21pMU1qcDB5OUFpTUFPWDNPdVQvaTdRbnRXZVJkZmtOb1R1VEIy?=
 =?utf-8?B?WWZEQ0g4TVRrOU9ERFNRMXU2VnBhcTVjRVk0cFhJZ0NyeHBrRjBTTzJ0ZnJI?=
 =?utf-8?B?K1B0bUFldVVRRzFlbXBNaklLbWxZU2dNVjlmNEJMUFcxNHd4NHFGNHZrTDBC?=
 =?utf-8?B?UE5UK1kySHIvRTJQN0xKTlgwaG11Y0xTWk5GaFlGN2VRTVdTRFNwSmFQQXIx?=
 =?utf-8?B?d2xFc3BMaDVXY1dWdktRM0pRbHJoRVorSG43NERzUnR6aGpCWVR4QWZvR1lw?=
 =?utf-8?B?U05KUXI4NTJ2d0NUaVN4cGd3emluOXhCVU5NejVhWXhNcnF4SFlqcWd4SHM5?=
 =?utf-8?B?K1ZPNmtaSlVnelVKNXlWb09jOHlPa1QzUFppWlBVcHZGM1ZLNVNLVGk1MWFF?=
 =?utf-8?B?L2x6K0hZelpYT21XdGUwSjNocUNMZjlLOXRpYWZRaitmMUNRRWE0WDFKSTZB?=
 =?utf-8?B?NWRrZ3RveWExbHhwakNNRXZpRGtrd3g4MjR3cVl2VXB5OXhFUXhEQkNzblBa?=
 =?utf-8?B?RFh5em1PVXJBdi81S2ptQ1FaaGxQVVJCbWJ3WS9CWmp1QWpyK0pVY2p5RG9J?=
 =?utf-8?B?NzRxSkhiNUJxcHBXRlN3VW9EZ1p5Q0Y4S01Rbm1kajVGUktCcFpKdzJ0dVhJ?=
 =?utf-8?B?NWlIUko2N04wMkdHTUpqQU9rTDI2cDZ1a3U2aXBpTFRzbHBxakliZnNyOVlH?=
 =?utf-8?B?ZmJZakxqcDVGb1ZxSENock1YYkNuMytzWVY1NGhJUHNkMUF5YkR5MkNBVE5V?=
 =?utf-8?B?NFVGTFg4bjhydDhqZm9SOGZET2ZxeXFBTndOZlRNODNaQzk3WG11VVBuajg2?=
 =?utf-8?B?WEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cd25960-3459-4fbc-e9e9-08db83f5ebb2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:07:24.8948
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ToX/ttlcTY+jalbRnGJYbqw7mzc4D+Le29zEg3uMEFEU+RoC6GajLQR6r0e3AeF08yqnuM+6a8/shC2Ux2pytZztceysBJfC2TCwvdJFPWM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> fill_buf's arguments can be improved in multiple ways:
> 
>   - Multiple functions in fill_buf have start_ptr as one of their
>     argument which is a bit long and the extra "start" is pretty
>     obvious when it comes to pointers.
> 
>   - Some of the functions take end_ptr and others size_t to indicate
>     the end of the buffer.
> 
>   - Some arguments meaning buffer size are called just 's'
> 
>   - mem_flush() takes void * but immediately converts it to char *
> 
> Cleanup the parameters to make things simpler and more consistent:
> 
>   - Rename start_ptr to simply buf as it's shorter.
> 
>   - Replace end_ptr and s parameters with buf_size and only calculate
>     end_ptr in the functions that truly use it.
> 
>   - Make mem_flush() parameters to follow the same convention as the
>     other functions in fill_buf.
> 
>   - convert mem_flush() char * to unsigned char *.
> 
> While at it, fix also a typo in a comment.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

This makes the code significantly easier to read. Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette