Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b4fe2ca1-aba7-cc0b-b8a8-751181e11ee8@intel.com>
Date:   Thu, 13 Jul 2023 15:51:11 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 03/19] selftests/resctrl: Unmount resctrl FS if child
 fails to run benchmark
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        "Babu Moger" <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-4-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUc3T24rdE9iUkZ0MmhNS2I4TUsxa2R2ckROOGV0dkVrVExFcEhncnFDMndZ?=
 =?utf-8?B?bHNEYlVZZzVSZVlQTnVVb095c2hCWitXMi9YV25CZVZTMEV5Ymt2K3pweVZy?=
 =?utf-8?B?emViTVM0TGo0WFpMWnRiSngvZHlZQTd3amxqTlFrRkFaS2ozWU1FM3ErZFg2?=
 =?utf-8?B?dVNHNUJIdGdyQ3g0UTEzNUFhdnFhOE5vWXdrOURZRTVQWDNqblJSUmQzd01u?=
 =?utf-8?B?ZG51V3pBVHBYaStlNlIzRUhOWkkrUFZVMUpua2hGVjFSR1MzZTJXRHVrWnNM?=
 =?utf-8?B?Snh5TEwrbnh3L1diUnNzTHdEbGkreDV2ekxCaWZHU25pdWxJb3dWRGpzdmQv?=
 =?utf-8?B?dlQ1QTJaK2ZkVGozK2VxRXBKTDA0dUdrNVpWa1VnWXhaYjh1RXl5NlVQcjJl?=
 =?utf-8?B?SVExb0Q4bWVURER3bVdmbjhnRUhjNFhTRWN2cmpzOVlQR1gxbVNHMTdiNHow?=
 =?utf-8?B?YlhWOE9mQmlMSlVLMlIvTDlCU055Ny9EZ3B2U29iSzM2WmY0VHFUZFh4QnJZ?=
 =?utf-8?B?aXJLZTlQVFFkYUpiK1crUUVTZnRkcWlkaUxYOHBlT2IwaDFxMmQvQ3dwMjdO?=
 =?utf-8?B?eVJNdzVWZlFnMEJZaHd2Q0pKMUdES0FBSUQ3TEw2U1ZEZUd2alpETGtyeDhQ?=
 =?utf-8?B?WTBiQ0FITzhwY3J3OUJ4aGFqYzNzOEtKV3pUMGRqV2NsaWowQTBqOVdIZGl0?=
 =?utf-8?B?VnpQenl4WDRoQjdreTNBMHZIRTNKSFNNOTRGMnB6ZmFFQldOZHYzU2FzQXVX?=
 =?utf-8?B?MDh4a3Avc0QvS0VBSDE3T0VhaUNmUHFQR09OOUdYWTdGZHJZR1lxMEMxRk1m?=
 =?utf-8?B?dm4xaEdHaUVpMjRNN2trd0hiOU4vQTY1TjlzVC9vMlBkdUJSYjhZTTdJL1RB?=
 =?utf-8?B?TEN6aUdYL0ZzZkxSbndaYnByUkRZWTNyWWlDVXdQRVF3OXF1YzFiaXp5RGxj?=
 =?utf-8?B?cWkySFBwN3hXTHJKWnBvT0dlM2xrNTBlamMxVHRrV3I4R1UyV1g4bVZqRE9S?=
 =?utf-8?B?S2dBVitPejVyNm9ualJhQUlKc054OXpSTFRzWkh5Wm5hWG11MllEOWZ1SGxl?=
 =?utf-8?B?aWdlMHlnUDFZdWpOUkFDTFl0U0J5WFQxUnd1OW5Jc2FlZ285ZTd0K3FLVmtl?=
 =?utf-8?B?UXRBbENMaHNJLzNScGNmSTQrVnNZTUJGdHF0YkNaTGlxQkRLdHBWSDNMM2s0?=
 =?utf-8?B?dXEyTkhpMDllOVo0aXFsd1krMGRVRTZXRGJraTAzLzZiNk9oTW5UT2NpM2ph?=
 =?utf-8?B?d0tVQTBUV0FOTWJESHlxOVd6YkdKeG50ZjI0RFVucEI4M3lsYXJOWlRkakZO?=
 =?utf-8?B?QXFXWk1tM2krUE85Y2RvVWxxaWdLQ2ZVa3h2eHJnQlpvSkVOa0JuaU1yVGtr?=
 =?utf-8?B?MCtkR2RlS2VRR1Z4UTlQSnpOenVWL28zbmJUcHFUTDhlVGs1Y25CcnhrRkEz?=
 =?utf-8?B?bytIWWxWTkpJL0pxSEJSRUFnNkh3eXRYR29qdDZydXhEcU02aWRBbzYxU3o2?=
 =?utf-8?B?Tm1xQk95MHBCdnYrOW9xbHdHRHBoSHpFU294YWl4aWdibkRrSHQ1NllYM1JD?=
 =?utf-8?B?OVdaUG4rcnp1VE4rZlNOdCtoeFBSRWliUW5sa3k3N2U0MlVDNjVqUnRsOWxH?=
 =?utf-8?B?MkUxV21JME1OTGJTdjk3N3lzOVlCWU9neklNUWJ3TGhaOEhOdnY4d0ZsWDJk?=
 =?utf-8?B?SWtVV1RXYnFwL0I3akNBaXFhOTI1YmhERW1xdTAreUUvNHFjY1lXTlZBK01l?=
 =?utf-8?B?bXNZeVlsbWpkSFNNdERqZForUnVkeFMrbkloSHBsSmhoVHc1c0cvekJpdEtH?=
 =?utf-8?B?cDJ5RkE0cDcvbmxnZFRFY1hyTHo2ZXl2RVhuV3BlNWRDWmw3RVEzRjl2MnNi?=
 =?utf-8?B?R1hvNFFMYXh3cEk1RDA3dmIrdDRnellVZ2hWVUhEUHU2RWN2Zk13LzZWcHhY?=
 =?utf-8?B?MGpvOFQ0TVFjb2R0elY3dG5jeENEaUVPb2k1T2NZeWEzTkhWa1RKUVVpdDVq?=
 =?utf-8?B?VytTM1FUTGtVVndkRGNCR3pvNWxDMVlaWU5BbVlHanFYdzY5eHJPOHZ0Z3or?=
 =?utf-8?B?bXVkRGNUY0VLZE5mOFFKbUZKeFExZCtEaFpkRWhxZkJRNy9UanJSQ2s4NEJE?=
 =?utf-8?B?dEw0UlJOdUN6TFd4c1FNVzhHZmRxUm51R2kzVDdyektYK2dQTEE1Z0x3K2Iv?=
 =?utf-8?B?eGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a79a94fe-3537-43ae-5d50-08db83f3a90e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 22:51:14.1072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D0X/KbYO5w+O0Ltct3VQ+nx3IdYi4+l0z/s4sCs4qji7p7tMR7ccO8IlQHS2HNY63lLQxO1b8ekQ6VsYwCelH+lDwZ64bBhnkmwwSLphHfE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4689
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> A child calls PARENT_EXIT() when it fails to run a benchmark to kill
> the parent process. PARENT_EXIT() lacks unmount for the resctrl FS and
> the parent won't be there to unmount it either after it gets killed.
> 
> Add the resctrl FS unmount also to PARENT_EXIT().
> 
> Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette