Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92b3ef73-6347-b52a-69ed-c1b489b11d55@intel.com>
Date:   Thu, 13 Jul 2023 15:59:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 09/19] selftests/resctrl: Convert span to size_t
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-10-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-10-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXRWTUt1NHc0S21VY2I4TmthNHYxMm9iMXZlaHRHMUNMUXRyS1FxYjBmUDlP?=
 =?utf-8?B?V1E1R0ZNQU02MmRsT0YyUkZycUpiTHUrcWZZUFY4Rk1lOU1nTlJ5UlJuaU9z?=
 =?utf-8?B?bnZYU01PM1ljZ1RSRm1SYWljUmdCQ3FHUk5kazh2aVdndlpudXkwNmVINUlt?=
 =?utf-8?B?blhLMjRhaEpJTzBhWTdlVmxvbmFibWpSY0xDZTdHbVRPMDd2SU5rUzB2NjQy?=
 =?utf-8?B?WngwdUdVMFp6d0hxZGtLa3hoa3NZSXl2NEdmd1dYVDYyZTM4bGVRMy9USXQr?=
 =?utf-8?B?OWwxVXlTWk14dVcrVUUzUExmTVkwR1F4ZHJRMmRiVW5ONGt1WXhZN0tBVEFQ?=
 =?utf-8?B?clkzcGoyeTBIU2xpVS81dDNjVDMrN3N6VjRiSHB3Ui9TUFZHZWtVaXc0NG9w?=
 =?utf-8?B?K3dlWEVObStVUkpDcmJPRSszWWxhYW9nMXk0eFJ3TitZVjY3WVdKR3hFTkRP?=
 =?utf-8?B?SDZ5YU9CQmJ4Sk1yTkQrZkxKRnFUUUN6UlVxSG1SZTUrWVF3ZHJzRTVrZnJD?=
 =?utf-8?B?UWxWYll6ZVlERGFldlFCZkw1VzRpRTUzaGFxa2pwMVhoaGMxU3dNTXF5M2xH?=
 =?utf-8?B?OS9xWUdjM1RvbHJHTjF5bWVqbTNhOUp3dkdEaGl0QmgvNFM2Nkc3d2V2ZGF2?=
 =?utf-8?B?RGF6NVgwVU1OekFPdzR3cVJwdms0dUt2RG4veVcvWFl4RmwwOFovM05iTXJn?=
 =?utf-8?B?aVBJN1d2ZENrd1hBbXdQTnJhR3pKWlhjSTZGQ3BKQkxWYThVVVh5c1VZMlpD?=
 =?utf-8?B?RUUxWG1Oc2NmK1RTMkpjUjM0NGVYZDU2YXdaWUxkcE0yVm4rMDI3dTlEdGRR?=
 =?utf-8?B?NTY2TW4wVnNYT3p0STRZSEFtcTBzc0tKVVFJZTZXVFREb25YSUdjUUI0K2hQ?=
 =?utf-8?B?eHAvK0FtUnVjenpnRFpQa29KNjdpS2dSMmJWOHhielMyY2o5SFczZ3VObk0r?=
 =?utf-8?B?R3ZSM0tyTXdQZ0hjb2xYRzFtSXVwM3VuWFk3YXR6dFFYTG5zaWg3TGRPV0FO?=
 =?utf-8?B?cUhBemRzcWxWb1BJdGNkSzZqNDNmM3NzWDYxTUFidkc0K2YrQ09UZWZ3cFF0?=
 =?utf-8?B?TVk1TnZQYUpZd2MwUm52QlpsOVJBTVZJaFZlQmFWRllUNnpkOHZJbVlxdWdQ?=
 =?utf-8?B?Z0JhRWE1bXdUYlRLSkRyOEY0TEQzZGtHKzlzMXhWQXUrUHVyYnJhVzE1RnAy?=
 =?utf-8?B?Tld3OUs2ZHVFTDdDejRPZkNBR0pFTTRMTllmTGw5YVBHeGp3NlQzTUhuZ0pC?=
 =?utf-8?B?L2FKbnFZbTZ1ejVBR2Z2TVdza1BabmVFRlB4cnI1cGR4eE14emNHZDdNUGlR?=
 =?utf-8?B?RzJKMTZsTHYyQkUyWC95VXM1QVMyS24xVE15eE04STZGQUp5Q0JMWkErN1My?=
 =?utf-8?B?bEdqQi9DaUFFUzZZMktzNUNYdmlBWU1vRkMxUGdrRk00c1k3YW1jL2t1eGEx?=
 =?utf-8?B?eUxUL3BaWjdNNi9YNG5vZ0p2U1FqcnUwY1FNL0JGUDBscTVGc014RGh2ODQ4?=
 =?utf-8?B?c1MwajVjMjdFUHRaRE9Qc0QrZGZKd3JKVFhCdkhJZWFnTWxGNlcvVkxRRWtG?=
 =?utf-8?B?b2huKzhGRTNNMWxxRy80Ymk4U25yc21KNWhad2pQZ2JYM3ZMZW5YSnp4eGdm?=
 =?utf-8?B?bnJLRDFheUF1NUZvb3RrVERDVGp0Sm5NWU5qZXkxclF3bDFoNGwwbUZBejl2?=
 =?utf-8?B?aS8vajFWQ1RsdTV3R2NDUnd0SDBNNyttbTZ0b21Gc3g0RVdFZUdqMnJWMk96?=
 =?utf-8?B?c1NXd0pNY2RIaDJZTjI3SEZnSHNSRzlPd1E5ay9NUmJzQnJIRXZ6V21qNlVz?=
 =?utf-8?B?Qk5UMFRXSEZLY05USFlCVnRJUHhpdlMyZVlZcURxcGNMazdWRmhkUE5rOTJU?=
 =?utf-8?B?cU9rRXFZTFR0Z1RSRXBrcE5MMmFWSnBOWGFLNVEzNG55U2E5MjRDTlJBNkZ5?=
 =?utf-8?B?SWFLQWVEZ0M1Y2NzWUZtUUNEbGxoQVhRVm0raXJlL2dubVRFWE9SWmxxb3o0?=
 =?utf-8?B?UVE3ZjdTY1Y1ZnpxU1R1QWJxSnVTZGhCUTdBdC9pdlRzVEpNQTZMT0E2ZGM4?=
 =?utf-8?B?eHU4REZDU3NCV1FiYWtLazc4SitZOWl1NE5iOWFubmgyNWFMM1JFK1lqQ0Nv?=
 =?utf-8?B?Q1ZLbDZ3T2UyK2pyVytxcDRJdEY2NHBsenpGMUlNVEZsYkhTdXZ1M1pmOWNU?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 31e55f6b-14af-4086-5a2b-08db83f4ddaf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 22:59:51.8771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yR3+jymYumr8+M2V/ImHl8By1bJT4sfTo6jpfXSXbYrnJmKePoZfENUT4d7HyNMH5kiGSIpvnz75qqlJ/7C7QcWmsrvTlb8GldO5r3KpsT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5586
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:

...

> @@ -188,10 +188,10 @@ fill_cache(unsigned long long buf_size, int malloc_and_init, int memflush,
>  	return 0;
>  }
>  
> -int run_fill_buf(unsigned long span, int malloc_and_init_memory,
> -		 int memflush, int op, char *resctrl_val)
> +int run_fill_buf(size_t span, int malloc_and_init_memory, int memflush, int op,
> +		 char *resctrl_val)
>  {
> -	unsigned long long cache_size = span;
> +	size_t cache_size = span;
>  	int ret;
>  
>  	ret = fill_cache(cache_size, malloc_and_init_memory, memflush, op,

Any idea what the purpose being run_fill_buf() is? From what I can tell it is
an unnecessary level of indirection.

...

> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index f622245adafe..8be5b745226d 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -298,7 +298,7 @@ int taskset_benchmark(pid_t bm_pid, int cpu_no)
>  void run_benchmark(int signum, siginfo_t *info, void *ucontext)
>  {
>  	int operation, ret, malloc_and_init_memory, memflush;
> -	unsigned long span, buffer_span;
> +	size_t span, buffer_span;
>  	char **benchmark_cmd;
>  	char resctrl_val[64];
>  	FILE *fp;

Do we now need a cast in the initialization of span?

Reinette