Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <edea8758-78eb-6684-084a-063543f487ad@intel.com>
Date:   Thu, 13 Jul 2023 16:06:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 13/19] selftests/resctrl: Remove unnecessary startptr
 global from fill_buf
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-14-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-14-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnNUNDNab0FlRnZPUm1QRGp5TlFYRnJYaDQ4MHpNUENKVy81QTJHY3BXbFJV?=
 =?utf-8?B?VDN0b0RsREZKZ0haOEhyWThHR0FDR051WmxHMm01dVlMVEdJSm1JSFdEN1Bj?=
 =?utf-8?B?RHdCZk9BQkpsTCtuQmtPOWFMRFFxaGh6R3hUL1lBVTFrMXJOVkdpRHgxMTYz?=
 =?utf-8?B?cm5OVkMwcVJOc2pjcFE1aEMvYzFnRytIeHlMQjRJNHU4OTQrK3ZaTzYreGNh?=
 =?utf-8?B?TDJPeDlSVDVFcWtKUHFnNll4WSsyVFJ6ZW5zdjVlR2wzV1pFZnF6VWFhUE9E?=
 =?utf-8?B?dTZMQWF4cm9JQys3eDBzU0YwcFN6TEpxakZhcEt6RkFGWGJwV3ZRd3JYS09p?=
 =?utf-8?B?WDl2Z0d6YldoR0tBRWxrdTFvWkdLT09XZW5ZS3lEcEMzQzllTEtrYjBIVGY0?=
 =?utf-8?B?b1lNbnBTUitQSXh0dDd4WThqQkkzQTFXVmhPMnl6dDFicFg1RDJUYVFBZTBz?=
 =?utf-8?B?QmtDZXJrRlQ2SnlOeTJ4a0dUL2UyL2FqUytlSnIyWVNEa3M0cUFrTk9EenF4?=
 =?utf-8?B?aHZjV2xtS1RFZGtmN2p2VUVpeTE4QmhsOWN1T2NvOHh1QzVHNXB3bFhEZll1?=
 =?utf-8?B?TjNWNmVhRDFLU0xnYk1GQ3BvaWJRQXlxWHFCaUtWUnkySHVCT0FzVEVncDdo?=
 =?utf-8?B?bGZ3MGdGbi83K0JEbmJONlNFdWRKL3VONWpua0xyTEd4NXQyL0pCT0tUeTUw?=
 =?utf-8?B?L2lJQWlCaEtDbDIxS0RMMWRzOXYwYWtlaFRZbTVrOHBmbXlhUGpFY1E2dEl2?=
 =?utf-8?B?VHBYblBaNTZCT1Bpd0hFZXZQd0tjQmVhbGxWUEFZcnp5d3dseG80cUVFN0dG?=
 =?utf-8?B?bVI2TjFoKzIzZlpUalc4Qm1HWjlVTG9paGhrRXdSV2dQM0tiTk55czlNN0NW?=
 =?utf-8?B?VEI0cW5kbmswN1NNamFmeFZHMS9qM05EWFd1OHR6NmJ6MWJodG5nNC9zaHVw?=
 =?utf-8?B?eGFQMUZyMGs3R1NkUjExOWx4eFNscXRsTGMrVlNpY1B6aW1oMTRvRkxLY3Vn?=
 =?utf-8?B?ZDhoT2RHNi9sRUU0cy9PbHJpQ2dxUUtvWjJXTnJueUtZR05NK0JSMmd6QVly?=
 =?utf-8?B?bGNLNGFLaFo5QlhObEFJQUpOYm0vL3QvVEVuRVlIMElDYklKR2lnY2pVSVdv?=
 =?utf-8?B?cXRMZHJXMzhhakJFV24wT1gvcFhLakpDSVJEUWUyYURoUVEyb2t4SDhDa01u?=
 =?utf-8?B?eXVOY3lyZytmUVJxcjZxUFRvaUFReEE3Tm0vbXNCT2ErZlJNQmxjZTY1Y2Y1?=
 =?utf-8?B?aEV3Slp4K1pHVW82czlLRnZZM3hCR1YrV2E0enp6UXF6YVg5SE9TWjZXK1My?=
 =?utf-8?B?L0MwYSszWFg0a0NIcXlqWmlFMFljQWZnNEI4OVk0STZJL21qdFdKbStoVnJE?=
 =?utf-8?B?T2dnSjRSc0VhSkRmNHhlUGpTMjdHUnJ3RGxRWWIxUUdhU3c5T3JZQmowbDht?=
 =?utf-8?B?WXFVbmIvOFZweFFWMWRSaXNQbXk0djIrdDEweFV4TWlubnhzK1ErRUNUdHJS?=
 =?utf-8?B?TnNVUmNyZzVkbzBldEdWYWxRUjNQaDFQbUczdlpzN0xLb09kL0h0VThMNk9C?=
 =?utf-8?B?aVV4U2c1K0RoOHkxeXRVSVFNNGpOOVBpWGVybmpzcXV5VmgxbnBOZFhpeUJM?=
 =?utf-8?B?a2VPYklFbTVMVjVvc0NQZnVFOGh5dUZVYWUrdWEvVC9ZRi8zakl6Y0NlWm9P?=
 =?utf-8?B?TklvdWhibzBiSG95d3BRVlUyMWZrL2lNRHV4NDhNZ2dCaWRyNjI5bmZhOThR?=
 =?utf-8?B?WjNsaGwzNjFMU2dNekF3MFp1WmRYUDdFeWtPT1JEMmlsM3ZEL2RQdVE2Z0s3?=
 =?utf-8?B?RlNWT1JUUlpYODh5T3hBOHpsQjhXRE5WNGhXbTcrOVVSM00vbStQUGtCZjNZ?=
 =?utf-8?B?Z3RXbU1GM29yQzI0Y3ZvMm52YlBLSElyMDJZaWNpTzEycDVjUFI1SUgzcDAv?=
 =?utf-8?B?Q2UwaEhzR25BbVVUU2JlVFdPWVczcVdNWWdWT1o1WnhSTHZ3eUNRckVjeUxO?=
 =?utf-8?B?RS9TRlM1VndzMjZpaVFhV21PbUtwSFJFTWhHVFovZEI3Qkt5RmtPYm9vdDdI?=
 =?utf-8?B?Y3NjbFVLZ0FJWkwzRCtCVmswUVBqNm5JMERzdVRldEREWkVjemRUa2xibzkw?=
 =?utf-8?B?b3VuMGZtVHRneTM4UC9uVU01bnI4UU9kUW5HOEs4UWV0ZTdhUm9kNUtidmsy?=
 =?utf-8?B?anc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9007645-630f-46ae-d7e3-08db83f5c2bc
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:06:16.2168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZ77qllsMMaqUODe9NeOUAM42f6E/eYSXBEqbYfQXBMFdbOxm+rF35FkY9L9X8ryzVAF/QuAMylHyY5Dvj9jhQ2p1flbF+Q9R5n9x2vEjUU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> fill_buf stores buffer pointer into global variable startptr that is
> only used in fill_cache().
> 
> Remove startptr as global variable, the local variable in fill_cache()
> is enough to keep the pointer.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette