Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <26bbc621-dcc5-cc5d-ef53-db9ea7598042@intel.com>
Date:   Thu, 13 Jul 2023 16:13:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 16/19] selftests/resctrl: Don't use variable argument
 list for ->setup()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-17-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-17-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjJEWitPR014eXhUdEJkbG1rek01MSs0a0puRjNXblVMU2xqRnpjWWk5MHNZ?=
 =?utf-8?B?bCs4M2x4L0RNTHcyOHRQY2t6YmVSclA0Q0Vla3gxSWw1dzJ2aW9MTUhjT1NM?=
 =?utf-8?B?eW9hbG9kTXpac2N4cHRKNDdHaHY3LzR1cTQ0UFQ2QXdMSi9POGdiK2YyL0ha?=
 =?utf-8?B?S0FRL2hiK2p3ckppVXNEVzVmM0E0S2loUXBUTlliRjRrRnZETHhlb25lWkRM?=
 =?utf-8?B?SFJoT3c5TDFaSkRNRktCT01XSjlJUjlEc0hBOENOdml3eXZSZFZZR1hOVm5C?=
 =?utf-8?B?VVVSU0ZZekRwRTM3cnJWUnNzWXFGaFBVR29FN0VLYnZJTHRlaHo3dGV2bitY?=
 =?utf-8?B?cE1pTWQ1RFM1OGVQZ1BidW1SS2I4WG1mS0xvTVltZDNyS0tpU0R1NkVGZzY1?=
 =?utf-8?B?OFp3ZUE1SlpOcm1oKy9iSE9XUk5GMHRlYXJPZ2FYOXoxYzh0eXkwa1RwOEJY?=
 =?utf-8?B?U08vdHdzL0pvTkc5VGhkUkpPOTVyVVdQMVFIVk9KVnVndVk5WVNvRlFwSURn?=
 =?utf-8?B?aThBYTRmSVp2WVNtZkxVcHo5REY5QVdMU1hTWmVTRUpzSXVLNU1GR1M1T1Vp?=
 =?utf-8?B?cjJqVU81a1dwQndpT0x3MXVjcVNDNFpqT1lrR2xlQy9nejNSdG1UN21oQlNx?=
 =?utf-8?B?Q2YxMVFZN2RDQmF6cUtjeUFYeWtkR1dwMDFiQnU5ZE40WGl0RC9RTVV4ZERx?=
 =?utf-8?B?U0svRXBtU2FOZVN2blM2WnVSRHRPRWhOWWR2MFozTGMxcERGRlBpbHZ1QnRM?=
 =?utf-8?B?akFwRE5xcXhkQ0xBa1ZaalNIMTJjbzdrYkZ0dXhjdWR1ZDYwUFpEZ3l2UXds?=
 =?utf-8?B?ZFc1N01hSWVLUnBDYTNpZ1Z0QUN3UGZqWjNCY2xwTHZ4N29XUlpUQUZoL0gx?=
 =?utf-8?B?NEhkUWtsQVp2aGZjWDBTQXlETWlMbFRjRDRwRWJCRGhDTFBUUERJMWZWTDBC?=
 =?utf-8?B?ZkNCVGNzK1dvNWJoUFdCMjZCcDNXTWp6eWxZMFY3Q2FxekxVaGxpUVNkU2JO?=
 =?utf-8?B?eHhHRFBoVnpWRTZiQ29MSDkwZm8rVGZjWXBWOHZzTkJXSmw5VG9IY2NMcmpR?=
 =?utf-8?B?MmdjYUdHTVJqZTZjVEpwSFI0aDJnMHpPSXpUZlhXQWhGTmNSTWtpOFU5WStx?=
 =?utf-8?B?bGg2eFBBd2hHeGZ2ckRLaXZ2ZjYyd2ozYWsrR2pxZm9nU1VIV05hY3U4dTlV?=
 =?utf-8?B?VTRSSE1qN25tbzVEM1JTU3c1Q0tjaGFqOTExQUc5ZWpPOE9HSTNpOGF1eUNk?=
 =?utf-8?B?aTRrR21vNEkrU1RyWnA0SVVmbG5BeXhKa2ZERVhHQmJMWHZ2L1VTNGN6YVpE?=
 =?utf-8?B?MlJIOFNsUlQrTG41MW0rMGFaOEZIeXRYeC9UOHVPdzZFTnhTQWNLVm9lVFA4?=
 =?utf-8?B?Zk1zQzRtYWx5WGVCUS9ZZlB5QkhuL0FSMkRUNnQ1NnVXdlRpMlIwdjFFNzdU?=
 =?utf-8?B?WExyd3NPZVNtUDNITWdNc1JvMWJoWjlyVTJJRng3QUlKeTBHbkYreFMrcXA3?=
 =?utf-8?B?RUVReFUxT3E4ZlpoU2JEQlRsaTNhOGZ0TFlCcEdMMkZRRUhhMWozdzlSU0x5?=
 =?utf-8?B?Njlkc1hqalJ4Y2I5WmtMdGdTNUNLTktSYVlraTNhK2x1TjNaNWs2MDJCRlBC?=
 =?utf-8?B?dGtJQzQwbldPcGVwVFZWRExINlJ0bUthZG55Q0x3a2dXYU5uMktWd3FEcHVr?=
 =?utf-8?B?SnU2dDVTelNXYnhjMjRlNFhycjQwNncwdDN4TDhrZ1ZrdzdoODc5bmJxQWhR?=
 =?utf-8?B?MEZuZ29UK3l3SE5BNVBqcnFRVkVJa1I3LzZXWmFBWldqTmxTK09qT21pV3FQ?=
 =?utf-8?B?Umk5Q2ZEcUJLZU9TV3hnbHVXK2xkdVdYL2cwaGhxUGk5MWc1WlREVjZSOFVj?=
 =?utf-8?B?RDR1TUFTMXoxYmYxVWgwdnIrQlBiQ2dRdWwxZkd4UW9WaGwxc2VsMTIzU3ZU?=
 =?utf-8?B?NXJKclY4MWhJNzN1QVdpTkJmK1laTFBiRUtobWlBTnprOGxINkV0TStZVDlP?=
 =?utf-8?B?V3BtSGFNOEYwMG5OaThUTDFhbjVIbXc2anlJdGROOHE0YzQrVEE2T2VNOElC?=
 =?utf-8?B?UmlHUTVJN2Z6eEIzdnJsYVpSUXIrbXpXZzNZalB1ZXBYenA2RjBkVDREcGo1?=
 =?utf-8?B?Ynk0SkIvSHdxM3c5c2p1ZWVYUy9wUTdXelVNT2ZpQkVVY2E0cGtSd2hTMFh0?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca4634d1-4a67-40d8-2b3b-08db83f6d5f0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:13:57.9440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vw8FUPN6V7C3hgWQZuB6kAEGVcsbWuCmITra62uhsqEYU6IMm8BaiNCsgVSKE/umtYy9Opjep2g5XPuNTxt8sX5scMNRnQ9YXM0b5+RTs4w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6708
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> struct resctrl_val_param has ->setup() function that accepts variable
> argument list. All test cases use only 1 argument as input and it's
> the struct resctrl_val_param pointer.
> 
> Instead of variable argument list, directly pass struct
> resctrl_val_param pointer as the only parameter to ->setup().
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette