Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1dd10447-b03d-937a-fe55-ff324864c358@intel.com>
Date:   Thu, 13 Jul 2023 16:00:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 10/19] selftests/resctrl: Express span internally in
 bytes
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-11-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-11-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXFYRmV1MVlza1Eza08zUjNqd1VJMFRZeWdQNkVmMWFlMjZBdklyWWl3MFdh?=
 =?utf-8?B?TFRMaXFiUi9RSkJNMHNZdFU2WEF3SFVuY2M2WklyWTg3Z1VzMVMwdnlDcTM0?=
 =?utf-8?B?TWRQV2prQ1Eyd1BOZHNaMytUanlTUXE0aURlOFcwN1VINjU0RENjaGNDcDJN?=
 =?utf-8?B?UTJlOWtuNGN4bi9jUmN0alRWQVBPRlp1Kzk2WlpaYzRNREcweFdQLzNiS01B?=
 =?utf-8?B?anZhZExHZ2tmaU9wRllUenpkOHcycnh0OHp4VVZNZUhaQnAvY0IxSFYrejFx?=
 =?utf-8?B?RU1za2p3eEF1Rndnb3ZKaTkycjBqREdSaSsveTBrdUVwL1hWV2czZzRWMGsx?=
 =?utf-8?B?bU1saDJCYThJTzhwUGphTG5EV1RvemJ4WUYvRlhSNk5qY1E3TytvTkhEU2ZE?=
 =?utf-8?B?bSt4TzNjZW1ZaVFoeGVaRHdQLzdqRENvbzFKYVpPdm5la1Y0YWZGTitYRys5?=
 =?utf-8?B?czI3RGw2ekE5NlhmN0NIK3NkaTdIQWd3ZFBaYnJtNWNIMW5yaFNqNlZ1Szd4?=
 =?utf-8?B?dndvVGZLTDlaTlpSM3dpbmZ5SldoVnh1SkpXYmxtYldxUFJEUEdmUVp2aDRY?=
 =?utf-8?B?cVhzekJHWi9EcEZlcUl3bGE2T1lJbTNYaGxjbC9LVVlyZ2N1ZXVsU2VLeFZP?=
 =?utf-8?B?eW44SC8vWG1zTmt4VXljcUpVT0JpK0N3ck15TXRzVk9Zclh4S2hUUm1hTXdy?=
 =?utf-8?B?MEVhVU5QeW5SVVZOUFdKdTVYTXJqVlk2YlZmOWRCVWZDWm9ueWthZWxmbkxI?=
 =?utf-8?B?aDRFZSt3K21KNm5tOWpiZU9TTHpCb0FnNjVLcm0yS0VFTDBnaHkrRE0vSDlM?=
 =?utf-8?B?V1BUdUVib09zN3ZFRkVEZVJicXJtWG5YY0pQMlQyVFQybEdiamd5WEVYczZX?=
 =?utf-8?B?RngwL3lONmhocm1TMXkxSk5nbWpHcGlFNXI4N2R0N1M2T05YOWZRQjQ4Y00x?=
 =?utf-8?B?T284cjJlSGxQTXI4aEVuaXVOM2h3ckhZL1JKb2VWZ0YwbThRYXY0cXh2dkMz?=
 =?utf-8?B?THZ2dmdVMDZCRC9QbjFPUEJNNlVOTXpoaXIzNVhsNEEvUWdTTS9kdENmWi9E?=
 =?utf-8?B?ejZuSHZRalhiQzExMzEyK2pFQWJxVmdTVVV0dVMwcURMS1lTMGRwalVEK0Rk?=
 =?utf-8?B?RHdtakZPWnFXN0FKSlJjdVpkaFZTekxhUzJPMDZhd0hwbW9SMlB5SEdCSUNq?=
 =?utf-8?B?bjg3SW8vS2x6Q0FYTFhET1VpOEljaXdKRFJSaWJZS3VtdFlVUFFWQ0JiQzcr?=
 =?utf-8?B?ODVKZnRPTkdEUmE3UTdWSmRrT1NSeWdzUkRSSSs2UDAxZFBWSG5kVXc2V25R?=
 =?utf-8?B?aVMwZkRqTWVVRFN5cjRsdGpDWWoyWmF1UTFOcVgvM253d2RsTTZxSnFSNEVJ?=
 =?utf-8?B?dUJhYWcyUUcxd1hqaWVxZ3FUNGNPOTg1czViaTd6anppVTljOWJYWGZtVHNi?=
 =?utf-8?B?RDhsSzNESXJtdEN0WGtoWHgzSXhCZjBlNmVJcDlTYkhCa1gzTWovM1VhRWNu?=
 =?utf-8?B?eGdDQzRlbHJsUDR2aWhjdlpnZm0xcDNoRzl4dDZuUVROWUY3MkNyYTVsblR5?=
 =?utf-8?B?SEg3bGhhOHA0a1pLRURzNUJGZ3FURmozVExuVStsTTVoVzJCM0pEcWwwOFVX?=
 =?utf-8?B?RFh0eWhQeU5VdmJRYmhVL1JORVEwejQxdCtoMmg5WHhRc1lQMlpVcktiTWlu?=
 =?utf-8?B?RUordWlJRmF4RFR3M0NTUXdxN1FVd2p2ZDdwNUh5Y0xFK3loYkFHVHYxSTZO?=
 =?utf-8?B?WFpENlVEVHUwTFRYdkRCQXFXWjJXWTYra0R5NjUvbVVaSm9qN3V0Y0lyWWpi?=
 =?utf-8?B?NTlZWFEwMnZlQXUvTzdXOWJmTU5zNjdxQndOaG1zTTgzR3RhdnN1c3BZOHRx?=
 =?utf-8?B?eHIrcjFwTFBMaEFLNkVmWnJObXdUeEgwVzFSUGdqQ0tsbG0rOW5iSjRKb29C?=
 =?utf-8?B?ZStOK3VXN0ZTSjFSam1OVTlxdHFIOGZ6TThkRjBnQ1d4Y1lGOTJLbzZHbXBI?=
 =?utf-8?B?MFVlRU5KVFY5Yk1yTnRVa0VhUVVVZjFnV084UVVtd1luSDFaSW1OTkk5RzNP?=
 =?utf-8?B?T1hGTXE2cWxJMWRlaE1iNG1lSXd6c0J2S2N5ZU1oRWYybVNmM3BwQTY5ZE40?=
 =?utf-8?B?aGZGWFNzNFcyNHpjeHdTNy91dEVsVTRVOGJZMXN2SXZ5djN2T2dmN0xwbXpn?=
 =?utf-8?B?clE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a28a2cff-bd28-45c6-ab40-08db83f4facf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:00:40.7429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sIrEuJsvPF2Mt9oWLnX/vNFXU+8uJCXP0r/4JOtQDBdvOkQJTRq62ym2GgAH61VKhXyoRS458811Di29ShamxPuCo2UfZmM8l6ksi7MG+T8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5586
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> MBA and MBM tests to use megabytes to represent span. CMT test uses
> bytes. The difference requires run_benchmark() to size the buffer
> differently based on the test name, which in turn requires passing the
> test name into run_benchmark().
> 
> Convert MBA and MBM tests to use internally bytes like CMT test to
> remove the internal inconsistency between the tests. Remove the test
> dependent buffer sizing from run_benchmark().

If I understand correctly the intention is to always use bytes internally
and only convert to megabytes when displayed to user space. The above
implies that this takes care of the conversion but there still seems
to be places that that do not follow my understanding. For example,
resctrl_val.c:measure_vals() converts to megabytes before proceeding.

While MBA, MBM, and CMT tests use resctrl_val() for testing it seems
as though the function still exits with the MBA/MBM data recorded in
megabytes with the CMT data recorded in bytes. That seems to be why
show_mba_info() needs no conversion when displaying the data.

Reinette