Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6614e2d-9297-9d5f-c59a-e74cfc9d0b93@intel.com>
Date:   Thu, 13 Jul 2023 16:05:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 12/19] selftests/resctrl: Remove
 "malloc_and_init_memory" param from run_fill_buf()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-13-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-13-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SU5BeG5tZG5DbThxL3Rid3E3SFovK1R1SUVYbUVBUllYM1l5M1FUWGxDUHRn?=
 =?utf-8?B?ZjNHQ3pLbnhnVUd4aTBZbXJVUUJ0bnV2eHJ4ODZQZjBVWjhRYW51YmpzaEkx?=
 =?utf-8?B?T0dyOFozV3pNNW05SEVTSDgzL2F2MUwrNExpdUNSUU5yeldYRURCSUdnM2pu?=
 =?utf-8?B?VGwyQkx5b3ovTVJKOG5EM1dMYUZEcGlFdUJYMHNoemJIdGIvUE14ak5BV0Ri?=
 =?utf-8?B?djlGUXVCSFlhTnFodTNRVnNXbGJFamNTdlRwK0pFSkNsZnNMcXcyTDdub1FV?=
 =?utf-8?B?N0N5QjRWNlpPMWNVdmtNd1RBU0xZRjg0S2wyY2dpSkZ5RXBQTnlSaWhIcjlp?=
 =?utf-8?B?ZVRFM0Q3VWVaUzRsNUw4dStucExVWHhGR05HK0JtV0xvZ3B1MGRrQ0dHUVo5?=
 =?utf-8?B?VHowL3lJQ1BUcUdpbmhrdFhJYStyODM3WVlGRkJmaHl1Tkx5ZUw5RDU0dmQ1?=
 =?utf-8?B?aEVnMDJZOVhGNWpXSksvVzhNVkJINmM5ejJ1WmI1eVloNG1oWmo2Wm5ZZm5p?=
 =?utf-8?B?bnBQZVhnaUtacDNTVWVlTy91NGNReEJZNDN2QjBOcHp6OFp4UlRZakpYVlBi?=
 =?utf-8?B?Ty85WUp5anFNZUNuVFJJMU5BdmxTcGpmU2dCYTFIUEJUdTJlN25acmwvdG93?=
 =?utf-8?B?NTRrV2d5MXVLdEFQVFhvckZsMUVzdytURFlvNVJJWnU4WkpyOHYyTlFIREty?=
 =?utf-8?B?R09VTnoydGt4Szg1cDRrMWIwVDYrVGhkTk9nRTlJZE9Nc0FvVnhhNFlhY1dF?=
 =?utf-8?B?NEcyWHZrRGhBMkYxc0hjQkhHekVmclg0YmNjVllzWlN4QVVaTzl5MlltUjgv?=
 =?utf-8?B?MXNKY2VzSnJ6OTdGK1BQMTltNDBYZW5Od0U2SVNSTlFKSkN5V2puMmhTbTlw?=
 =?utf-8?B?YWdxNVA4T3lDQnErb2UxOWFIbmVhMC9RZXM1ZXl4SXFydXpKNkY1ZFFHVCsz?=
 =?utf-8?B?KzJLN08yUzE0S1Qxd0hHaDByWjdNWTltaksyc1JXSnBqWHZWYmlYM2JqT3p1?=
 =?utf-8?B?VzdSSFdTc091UlNkZXVhaktxSVcwdkRIR1EySlpKVGpNa2d3ZHNXSnVnd0dN?=
 =?utf-8?B?Tm94UUdvNDU4MXRmTjduTzFjcU0zR2ZLR3RWdThGNy9ud3dmdzd5NysrYU9J?=
 =?utf-8?B?aWFzRldGUm9NU2NVVzh6UkJDQ0hrR1RDOTZ3UklvNE40eEt3Q2Z2TUVDeUpP?=
 =?utf-8?B?R2xWdnByYkVabnduZHErandiRHAyYno1QklpeDE0ZlNvSVdYcmE0cU51VWth?=
 =?utf-8?B?NnNGZFRhblRYcFRxd1ZENEYvM1JKRkFEUStKb095azRLY0dYUTlhc1Nxa1ov?=
 =?utf-8?B?bnhvRkFIOVpkajlteEg3dG5icHdyY1diQjZ3QVZxenhsRTBHMEdLaSsxVCtV?=
 =?utf-8?B?TTZWTnhTdWVYcTF0RmVQSkpVRHdSejc4Wnc0SThFNnpKU3FrNFA5VDZSTzdk?=
 =?utf-8?B?Uy9hV04zMnFQeDBDa0d4RnhrZEdsd2QvK1lLeElGc2ZNSjhpTnJ6YUwrRzBq?=
 =?utf-8?B?UGpveFNibjU5YTBXQVJ3dVV6R2VqWmhGeFY2ek1hU1k5VDVLbFpXUmlHWjJW?=
 =?utf-8?B?c1JQNEJIYkNlN1B5aWhmYkNGdnVHMUpYbDcrWjg0M0FvM25sTklEVlBzYnRL?=
 =?utf-8?B?RmRrTEMycDBqUVA2Q0hCY2VUY2VXODhsWGdxemNnbGJSeXBySHdMaHBRYUJm?=
 =?utf-8?B?V1Z6Qno5cmY2anR3RmVla1piMjZ2OFR5Vmd5RWVDRzBnZERiekljNVE1YmEx?=
 =?utf-8?B?OUQwbnJCWUVJdDRIL0hZOTM4aTV2UEx4R0JWMDB4c203RGVzYkZCY2VVamNL?=
 =?utf-8?B?TVZaYitwbzBEbW9ad3M4RVZMQWN3cUNWUElZTC9pamdDYUI4Um9sdSs1SURj?=
 =?utf-8?B?c0g4WGVuY1NLNG1FQzcrTHNuY2MzeWwxMWZFUSs4R29PWHNwTUxyTHF2STVK?=
 =?utf-8?B?cyt5NDA5YlFITVJMelZNMTJvVU03VnM0cEZ6ZWduRXBZZGxEbzQwSnlLNGpX?=
 =?utf-8?B?YkNvZzk1N2V2Z1BVb2hTbzZTcnZ2S3BDYnNNaDlvVG52QWRuVFlkU1V4bFFF?=
 =?utf-8?B?Y1h2bGU4NXRjd0hrbVNNZldlZFBrZ29ZZjdkVUt4R3MyMSs5TlVKODZ2VFhU?=
 =?utf-8?B?aHNWQnNMckpOdUd4L1JEalZxSEk1bUo3bm9jdDJlMDh1bjhBZHY5Ynh1RWxR?=
 =?utf-8?B?REE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 179fb9ed-8d9c-48b0-ba8c-08db83f5a8ea
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:05:32.8442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RDmId2fa8YFn9x6n1VuAwQOG6MkVqomyEdWQtAj82IJLYecQORSZ4Y2AexQKdTVo7A+0DVoDPZNkenyW+yedMlEQL+lZ3/HOrpz9w+wF1Mc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> run_fill_buf()'s malloc_and_init_memory parameter is always 1. There's
> also duplicated memory init code for malloc_and_init_memory == 0 case
> in fill_buf() which is unused.
> 
> Remove the malloc_and_init_memory parameter and the duplicated mem init
> code.
> 
> While at it, fix also a typo in run_fill_buf() prototype's argument.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette