Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5db919ba-5d64-fb75-4f40-ce18c232f20b@intel.com>
Date:   Thu, 13 Jul 2023 16:10:57 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 15/19] selftests/resctrl: Don't pass test name to
 fill_buf
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-16-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-16-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVdUMDZ0am5jbXNKcUo1OXlzZ3o0SUR5S3IxemJKdkJxMHNxT0RUL0M4SWpQ?=
 =?utf-8?B?OE5LTWY2bUk1Y0pIcGQ0eWRCZVFaM3BpSVNBcktqcklGQW5wblNZdzlZTks3?=
 =?utf-8?B?MVp2bHUyNGV5REFFY2ZYcE90bWc3b1RaNTNQbTNhbHdTRFpsZFA1OHV1QXF3?=
 =?utf-8?B?aVJHMFp3MEFLMCtvV24xdE52SXEwRHBlL0o5b3RRUGxMZmJKTnBLZWl5ZENu?=
 =?utf-8?B?WXk4UTZ2RGt6S3kyYnVMSi9WelVnUHFuOGJjMVFPajBMR3ltWVdzTmtWSGh6?=
 =?utf-8?B?WHA3OGtwZ3VoNThIWDRZVWQ4Y0NVbTkweVM0dkFzTW5DUS82cDcrdVBGc2lP?=
 =?utf-8?B?Y2duL3hETTlSZW8yV2dQbFlURzVuRUFsTlhhL0NWditmdWtCSnJrNTlSb2RQ?=
 =?utf-8?B?bktnRkt4NjFBMytkUHhZbFdRVGZZSTRURXBiOVBDN0hMM0J6Ykp1WDlCOTIw?=
 =?utf-8?B?NHlTUGh2amF5bDFCOHg2UWlpM3Z6VVpQTlBoVlpTV2xQUU03aEx2amxLRVlh?=
 =?utf-8?B?ZG03YWVmOVBJUFNCVkJkREgvVENFUjVCdGk1WFltOThwL2t0TGliRXB2TE9X?=
 =?utf-8?B?ZTVyQWpOUjVwTnlJUy9Hakc2UFcrNm9IM2VDYzlHTmYxa29lTGs3Mm1heUZC?=
 =?utf-8?B?d1lvNCtneXNiUU0wN1VTa3NzQ3QzWUMxeGNpS3VVRzN5azFGcm5vZlVVU0dS?=
 =?utf-8?B?aEZzZGF5TS9ZMG5NYkRjMTdJWGdWeTN0clRsSFJJYnpVVlZWQmQyRUFlRDEy?=
 =?utf-8?B?R3JjbFY5VHBkaHUxRURsOGZpRjFGNm4rcjk3eGFGK1VTZ0JsaVZFQndxSVFa?=
 =?utf-8?B?S2Y3S255dUtjSStvMjl2c1FHWnVSaWhsRzFCR3BiTS84NTA1NU13dHprQUdM?=
 =?utf-8?B?ZXRWUEVTVFJDRW1BSncvZk4wRWhzZHhUd2NvVmFDUTlNcFQ5N0w0ckhFWjA5?=
 =?utf-8?B?aG8vMG9iTjdXd0JMZWNuN1NQVEFJcnNIcWFKVWcyNzE5RTEyOUNCYk9iNHRN?=
 =?utf-8?B?bDNMbStuRVpucWRsY3YxbWtHWThrTS90ejFiZ0pHelBCc21hampzTHdnRXZ0?=
 =?utf-8?B?RWNJdnpNUStPaEMzcExIMVVpZEtXUDhlaGhRa0NqdnhJdklrTU5IV3ZWOUZs?=
 =?utf-8?B?anU3M2w0aVI3WStUUmZpeEYyTGdyVHhrazlMdlVQT2owVGlDUWNzdG1nM1dU?=
 =?utf-8?B?ckNib3VZbUhscHJIWngycG8xUlpMMlZvUVdmWFpqNzBpVDBzTDU4eW5iZUJX?=
 =?utf-8?B?ZHhhcytkK3ErNjVBZmVYZzNsMDRRNVFISkZFcStGWldZV0VtUUlkckl6VDIx?=
 =?utf-8?B?Zmpxc05kYzBHQWJ2WHQrM2VUYWFaMUUrWFNHcjBzOWlaa29hbHNSN2dXczlF?=
 =?utf-8?B?UWZaYkxSOFlNb0FZT1ZLY0ZvaXlsRGJkcmg1WnRqWUtvK0ZnQ210bXJUbGJK?=
 =?utf-8?B?Q3lEQ2tXdUVtMnhWMVlnNUZ4SzQyS3hxZVdwVWFJRFRhWjRGcENoZzFTQVF6?=
 =?utf-8?B?Q3JzU2dwa2o1RWNJUG94RGgrNHVKa05qa1g0OTNnc1RPMzR3ZmxEelkzRXNl?=
 =?utf-8?B?dzliLzdVeGFlR3lEb1hoYVlKamJ0RHFzVVJId3pxc2F6NVpDSENTcVhBa1RO?=
 =?utf-8?B?WHBjc3FLTklFYmprTGpRVnFjQkFxVE5PeVN5Wkk1bEoyb1BtK3BjaXpQWFFv?=
 =?utf-8?B?Um42L29qOHdWWUVyM1BsOXhLWE5NaTh2cFNpYWNJbmpvQzFwOVZPenBZd0gr?=
 =?utf-8?B?aXdzZUw1NjBXMFRkTG9tMUZpQlB2RUhmOVlGQmlGSktpREREQmJ3aWtob2Zn?=
 =?utf-8?B?MTZ6WFFYd0ttTkp5VTEzU0ppNGJzZ0NTL3dIUGpsZEdYZWlnK0lXTTdVbndh?=
 =?utf-8?B?SXJPWlJsNEZNU0dQYVYrcktzUkw2ODRzdWxMRXQxcVZCQ1RhWXBLMWdkdElO?=
 =?utf-8?B?RXM0cy9RLzVnRkFvanFCSHNKbHQ2S2h5RTBXUkNBeFZZb0dOdjEwMDRieUEx?=
 =?utf-8?B?K0gyUDlpdkVDdTIwckJuVGVtUlg1dStQZktZdEgvZXdkVExCUHo0cGRwT1BC?=
 =?utf-8?B?MlpycVpGeWtFamh4T1ltM0NqSVV3eWFxanRoNzkxYTU4bUd1MXNpVWdMN0ZC?=
 =?utf-8?B?bC92WTdWQW1EdFhOQi8vdmplVzNYSzl6bi9ocnNHRFF1aWNFb3hncTgvNjgv?=
 =?utf-8?B?RGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca6321fd-ca5a-478d-ce51-08db83f66c02
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 23:11:00.1742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NqUSlB5f4ttnHkf0qVfH9owIU3Wwcwi0+3qTyY3agEwbPMkrzVnJxqcaw+m588sb0EG+uEyYk2pA6EOFwZXDJ9xEpD+KSIWwgAa3WA0PJe8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> Test name is passed to fill_buf functions so that they can loop around
> buffer only once. This is required for CAT test case.
> 
> To loop around buffer only once, caller doesn't need to let fill_buf
> know which test case it is. Instead, pass a boolean argument 'once'
> which makes fill_buf more generic.
> 
> As run_benchmark() no longer needs to pass the test name to
> run_fill_buf(), a few test running functions can be simplified to not
> write the test name into the default benchmark_cmd. The has_ben
> argument can also be removed now from those test running functions.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette