Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2622f293-9de9-c876-2892-bb3a1747dae5@intel.com>
Date:   Thu, 13 Jul 2023 17:04:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 17/19] selftests/resctrl: Move CAT/CMT test global vars
 to function they are used in
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-18-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-18-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHRhb0hhSDJLUVkrdzBiQjlhQ2tjSTYzNDdzaWJLY3Ura2RiMzZVT2Z3TEN4?=
 =?utf-8?B?M1ZESk55S0RqYURwc3dPZ3RsYisrWk9xRmxORS9CVmI2ektlWndBR2N3Yzcy?=
 =?utf-8?B?MWZLdk9NNE1nbnFnU001RXRpL2tCQ2NuQVNBNUF0SC9FRUQ0VHV6NGlvVmVr?=
 =?utf-8?B?UmNWcHRLMzlLT2R6eW1HK0drNGNJakhrQXVHMkltYlNlNk5EcC9rUEtzWjBW?=
 =?utf-8?B?ZjFQK2k4SGp6djZSaDJmVk1oODRiSmR4SkF6dWNlemxLdCttWjdPVUViM1FT?=
 =?utf-8?B?eTd5S3V0TEhRU2tMaFlIdlJzTW14K1hlMjlvK1NmeE1mb2JpVFhoWWNyOEtP?=
 =?utf-8?B?aGQ4QTZ6eEs5QVR6ekY2RFdZOTFnOWRIRDZZZ2gxK00xU0x1a1N0WHJ5bTYr?=
 =?utf-8?B?cnZuY1Q0V3h5eWZBM2Y0YnNyWUJvOXNzUDNBOG40Q3lTdGVHQk9RN3IrZGVQ?=
 =?utf-8?B?NEtDL1hXbi84MFNlY2VsZXRqK3ZWWkJlaEkwZ3grZFloUHhCd0lqc29XSi9s?=
 =?utf-8?B?dnYvQkw0ekp0QzFuWEpjOTlFL2dnOHFNSDV5eGdwTXo3RCtucXRwODUxM0c5?=
 =?utf-8?B?UU84bEhqemxRdEZ2UzN3eFlRa3h1Q29KeDdxU09GdVJOUUlHVldVckw4OFQ3?=
 =?utf-8?B?ekdsTHdkWjFDWDg3c2M1c1hnZGoxQUFZVVVtWDRTVnhCZVJ0RmJDbDdqNFRs?=
 =?utf-8?B?aTYrMUpxTHFIalNuZHo5Mzd1UFFDVGFrUS9aWlVHMFhyV2hTV3BjOUoycHEw?=
 =?utf-8?B?dFNVbW9KOE8zN1h1MG1aSVhDWWFQUlNEbnVPcWVCeGVya25NRzltejYvamZY?=
 =?utf-8?B?TXBTbC9FU2c2bzJ1N2kxZkVxdEtDUzNaYWxmWm5LOUVRM3pGMkNXd3BxblVF?=
 =?utf-8?B?SG9MSEFqMkpQUmlueStmZzZPSVJNY2ZZYm13T2ExOGQ3eWUzaGE0OTRpS05B?=
 =?utf-8?B?SXd3SGgrNUNtWjY5QmY5c21kTUNyWkV5SXB6YnBWY2c2QVdaU1FVUFdDbnM3?=
 =?utf-8?B?ZGI1S1MzZVUrbmlyNVkrL09qWmNMcThsVU5HV0ZhaGNCZjE0NmxhNnFEeVdj?=
 =?utf-8?B?b2F1eWs4VzE0UHBYdHpQY3d0V1BYR3J3ZjFYZCtYbnZzZUtlcTNac3J0aWdX?=
 =?utf-8?B?ZU1pSzNXR1owbGxtNVo4aDJobDVPc0VxSEZWZ1M4TENOSVVyK1RlRXRSR2tO?=
 =?utf-8?B?eFZpcmMvci9sam1BYlNMUGg1RGtaZlVWd0oxZHQxSDJ3bnZFNEtJTkxuYjQ3?=
 =?utf-8?B?eHlWTUdvV0cyeUNnRnZGNndzOWEzM0FYcUJyK0E0NzVZdTlvZWd4QWZhcUxX?=
 =?utf-8?B?M08xa09nUFBYSUNMWTg2Ykh6YWJzbEhWR0o4K0MyRzV6WDNOeHc2aEZ2Y0lz?=
 =?utf-8?B?TzVmQnk2QmJPbS9wTDU5S2Rob0JRdXNMZ3pZYWdaMGZXOVU5SkRja2drbG9n?=
 =?utf-8?B?dlJ6aGYxdnp0dlBWTlBMa2phMGphS0RTUVNIWHpYYWFGTVptRmpkd3lwL1Ju?=
 =?utf-8?B?TFdIalhwaUdMNUZqdCtNMmRvbHNXVmZOVWdML2JvQVI3MlhKVmdnbEFndWk1?=
 =?utf-8?B?dytoYjRnTUlRV1FzRXVkUUxINmtJZDhIZzc5dG9mRUVGbE5zTExVeUlwZzd3?=
 =?utf-8?B?SkM1Q04zL0pxS015ZVlDbGNCTW45aVg5ZDFOc0JORnRoUHdqL3RWd0RKdWNw?=
 =?utf-8?B?ZzJjaXJjV2VaWGE1TjBvMTRKUE1lcjJuWDA0MVBmNGlnOGxHcjk0T2tkS0xF?=
 =?utf-8?B?RjZnUDh0c2FSQyszNHpuUCtwSzBncjdiSW93ZW9xZE1DazFUemkyOXMvdnM1?=
 =?utf-8?B?U2dTMHBlbjd1U3pzZFZrbE43anBNQUpZMFhEaXkvNWNhTmQrZ2g2L3dqR01V?=
 =?utf-8?B?Uks2WE5KM2xuYWZPMlF6b2xkODBMcG5pVjJPOGI3MzZKelpsOHV3Wk1KaWxQ?=
 =?utf-8?B?UVZpVnV6T3IxS0VYZXJKM3oxRVBhUEdlck9rSDZoalJVdUF3aTB4QTZCMEdO?=
 =?utf-8?B?VTdpeU1mUS9nb0MrcGpFMHZYdUlDK1BSUS9CT2c2SldCZ1VPZ25STGZ1V3Yw?=
 =?utf-8?B?ek14eWtLRW0rbjJhdjMvRndGeU5Pbk92TVEyd0dMMDErUWNoM3lYMkFzN3Zr?=
 =?utf-8?B?eS9vaXZmQlgrSFpuemVEdU5tU1FTNHBGS2YwUElhV0ZjalFRNHVsclFXanMw?=
 =?utf-8?B?d3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc2eb79-0fcb-4ab8-2852-08db83fdef8e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 00:04:47.3781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zjiIXkzT8ENmhbS3b5QpznoEOYTfBNYGmeJyvMFIBAZwqxXiCH62JaRXmHTa+tezFknX8r/IcoZCcGKCjow3bk8xj+D6GgsHhgbyBboYr3k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5348
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> CAT and CMT tests have count_of_bits, long_mask, cbm_mask, and
> cache_size global variables that can be moved into the sole using
> function.
> 
> Make the global variables local variables of the relevant function to
> scope them better.
> 
> While at it, move cache_size initialization into the declaration line.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette