Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76b47b61-f54b-78a1-17de-998b2cc47bd8@intel.com>
Date:   Thu, 13 Jul 2023 17:05:37 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 18/19] selftests/resctrl: Pass the real number of tests
 to show_cache_info()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-19-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-19-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWRHVTZTMmZPLytiY0dCQXpVNXF0Zk9zTnFXeVBIT2hLb2xHMVV1YmdjN0R5?=
 =?utf-8?B?NzM5cVF3SVV3RTFEbFNnTGM2NVdiUmM0eUppaVk3dUxzOFlOMnc5WlZOdEk3?=
 =?utf-8?B?TW4yNnNkazVUQjY1VThMaHFRaXYxWXJ4a1IwZUY4L3hLRXU0eElndWplQU1K?=
 =?utf-8?B?Y3JIWE9yZXM2NVhnSG1EVVdXYmgzdnlENmxIbkVOa25NdUJIdlowRzVZSnRR?=
 =?utf-8?B?eTV1SW9Wb3NGOHNuTzRWaW8vU0FiNjRRL1hiWklyTWZmdG94VzRoeWN0aDRz?=
 =?utf-8?B?ZzEwREwvOUFUdTNPRXhvL2R1cjRqRjYrLy9QTUVxbWdxblV3TVYzcXQ3SGM0?=
 =?utf-8?B?V3hHaUpYMk5NaERwWW52RVhtTjFVc1kxNmpRMDk1dTZ5ZHNxR0lUUGFqV2pr?=
 =?utf-8?B?NU5ESUphK3BiVXZQd1U5Z250bmp5M3ZMdXZlc2hnU1kwNnJRL2d5U2ZJb08y?=
 =?utf-8?B?Ujk4ZUllRDhpMnE2VE9tc1h0ZlIxVmNvOHE4YitoclRvRExHMzkzdlFNb2FZ?=
 =?utf-8?B?VFdkN00rRU56RzJWZmZqQ29QdStDb3dMNmwySDhxS2c3T20xN1Avd3Raencr?=
 =?utf-8?B?TjgramwxUkpCNWxpSGl3NVhVNENFREk4eUxobkhJbDhzaWE4ZnkwNitYN3gx?=
 =?utf-8?B?MENOZDhwN1d4djkrTE94ZGJvRDczenZZL0VWNWRxbFBmWWViK25DSVBzQU9V?=
 =?utf-8?B?NWhia3YyOHd0NmV6dW1JRXAyZUdwalpkWUZmckIwaTl4R3BHd3R1dXEzOVNk?=
 =?utf-8?B?SmJoazlmMTdUdHptemhwNTR0eXhoUVRiL0ExcStSWUtKODNhWEJLL2hyTEo2?=
 =?utf-8?B?eTBUcnU5UUpqdVZWUWwxOWR2VENUVGlFMXI0Q3lhVkdxUFpmdkE3bGg4YVlN?=
 =?utf-8?B?WFNHdW4xS0x3NllzQit5Y3NjMW9kajV5TzlNdlNEUUhQcjhFemk3OHR0alhw?=
 =?utf-8?B?UXZuaEZJNEYxV3NHK2JFWnF6K0E1QTJxS0JyaWhmU1RVSHYvbVdnTkljTG5R?=
 =?utf-8?B?TTFLdmo1dmdkancwMmMvREJTUjJPU3h2YVpOdkF5V3UzOTlmNVRSYktYSGJK?=
 =?utf-8?B?dlEwUzFBRjBNV1ZqTUpLL2NETUVGRnNjaXVsb0g2alpUUDJQVWIxbktCMGlU?=
 =?utf-8?B?YjYrMHNOdENFVkJ4RkdTcHc4b0o0cTUyU0tmckl6VHBWNnhwNnV6V0MrT2U3?=
 =?utf-8?B?U05OUWZxWVBiUTJCZnIwL0M4QXE1SklpREpSU201bnJhV0ZBZmdKTmV5V0J4?=
 =?utf-8?B?S2laNjd1RkhYREJTYnREbDAydmdpeXRNUHc0c0pTbjQwbDQ2ZEE1dis1N25a?=
 =?utf-8?B?aitRc0VmYStMOU9DMWtNN3lweWoyczFLOXk1bWtGeCtmS05LOEZyWjlidEE4?=
 =?utf-8?B?MGRPUjFoZFZBOTh1Sjl3Z3Jna3p1d3o2VW1FdXlLSVE2dnlyN0c2eWFFNlpR?=
 =?utf-8?B?QVIrNDB4ZWE4bTZqUmtnMlZ6VEdLVitzTUdadUE1c0NyWkdlWXBYSmNIU2VR?=
 =?utf-8?B?UUVmZ1FMUzVFd3JBTk9zMWxmUmRaZlJ4WFk1K2hLVEYvM1BZbThnNkNnTXFj?=
 =?utf-8?B?d1gyTGI3aEwxUy9iTllRYWdXN1M5SVhZL2ZFS0liYTJ2czg2YWFsRGFjdEMz?=
 =?utf-8?B?NzhsYTl4QXI1SXhweGRHUDRlME1vWnpYWUExL080VXZMZ2o1MGRwVFhsQ0Nm?=
 =?utf-8?B?dkZCcDI4ZSs5YnFQZ2pxQ0ovSmtRd1Y3QWY4aE04RmIrTmxORFhVblNlVWFy?=
 =?utf-8?B?TUNSZkgzekJKbzRTWU5SZ1AxVjI3dDVUc2E1cnQzU0l3TDFkMi9YdWs3Z0lF?=
 =?utf-8?B?bTNBQXVKNmdONENUS3RzWWUrT3NsVHRhazRtaWFMOTRhUTN0akJDMXE0NGdX?=
 =?utf-8?B?dWp2RzVDQnJ5ZWtnS20xb0FjeE5uc0RyclVWd2RReUhkazY3aUk0S1QrSEJk?=
 =?utf-8?B?cUU2YWhVUlI2aCsvRTdxMC96SXpXVjVNZXZKZ0ZQbjE4RkVCTlhqWXdudEdk?=
 =?utf-8?B?aVZ4SmJGTlpMcnZEZjNlNDFjMDFoNmVKQnMxby9LS1RvcWlib2ZwdmpWbHZT?=
 =?utf-8?B?VDZtSzQraCszRGtPNmxudDZDNmFZWmw2SzdHZ3ZrQVBobTBNcWtEZmtpc2ZX?=
 =?utf-8?B?Z1k5MGhFaGFCYVNrRTRoUnM3WVhscDNoRFFTWTBTWHBrRGtBdE1CWjJqZVhV?=
 =?utf-8?B?RFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 044c179c-2aa8-440d-529d-08db83fe0e41
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 00:05:38.8635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dIS+vLW79ZNUUhsExGo5RypEEBg64r828t7rC+4adddjGC1AzUXBCFlJCasiS+2n///AEQxq+NkqpFbcN5VA+ktfoO+QYMS4sGqgffcih4I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5890
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> Results include warm-up test which is discarded before passing the sum
> to show_cache_info(). show_cache_info() handles this by subtracting one
> from the number of tests in divisor. It is a trappy construct to have
> sum and number of tests parameters to disagree like this.
> 
> A more logical place for subtracting the skipped tests is where the sum
> is calculated so move it there. Pass the correct number of tests to
> show_cache_info() so it can be used directly as the divisor for
> calculating the average.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette