Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16dfd928-9493-339d-b30a-fb76f953c5b6@intel.com>
Date:   Thu, 13 Jul 2023 17:07:59 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 19/19] selftests/resctrl: Remove test type checks from
 cat_val()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-20-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230713131932.133258-20-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlRoNEFqSmVoY2tITVdoV3VydHlJNGNPOHpFZWx3NjlwL1hIUUdnV1ZNNHI4?=
 =?utf-8?B?SS9VcGMxSGdaWXpRRjNCb1NtRGdVN0VUWkRmVGNXZXNJTHc3anpFeFpTbVVW?=
 =?utf-8?B?UjNNdlpuVTlEM3FvMUxSaHE2Z21jcnRrT0NYUHNucUhZd3BEbGQ5bm1mZDVv?=
 =?utf-8?B?ZUJvNnJmTTRkUzFYWFNSRzQxSGNXTmkxVkU1WitNUTZHYW53azhlT0F1SDhJ?=
 =?utf-8?B?cjR6Umh0Sy9vU2tuN1ZKM0VmelRXOFRyWURjZURialFxRjFkeHBxbjhENURD?=
 =?utf-8?B?SEdCZUhXdWlWYkhQSWp3dmptMUhIKzA2RXpmQXRvUTVjTHlHbjdTTUVGQ21k?=
 =?utf-8?B?MHNsb3ZiUngwM0tQWW9GYjl5T2NxcmpGUzd6SnhudDZMMGdkVmxBTnBqTndw?=
 =?utf-8?B?L0kyNnp1bjFXTWFUOVdQSVhjZmNCMC95YWl0eU1iSGlFU3BLVXFGTkc4RW8v?=
 =?utf-8?B?bVNZRjFQTGR4RFkxU1IyQlYwYWswamtDZWZkNndLSmpFUEZzd2UxcUpzTkpz?=
 =?utf-8?B?UXFKRm44cWplSnQydGxTQy9aUG1tTHJCOUlzMkxoWk4xZGR2YVhzanlteVdj?=
 =?utf-8?B?bFc3bUFXUFp6VHRmNU4zR0pnSk1vM3VlbWU0N3owS21vcVBmR1NIcldxVmx1?=
 =?utf-8?B?UHAyYkw4cytXS2hHWExyK0h1N0NRZklXbCtpRlFYd09CLzRmczl3NXZmc1d3?=
 =?utf-8?B?MWtVSVBhd0pvRUhyR0o0VWt6b2pXYU1aMlo4dVJNbU5HaXdtZDgvb0NRVmlw?=
 =?utf-8?B?YUh0dDF5VHFubFVXNnR3RFFlRm1tdnhkb090ZHNtRTg3WkJaMytydjhncWln?=
 =?utf-8?B?aXlHYk9jME5YU2tBRVJJQ3VVTUJGSHZ1QmZyNUdRWjZRTGhLMEYxZG81emFS?=
 =?utf-8?B?enZ5bDhmL1BMMFpUYWs2VForZ1pGZGhOdVA0OGNrRWVLZytFUVIyVXRRVkZG?=
 =?utf-8?B?dzdVRjVKV29KaTVkL2pWbU5Dc1F4dWs2U3ZONUVoMmIrZXpBbjZxL0g3NkJw?=
 =?utf-8?B?VkIvSXZEZEttZEZXbXRSbWhXQ0J5eDZWMFFlbFV5S1k2NzhXSXowS3JGRjlT?=
 =?utf-8?B?Rll3MjVGWWxiNlMxVnRydDhDbFgwTUdQbVFORjdGemdhSW9JR1czVXVNUDIr?=
 =?utf-8?B?QWRrWi9EY0dvMm11SVhva2Njc2NzV0NDWWprRmhtdzQ1enk5S3RwT1RjaDYx?=
 =?utf-8?B?Q1ZPN1ZSRkxBTVVkM0VXNVVSb1BTTVJVVEJjM1RCU1NhVTNFVHU3RCtBbjhO?=
 =?utf-8?B?azA3M1ZGRG9XMWFKcHBQOHdlcit1MUJxUEZOWXBxcE5FUHdjc3pxVlg0MEVl?=
 =?utf-8?B?K0p6bG4yZHp3OUlpaDdKU3I0S3JiUmJ4V0dxOTVIV2owcTY5Q24vekpHZVBB?=
 =?utf-8?B?TVBrWlNlQXFPOC9RcmpCMkFkazhBSHkyQUpidUlCMGd3dmZmU1VIRDFVL1RR?=
 =?utf-8?B?LzdEeWJjcHZwVUI0OXpIV1hTbW0zWXY5dmxCbEtGSmJvZVB2WUYyaG9MZjdO?=
 =?utf-8?B?QzM0M3JUNDFaYnFXT2pzdDBZUUwvdzRJNm1hR2dnZmNHb1d2VVl0cTBXYTZ5?=
 =?utf-8?B?VGcwSGJiMC9IaWx1bU9zV3RnSkNWcytING5PbFlLZ2N5L1Z0ZlhMeDlhcGhx?=
 =?utf-8?B?Y3RaWThka2JIbHdMVDA5QlJ4ZGNFdzhYRVN0Tmpia2lKWUI2RXVIK2RIUVRz?=
 =?utf-8?B?ekhoQVV5SHJwZHB0TW9xanFvNmczbWxPUS9KT3l3SUFHZ24xVWJ0WS9LMWtw?=
 =?utf-8?B?RitnQ3JYb1VMZzhJUkR3M25GK2hCUGdteHZRZ3JUb2NvK3U3SUc1KzgzRzR4?=
 =?utf-8?B?TjNXdFN0NUxob2lhMnovQTcwREpLdUdnaVQ0U1d4OERheFl2ZjZHamVBaEMy?=
 =?utf-8?B?L0xVcWRpaFVtV3F5dWliMnZKdEg5NkQ0VkZxeWlnWEF2K3gwN2lhdVJJQ1FU?=
 =?utf-8?B?UnFSeE1PSVNYVjhERHJ6S2VWeFE5SUhQa1daNXdFOFFmdWdRVnhIb0VjUmlB?=
 =?utf-8?B?YWxYeG5FWndlaDIra2J1RTkwbW10S3kvdlJQMmpGTTZHWmExS0IzUnZCNnFE?=
 =?utf-8?B?VDhzUk1xYTF0MUNXZUhSaXBUQUNub3I3dVg2eUhON2dxcDk4alp3RTZFSmlW?=
 =?utf-8?B?bGhrSm9USG1Ddi9jK0VXVDQyeWhhUUNoUkw5QnJEWWxTYmhQQTZRWWI4bXdk?=
 =?utf-8?B?WVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d021c9c-511c-486f-0bb2-08db83fe63ee
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 00:08:02.6264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7PXd5f52LypSUz0kCEMZPhkVBgaMvLYrY1jvuJfgLiLs+9gA/LtsFwpJc0zaYhG7ut2NbAfbIbapplXiDxjLq89mnWeJHaObsb8rYsl7iCg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5890
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> cat_val() is only used during CAT test but it checks for test type.
> 
> Remove test type checks and the unused else branch from cat_val().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette