Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1949422rwp; Thu, 13 Jul 2023 20:47:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlG4XwUYc9tUobQLH9WgPQJBAw69uQkHZKIUmmkL2Ek8b3JLvLdc80nwJZySSOdCtjVapaVL X-Received: by 2002:a05:6402:35c6:b0:51e:34d8:f4c7 with SMTP id z6-20020a05640235c600b0051e34d8f4c7mr3845064edc.2.1689306465620; Thu, 13 Jul 2023 20:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689306465; cv=none; d=google.com; s=arc-20160816; b=m5f6i3IrGqw26xSVf1XGdxAWk3l9pYv41BgBGJEA+OutJEVq5Wsozld1yTekvLbNCM 1uUB4dzqm/0Wjjagw5bMKQ9B9teOaP64abb554gkB2yhJ8UtBvEYMhFBEQtat4rN780H yLRPAxNfn7UQvurIW+MKTF5NZ7ApIWIg6VBGrNtZUSylYCO6rpv1F5DKyKpFYQHAHBkv RtcFwhzaHAanDGNczcIOyDhPscAB7D8gwHZ5z/oVJdr/bG4eyopazvRbWXp7Oq9ZRO8X vz3LiXjc1TQGKLVzEwUruF7tdb+A3E3Lpjz3aCRXVflWEMxAxylLj1Hy0cNx3+fit99Y Najw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=M9SRx77oVyH27nmDrCxFzdLCthBQXI+Bnh3FpA6XtS0=; fh=JqQbg62388b7ODaKJsE6mD0b0HrZm4RiTMui+vEzFzc=; b=thupBxfs49VhOVg+k7g1xjkhtetY8GKg4TOLPcZzQw0t+knOSsISd7eFAHFeLFhnYP B4oXGc7czDdaMzPku8N+IJ+LToj53tzMK4GE2xqmBZdft1Ft7yjiH/0fBigNEHPZTgOx 0D27m9GjYZYYrl5+0SbXjVeiwWfDUwOc2GMgWZ84fXtzbdTx2ugTh0tpGYnzwA6Per+t IGgseZEtTlOD7p4KVUFfZeCKzjUId3HPrEs/M3YjKewM6IvxpkDQozzBdnCXFqdRAMR8 tPLMlNSizK3fdaD6OsCpkoiGmQjtgnDqX45h0SWq1uMBcLPOOcbyHoV3ZcsX8GZxJvvk sb1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a056402345100b0051e22d8179fsi8262810edc.587.2023.07.13.20.47.20; Thu, 13 Jul 2023 20:47:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234789AbjGNDRJ (ORCPT + 99 others); Thu, 13 Jul 2023 23:17:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234804AbjGNDRD (ORCPT ); Thu, 13 Jul 2023 23:17:03 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C7D30DC for ; Thu, 13 Jul 2023 20:16:55 -0700 (PDT) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R2GmR3gZdzLnmD; Fri, 14 Jul 2023 11:14:31 +0800 (CST) Received: from [10.174.179.215] (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 14 Jul 2023 11:16:53 +0800 Subject: Re: [PATCH -next] x86: ia32.h: Remove unused code To: , , , , , CC: References: <20230625125411.25840-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: <83d2aeb0-9675-10db-f1ca-5ba4ecade4fd@huawei.com> Date: Fri, 14 Jul 2023 11:16:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20230625125411.25840-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping... On 2023/6/25 20:54, YueHaibing wrote: > Since commit 32974ad4907c ("[IA64] Remove COMPAT_IA32 support") > IA32_STACK_TOP and ia32_setup_arg_pages() is not used anymore. > And commit 675a0813609f ("x86: unify mmap_{32|64}.c") left behind > ia32_pick_mmap_layout() extern declaration. > > Signed-off-by: YueHaibing > --- > arch/x86/include/asm/ia32.h | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h > index fada857f0a1e..68f7eefe63d3 100644 > --- a/arch/x86/include/asm/ia32.h > +++ b/arch/x86/include/asm/ia32.h > @@ -57,17 +57,6 @@ struct stat64 { > unsigned long long st_ino; > } __attribute__((packed)); > > -#define IA32_STACK_TOP IA32_PAGE_OFFSET > - > -#ifdef __KERNEL__ > -struct linux_binprm; > -extern int ia32_setup_arg_pages(struct linux_binprm *bprm, > - unsigned long stack_top, int exec_stack); > -struct mm_struct; > -extern void ia32_pick_mmap_layout(struct mm_struct *mm); > - > -#endif > - > #endif /* CONFIG_IA32_EMULATION */ > > #endif /* _ASM_X86_IA32_H */ >