Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1971137rwp; Thu, 13 Jul 2023 21:19:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlEUi1EfeiJukloent33m1oaC/Vw7L4AJ9Zw6uKkgERQeF8wlo2HGOISEpjZu652gNJOIkBC X-Received: by 2002:a17:906:5195:b0:973:daa0:2f6 with SMTP id y21-20020a170906519500b00973daa002f6mr3000420ejk.3.1689308343648; Thu, 13 Jul 2023 21:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689308343; cv=none; d=google.com; s=arc-20160816; b=WrQcFlxXo5F7qlYc3qqbP2KPth7LEMNuBtrTO75dIqk7uLtBi+0Y/L7EXdYl+LRfzj p76FRObLlNPyTOuLI072xwivdYVvlZQerws5jD6JkjsQuGbRE1HsUxCTwU6A1yTO2Dpu Y6ZEoRjFjiuAQ85OFx/tNc+DWvpi2oxXSUKGT76YbawlJJhlpAMPh9XzmHI0q/Fq+F7k amNyIOBhTsRg5Lg81HBPME49EH6qcC5yAxwQZNMB7tnzb2e+5uifBAnIdN4mE7uujFHy ST3/ggIp1WPaox+qQ/NCP2+RZbh4oisnTw5ilgQxAIyeLA5XK8NsmOx41VGfdQAOLkxZ ktfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8XRnrTSn0EVkBZPKYaRsj210IKG2X1n9jkPjuMwrCcs=; fh=OIhnb+ga0BmOM1+wG4JFA0/PIlnE80P0vWIHj/pbin8=; b=hbgAZvQMM7FqWrDlcW5rKQkCMn4sK28TPx0w8sW6lMtFvQ/9vk8E4ZTCzextBECaCD WLcCTs+08rDbJeXUVGADzFToc8PkqUVAIFk/hAlBg/RpmzGJ1DIM25D+sNUVQaPT3fiM AfooHcjhODLB1HsB2YofB3jkXqt8sm8Qw9TDNEVqfgxWsnsc54qup55sJ2lL0TOMlQwI XwlSFWFJGcKfyvGv6XWJM7HzNNLKmwMkLu4pqegKqp84AFsAh04oI7261q+NRj2ARq5m O37dAXN59xyMO++pWX3oOpzSas6SWxTxKK+69k3O7/T7aQxDTpzIHdD/irh7EnFfibk7 cYMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oe5GldKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a18-20020a17090680d200b0098f564f636esi8825019ejx.132.2023.07.13.21.18.40; Thu, 13 Jul 2023 21:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oe5GldKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234953AbjGNDxw (ORCPT + 99 others); Thu, 13 Jul 2023 23:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234952AbjGNDxn (ORCPT ); Thu, 13 Jul 2023 23:53:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A14830D7; Thu, 13 Jul 2023 20:53:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3686B61BE6; Fri, 14 Jul 2023 03:53:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F456C433C8; Fri, 14 Jul 2023 03:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689306808; bh=+Fwviehmwgt9m79rlkMZy9sX+Vt3vd0g3UBMQgLjJSE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Oe5GldKdTBTA4XQjk58S0OXHh+EuHdGsss8/xGKrhDOPhwAHK1FI0eq0kJnvMlgXJ zWMyLRPMe7jckoV247ZCMBDzuM54nqWJZmwREKMYtgM8Ll4b2Q4ADi7FMuy7tGSq43 TbX4m++CTLhdyMV8oo96GBk00rJqIlohbJy3Yt56nd1V31Yiagil5P/Hs44FhvW3UD 9Ej+6w1zkIvRVU1K5UcGyqmBQZq/WNnuEijCEVzBcsxRVTMmsu+4MVnw7CF/vRwasH lAJHnrJ5DLXVqSwkd5V4xIVztAAKZero3ZhbDh3dkiD+vsYGoNPtLK6PIN4t1rz16e aLFT8rQM4LfsQ== Date: Thu, 13 Jul 2023 20:53:26 -0700 From: Jakub Kicinski To: Haiyang Zhang Cc: "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , "leon@kernel.org" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , Ajay Sharma , "hawk@kernel.org" , "tglx@linutronix.de" , "shradhagupta@linux.microsoft.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next] net: mana: Add page pool for RX buffers Message-ID: <20230713205326.5f960907@kernel.org> In-Reply-To: <1689259687-5231-1-git-send-email-haiyangz@microsoft.com> References: <1689259687-5231-1-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Jul 2023 14:48:45 +0000 Haiyang Zhang wrote: > Add page pool for RX buffers for faster buffer cycle and reduce CPU > usage. > > Get an extra ref count of a page after allocation, so after upper > layers put the page, it's still referenced by the pool. We can reuse > it as RX buffer without alloc a new page. Please use the real page_pool API from include/net/page_pool.h We've moved past every driver reinventing the wheel, sorry. -- pw-bot: cr