Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2003611rwp; Thu, 13 Jul 2023 22:05:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJE6imblyejwINsGWTqp2ivz9ppoQcUJtUqfzJ4OdHMS2iLeshLTcSSMwXfPd8lDf9y05S X-Received: by 2002:a05:6a20:7d83:b0:131:44f2:8691 with SMTP id v3-20020a056a207d8300b0013144f28691mr3557238pzj.37.1689311148548; Thu, 13 Jul 2023 22:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689311148; cv=none; d=google.com; s=arc-20160816; b=qVOmpQUkUhNk6zC3B9UAGE0z6oka4r5vKafbI5EoVR1JS3PAfNWgQ0BYIf9/k69/Tx we7ab+RSj/mYTBngS1DdsFQMC/hRp3cq5KzWyYOv2yyvhcMlVey6GLGijNeOqink2r4H sWQMawpyFioXeaTVkQKak1LNuh7oUOxc+g/6OSevq5XSH16v5PXU+5v/RVLWkKr+CDOc HOZ1Gr5WlI5Ag70i4qiMDHmKMCB7XJNOupxxC63sM8QnSD0gDwz+pQ8gu0Zmvpq/SKmy rYLt74/KUWAAr0HixVsQhuD70tSB6wEB3GHmpI3Q4MmzL1GCwqN308/uG10sEzl20U8F DqNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=BHKAVVMICZ6sY13ZefuAse6z6lab2W1eP1Ltc9nWgnw=; fh=AvdGZU/yeu7BA73DACY0hBRvd01AlwAkGGmL8rx/Z3M=; b=06azUjIebrXeu7piZcvRduxYbOkhZDl49mGT0hs6GymbiNuq+Bd95dvEBcwowe0cjH iBftjSgrTUVLU/nP1DnbTyJPHz5+0p7uuHisbaKQxL0ovwQOWaIviyjl310WI9cmQyza MBEYYJ+doPWOGwirnG/XdmWAPxnClRG0LlpQhbUEFKW8rLrITlISb4RBeLBe1Fw7DYTx n/2usstmD70KC7fJoLmA9dvzHYJqAWaE1EyVKlAjCeSo6YSqQwChl5xBsbhDJYpSOxof qcoMQU+YOEFd+QY8jizwwoFFN+gMnQ9OiVIBeogHXaOMSAB5ivKx8yzlpfLsTlObFD6u PPNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (bad version) header.i=@208.org header.s=dkim header.b=ZeEWpyRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h190-20020a636cc7000000b0055bc2561b72si6418231pgc.739.2023.07.13.22.05.36; Thu, 13 Jul 2023 22:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=neutral (bad version) header.i=@208.org header.s=dkim header.b=ZeEWpyRW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232770AbjGNE4h (ORCPT + 99 others); Fri, 14 Jul 2023 00:56:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbjGNE4f (ORCPT ); Fri, 14 Jul 2023 00:56:35 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259FE2D5F for ; Thu, 13 Jul 2023 21:56:33 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R2K255mDwzBJk54 for ; Fri, 14 Jul 2023 12:56:29 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689310589; x=1691902590; bh=kH8GnE+sm/V63Y/8cHTnasFldhq gzlUbCDGfR2vkAeM=; b=ZeEWpyRWgvhCJoyEQGJITA3WVMyvKmE64MnvzWjMhDZ 2h4d7zuK2vcpNN5Q08sqsg+suzY9YCIWPSonDwZDjYrCDC5ZOWuaae6DAOfjP0aj A22E2WJ59bAQXrYwdrFyucO5E83OEfdkwd2a4YKCWnnKUi3xAtl+S9GG1kqxWt5n Yygc137bnX9GyQgEM05T8KqPSB2PGDS1rE3BM84hXoCL+7TqehzSAyjEz/aoYruZ vq2UQ2Wa+HzvosRDO24ey+Z6IJFrzP4zGqwZVvfauhVj0BiwHueGcyu6HzM94QF5 XrdFm8WN2S9rcamYEQt739Okb4VOeZRbeXY3zRxD+nA== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yZ3x4ra0qtKh for ; Fri, 14 Jul 2023 12:56:29 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R2K253rp3zBHXhN; Fri, 14 Jul 2023 12:56:29 +0800 (CST) MIME-Version: 1.0 Date: Fri, 14 Jul 2023 12:56:29 +0800 From: liubin001@208suo.com To: davem@davemloft.net Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] floppy:ERROR: missing put_device; call of_find_device_by_node on line 589, but without a corresponding object release within this function. Add the put_device function before return to release memory In-Reply-To: References: User-Agent: Roundcube Webmail Message-ID: <0f4dc280605c4700556d88d6f59cd1c4@208suo.com> X-Sender: liubin001@208suo.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,SPF_HELO_FAIL,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: LiuBin --- arch/sparc/include/asm/floppy_64.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sparc/include/asm/floppy_64.h b/arch/sparc/include/asm/floppy_64.h index 070c8c1f5c8f..c4c51f494f25 100644 --- a/arch/sparc/include/asm/floppy_64.h +++ b/arch/sparc/include/asm/floppy_64.h @@ -588,6 +588,7 @@ static unsigned long __init sun_floppy_init(void) op = of_find_device_by_node(dp); if (!op) + put_device(op); return 0; state_prop = of_get_property(op->dev.of_node, "status", NULL);