Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9112669e-544f-f628-bdbb-e62c0dce700b@intel.com>
Date:   Fri, 14 Jul 2023 13:45:38 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [RFC PATCH v2 2/3] mm: handle large folio when large folio in
 VM_LOCKED VMA range
To:     Hugh Dickins <hughd@google.com>
CC:     Yu Zhao <yuzhao@google.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
        <willy@infradead.org>, <david@redhat.com>, <ryan.roberts@arm.com>,
        <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-3-fengwei.yin@intel.com>
 <CAOUHufZQ0EpyRZ_jAMxs8uNSQOz6uAkzVjvvgD+4wBvmgHJoCA@mail.gmail.com>
 <6cc5a915-a28c-983f-9b32-6040f033970b@intel.com>
 <6573e671-62e-b7b9-1aae-64336c32bf1@google.com>
 <c7d06f91-1552-9afa-a0ae-396bc9c703d5@intel.com>
 <7e21e99-8f8a-6f31-601c-a73ad6a0e87f@google.com>
Content-Language: en-US
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <7e21e99-8f8a-6f31-601c-a73ad6a0e87f@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk5lTEZFMXhPSzU3OVpxZW9TQ3VsY3BNYy9VK0pzTVZ6dkRhSjEwWFI0cTRw?=
 =?utf-8?B?UmZQYmxxQ1JFNlRlREJxM1hOTjVSV3g3RW1kT3piMWFVTmpCK1VxbnB1TTV4?=
 =?utf-8?B?bHd5WWpDcFpzdlZhNFM0K0cxd2F1U0lwaHlDblpJSCswaThHSVVIVDRpL3Uy?=
 =?utf-8?B?U2o2QlF4Z0lUbDJOa0pYQ1pWM2JiOE5KeklEZCtGWFM5TktQVEdjb1pvZkNK?=
 =?utf-8?B?SlE4ZWtqczM1MVBScndMc084cTA1MnZNQ2JqRTB1bkJNRllhTGhMeWdzNkIv?=
 =?utf-8?B?dlRzWUxKWE5Pbmx6YVdBdXZLZkdVNlloUHhOa1BsWXVnR0oxL0R3NFpWOUdi?=
 =?utf-8?B?TWNTSFpQTnpjbSs5UFNvbmcyNE84ditFS2U4RmRaU2w1YjVEdi81QS9vdy9r?=
 =?utf-8?B?TnRmSG5nRFRQdWVvNjAvTVArQXJrQktUZ3h0cHFqRVQxM0ZsTTZKUlJEcTNl?=
 =?utf-8?B?K1ZueGhFTk9OdWlNYVZWa0RkZEtZVmxibW0wYmNqcktheEZMdEJvYVFlUldn?=
 =?utf-8?B?NXJLVGt3aldtbm9PdlNTQlRoWlJnQWZXdFMvdGxnbzlCQ1RxcmIvSzFBVVdp?=
 =?utf-8?B?cDdtY3RDMnY4VVVHQVdmMC9iNWVLVG9LT055ZG5ZSW9vYVBNa1ByYmVGVlVh?=
 =?utf-8?B?a2xVMGs4M2FLdElVVlV4Qk9OcDZMQWMrU2szVHpjcHZKVURYbDFFQ1FiTWtQ?=
 =?utf-8?B?ZCtQWU41cnUvSTFFczJjbFkxQVdOVmNmdDFvcTdPRjNFTEQxUDFKeE5RSXpS?=
 =?utf-8?B?L1NHNlYzR1U5cDJ4eENQWjlrbzhCSnVCOStPQ1poQWNrWnRHWnpqZ3NlZG9S?=
 =?utf-8?B?UEdnVURpNE04dmZFY0lYN0NvUG9va08xSWd1VjlBOEpJYWF3Tk9MZ1JJamVF?=
 =?utf-8?B?YTlwQlFEblRmSEZScjhQN0NjM0UweW41cTlKRC9HTzYwdGpWRHNCSUNWS2Yw?=
 =?utf-8?B?ZTNIK3dBREptZWFBc3lJWk5hZ2hRK0JaOVpFR1paanhQay9NYVIrMUUxaG1H?=
 =?utf-8?B?ZmJXVWxZMHRMajNtV2JTMVJTeTI4clBuU0FBcjhKdWdpUWNCeUVUTk5ld2oy?=
 =?utf-8?B?TGZqdzBmMFcrOTZUeVN2c3dTbmR2QUdzSE16R2hzenJLcXc3TnBEeEp3a3VB?=
 =?utf-8?B?WS91U3U3d3ZmTXpTanJUaDArRUNKU3l2ci91R0IyMEpZUk9Nd0FKZEErYkpv?=
 =?utf-8?B?bm5KNm51YmJrVlQ3VVBiT2dTQzAza01EaDdVQkcvdjF4Uk51cGp0M0NyMUs2?=
 =?utf-8?B?dHFNZlhjRDMrRGlxYWtPS011TW9xVEUvNDlyemFLbi85QkhSSFFhaXZ6emQ3?=
 =?utf-8?B?S3l3dWN4eHlhQ2Evbi9oRUpBZkJQV2xpYUpqT1BoUlQ0ZlFNMHVkcE9nM213?=
 =?utf-8?B?KzNrblg2Tm16Qm9vZmtnME5NTk1TSHJvZXZxdnBkMmx3RWp1ZEF6dEh0dFZG?=
 =?utf-8?B?QzZwK1lzcVF6cTk1clh2VmN5elFZZnNTZU16Z2FPTko0MnhNRS9wZDZPMFpm?=
 =?utf-8?B?OGpZdytFZEZLeXFFQ3RvYzZWREhyVThwREVIQW1BZ1FYWFZ0S1NXQXB1YUda?=
 =?utf-8?B?M0pMME1jb3Y3ZkxhMHlyMnBKTlFGWGwyRng1elZLd0ZhWGkyUThsWWdiNm1B?=
 =?utf-8?B?MWJCNUJaRXVSYzNkTlBvMlF5aUFoc0ZqYXNvR1B3ZTN4YldIWmZQYURFNklZ?=
 =?utf-8?B?UVhJdGVQdmY3USthSjdYL3JDL3doVnVyd1BHY0RTN2V2ZFdFcC96cmdQdUFh?=
 =?utf-8?B?UXNDTnM4dWNSMHBUNDRuaFpUd1cxQTRabXF3emkvTytBWFM4VTlobjRWOEpB?=
 =?utf-8?B?QlhyV3p0SzJnVGFDbC9NZUpwSmM2bFppSktrSnkrY3Z5bXhnR0lCZnVrVTZr?=
 =?utf-8?B?UXBJZnAzOWdWWi90a1dBOU83U2ZHb1hqS0pNdzRKc1h4SXE3MXFRT2E2d3c2?=
 =?utf-8?B?SWVLMlBONkxHMWhKNzAvR09Jb3REakQ3SXBub29YejVsaWE2RXc2L00vNUtQ?=
 =?utf-8?B?aE5wTVhnSE5aVmQ2TnhlbWZtMmJOamVTTDBLMjU0OFZMcmR3NENvYTJHcm1v?=
 =?utf-8?B?a0RyWGJkdEFhaEhxUmt6aXJGSkN3WXYyQTVMSkdvYWVkcGJLbC9mL0ZwOGRv?=
 =?utf-8?Q?GAzE3Lgp0l+KD6GXA92Lwcktw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8ba5713-fd8c-4c6a-32de-08db842d9368
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 05:45:48.7246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p1Yv0Z5TnIU9RwDrZdhBWJmbN6hT9UA0YHlaDsSxT+axHmYdVWQ3PHrLiKW3x+kmcuTywbXrKa1GiF43UG/0GA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8163
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/14/2023 11:41 AM, Hugh Dickins wrote:
> On Fri, 14 Jul 2023, Yin, Fengwei wrote:
>> On 7/14/2023 10:21 AM, Hugh Dickins wrote:
>>> On Wed, 12 Jul 2023, Yin Fengwei wrote:
>>>> On 7/12/23 14:23, Yu Zhao wrote:
>>>>> On Wed, Jul 12, 2023 at 12:02 AM Yin Fengwei <fengwei.yin@intel.com> wrote:
>>>>>> --- a/
>>>>>> +++ b/mm/internal.h
>>>>>> @@ -643,7 +643,8 @@ static inline void mlock_vma_folio(struct folio *folio,
>>>>>>          *    still be set while VM_SPECIAL bits are added: so ignore it then.
>>>>>>          */
>>>>>>         if (unlikely((vma->vm_flags & (VM_LOCKED|VM_SPECIAL)) == VM_LOCKED) &&
>>>>>> -           (compound || !folio_test_large(folio)))
>>>>>> +           (compound || !folio_test_large(folio) ||
>>>>>> +           folio_in_range(folio, vma, vma->vm_start, vma->vm_end)))
>>>>>>                 mlock_folio(folio);
>>>>>>  }
>>>>>
>>>>> This can be simplified:
>>>>> 1. remove the compound parameter
>>>> Yes. There is not difference here for pmd mapping of THPs and pte mappings of THPs
>>>> if the only condition need check is whether the folio is within VMA range or not.
>>>>
>>>> But let me add Huge for confirmation.
>>>
>>> I'm not sure what it is that you need me to confirm: if the folio fits
>>> within the vma, then the folio fits within the vma, pmd-mapped or not.
>> Sorry. My bad. I should speak it out for what I want your confirmation:
>>   Whether we can remove the compound and use whether folio is within
>>   VMA instead.
>>
>> I suppose you answer is Yes.
> 
> Yes (if it all works out going that way).
> 
>>
>>>
>>> (And I agree with Yu that it's better to drop the folio_test_large()
>>> check too.)
>> My argument was folio_test_large() can filter the normal 4K page out so
>> it doesn't need to call folio_in_range() which looks to me a little bit
>> heavy for normal 4K page. And the deal was move folio_test_large()
>> to folio_in_range() like function so simplify the code in caller side.
> 
> I realized that, but agree with Yu.
OK. I will rethink this as both Yu and you suggested same thing.

> 
> It looked a little over-engineered to me, but I didn't spend long enough
> looking to understand why there's folio_within_vma() distinct from
> folio_in_range(), when everyone(?) calls folio_in_range() with the same
> arguments vma->vm_start, vma->vm_end.
madvise could call folio_in_range() with start/end from user space instead
of using VMA range.


Regards
Yin, Fengwei

> 
>>
>>>
>>> This idea, of counting the folio as mlocked according to whether the
>>> whole folio fits within the vma, does seem a good idea to me: worth
>>> pursuing.  But whether the implementation adds up and works out, I
>>> have not checked.  It was always difficult to arrive at a satisfactory
>>> compromise in mlocking compound pages: I hope this way does work out.
>> This is the purpose of this patch. :). Thanks.
>>
>>
>> Regards
>> Yin, Fengwei
>>
>>>
>>> Hugh