Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2089167rwp; Fri, 14 Jul 2023 00:01:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlELz4YvC+oWjycQVxW3FJAdqB6yIxhMGNYSTS4WmtFBtQwAY+SVK63MsQaxVyv/8q0lFsv/ X-Received: by 2002:a2e:3509:0:b0:2b6:c818:a9bc with SMTP id z9-20020a2e3509000000b002b6c818a9bcmr3358040ljz.23.1689318105522; Fri, 14 Jul 2023 00:01:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689318105; cv=none; d=google.com; s=arc-20160816; b=XjSifLKu7uzUHHuC7V/tgAcSkkLG95hQi0tACV80iQwMT0tgwaX0rzTPXyBH3FXAMR Ja5D8EW2M3Yk7GIQIepWa9sd/W03AmJIy6CEKXyDYCaIcc6jo38rm2tXc5k1SJ1nMjN9 KILgV/jfh1/85aAYuZN+P2qYTmu9R36wU11JVyQxflmwjMVvTJBT1YriFFNERIESR5pl alkvca0KDTQxOoNYxF6qIKlhZr8wTk7g+uvsxgJQNBPat8I0OPlrhsMgyg0cI47rHLe6 uP8p9CZpqXWUS12EcE4jAmKvWUKq9nDbSulTTbZ7efOyRrpBTw3DpBczYoWXyhsIZipj rqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=piPKsxY5Rl0p5bZSsZwd82W/y+JBPIg9n7o0YUowYaY=; fh=ud9y33DRf/M3o3Jq4iPIUPytVd2ukY3qvsYRvSgj+tk=; b=QPmSgwFEkjh1pr7LXyH24lxGWlyLg60Fk1bU7tYBGaEcCvrxnYldR98uaCq2+lXMqC JgZ+gsdJRAJqssCh8CsZWgTHQ8TEK3dKiPSnwaYnWK8uEhm4W+MSz6mXuGbDXE6Iz5R5 8GmASmKzE9zcRfAq/OxHEor42MVsAgeNvDwNSXwrHhMq7jkEC4gNGQEzN4V2MsJ9xQr4 MjcdtWKNhWRAuNenMp/A9esySWio/gSQvCayBbV6H2bV5L4DttHttZlnaPkUKykhw3Bg oabwoiSKzlFebFMr8iO170YzZGrIysm5QDZIuBSsXun3Sg6DE0srn2QRpoAvlWusz6Qb jDZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="auOnV/iX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a17090654c700b00992acfe04b8si9241344ejp.150.2023.07.14.00.01.21; Fri, 14 Jul 2023 00:01:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="auOnV/iX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234524AbjGNGgc (ORCPT + 99 others); Fri, 14 Jul 2023 02:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233557AbjGNGgH (ORCPT ); Fri, 14 Jul 2023 02:36:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 396F930D7; Thu, 13 Jul 2023 23:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=piPKsxY5Rl0p5bZSsZwd82W/y+JBPIg9n7o0YUowYaY=; b=auOnV/iXNYupYvOxlubXO36ewX 4demD8frDEdp6+cocLBPxR5hgwn1JqKH1SC7G5zuUjh0hym86uT/oBCAUgbZqUhq1CNm+uFM3yast iAKNvedThnZYvCrOUvcfBeuZXIH1+yY08zp4nq0PU/IQKLSqbsXoGkArIEP4NgGN8czzfBFoiZboi KTxSjUMLb9AnKNvQ0cuKAGIJLjParaXI91Q9XFg7pE6hzishK56k6Kkt4jZOb7tzXz00MktYX0QxE jqiG+pd9zvds0jdEWfPWXIne4E6riV2CDAeYoZrK3Hqd7G3oU4j46qtzp42TvuflxuS3W9N+Ua2fu wYGQRICA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qKCOy-005BeC-2N; Fri, 14 Jul 2023 06:35:40 +0000 Date: Thu, 13 Jul 2023 23:35:40 -0700 From: Christoph Hellwig To: liubin001@208suo.com Cc: djwong@kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfs:Comparisons should place the constant on the right side of the test The if statement uses an assignment statement as a condition, which is confusing. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 02:26:08PM +0800, liubin001@208suo.com wrote: > xfs:The if statement uses an assignment statement as a condition, which is > confusing. > Signed-off-by: Liu Bin What's the point? I prefer the style you change it to as well, but there is no real downside, and changing code just for the sake of it causes nothing but churn.