Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 08:47:41 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     liubin001@208suo.com
Cc:     davem@davemloft.net, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy:ERROR: missing put_device; call
 of_find_device_by_node on line 589, but without a corresponding object
 release within this function. Add the put_device function before return to
 release memory
Message-ID: <20230714064741.GA53474@ravnborg.org>
References: <tencent_0C9506095848D9427102ED415071D0F3420A@qq.com>
 <0f4dc280605c4700556d88d6f59cd1c4@208suo.com>
 <20230714060655.GA50441@ravnborg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230714060655.GA50441@ravnborg.org>
Precedence: bulk

Hi LiuBin.

On Fri, Jul 14, 2023 at 08:06:55AM +0200, Sam Ravnborg wrote:
> Hi LiuBin
> 
> On Fri, Jul 14, 2023 at 12:56:29PM +0800, liubin001@208suo.com wrote:
> > Signed-off-by: LiuBin <liubin001@208suo.com>
> > ---
> >  arch/sparc/include/asm/floppy_64.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/sparc/include/asm/floppy_64.h
> > b/arch/sparc/include/asm/floppy_64.h
> > index 070c8c1f5c8f..c4c51f494f25 100644
> > --- a/arch/sparc/include/asm/floppy_64.h
> > +++ b/arch/sparc/include/asm/floppy_64.h
> > @@ -588,6 +588,7 @@ static unsigned long __init sun_floppy_init(void)
> > 
> >          op = of_find_device_by_node(dp);
> >          if (!op)
> > +            put_device(op);
> >              return 0;
> 
> This does not look right as the code will always return 0 now,
> independent on the if test. You missed a set of curly braces.

Two more notes.
Please put the description of the fix in the body of the mail.
Right now it is a very long subject - and we try to keep subject shorter
than ~70 chars.

> > Signed-off-by: LiuBin <liubin001@208suo.com>
You are expected to sign-off the patch with you name and not a nickname.
If LiuBin is indeed you name then sorry and ignore this comment.

I look forward to the updated patch.

	Sam