Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fda9ce15-2b88-f964-af39-9f8384bf79d4@amd.com>
Date:   Fri, 14 Jul 2023 08:59:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 2/6] drm/amdgpu: Allocate coredump memory in a
 nonblocking way
Content-Language: en-US
To:     =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     kernel-dev@igalia.com, alexander.deucher@amd.com,
        pierre-eric.pelloux-prayer@amd.com,
        =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= <maraeo@gmail.com>,
        Samuel Pitoiset <samuel.pitoiset@gmail.com>,
        Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
        =?UTF-8?Q?Timur_Krist=c3=b3f?= <timur.kristof@gmail.com>,
        michel.daenzer@mailbox.org
References: <20230713213242.680944-1-andrealmeid@igalia.com>
 <20230713213242.680944-3-andrealmeid@igalia.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230713213242.680944-3-andrealmeid@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RllVL3Q4WHN5VUUvdDJQZXgxNjRFYkZOMDY0bDZOd3JUVkN4em5PbDlFQjlE?=
 =?utf-8?B?Nnp4dnFMWFBzQnNSQ0hMSGIyRzB1V3FCeWlJdlpBMm94WURRY2Z2bEdOWUls?=
 =?utf-8?B?V2JrQjRJWHBnZCtmTzhjR2MyeXU2TUJwRTRZS1pOK2lOaTZib2k0bGlZdUhq?=
 =?utf-8?B?QmI2b0lqMVBXSXJOVHlsREdmcFJTcHFrSC9kNG9mN0hCWWNvbjBidEI0UlF1?=
 =?utf-8?B?Qms3aWQ3bnNHclJyaElHUmQxcnQxUGNYWFh3Z2lIV25ReUxpRlR0MG0vRjZv?=
 =?utf-8?B?Nno1V3ZMQlM4S1lDbkVSRitYc2FVeWs5VG5VY1hrQlJkU1NrbUZvU0pvUU9u?=
 =?utf-8?B?WmhhQlJVSStnS29JUGkrSGNLS3NRWHFDcGt5NTBjYm53eEhtOE5mYzFjTWxl?=
 =?utf-8?B?T1UyVVI4UVlJRmlwd3FicjJiM0xqZDVUbWliUTlDK0ZwQ3lEYjZhS3NSdTdT?=
 =?utf-8?B?bHZJYytJM3Y3SVpmZXo2aVRQZFNlTnY0NkJYVVR2aDRCc1diZ2hRc25lSVBz?=
 =?utf-8?B?MEhsenY1VU5kWGgreDBvNE91ZDArSFM0REhGNVRGR3RqL2k4YjV0MGFRbDBu?=
 =?utf-8?B?THEybFBDbEVrcG9KQ1VtL2lBSTR5VERPSDRJVm1YcXpnblM2VkVDTDdRUFlX?=
 =?utf-8?B?dk9FTzFHY0FoUUx0QW9HTDcvRjE0SHRmKzFuQzFHLytHc3RtZlhHbURzNjdu?=
 =?utf-8?B?RUx3K0dnVE5oMkppSlA2UG5rZWpYU1lKZjhoR043ZStiN3J4enQ3RXYvWnNm?=
 =?utf-8?B?cnQyR1E1RWNoVitubXBVUy9QZG9uK2JUY25yRjBNaTN4Y2lJRXhlY24vZnhZ?=
 =?utf-8?B?NS95L0lCS3hmTUlvaDJOSm1lRFdBeUc2N2loTDg5TWpGdDdhRWc2NWRZamxS?=
 =?utf-8?B?V0tnL2NYV2ZFRE00amNKd2swMVN4cE01R1lOaWIzL3VvRk1TMkNPYVBKSCtk?=
 =?utf-8?B?YWRJSHFrYzlHMGx2RnFlZUtFNVUrU2lKRlZPU2N0djZEclZCdFBFZTFwWkNj?=
 =?utf-8?B?NW1oWDNPdTAwTDlEYlFsRlFaeHZSR1RXZDhwaG50Nms4Z0orcVNYdm04UFdN?=
 =?utf-8?B?NWNtVURsUE40WGRqVG1YdWM5dmU1NzRrTGgvbFhSUHFnZUI0Y0pRR1l2amNI?=
 =?utf-8?B?cHJQenRVWXFrc2loKy9IQ0QrSFMwMUw1bG1EcXNnMzBSMXY5SlhFS2pRZS81?=
 =?utf-8?B?SXE3Y2RrSW5MTlJsNDNtNkZJWW4wU2p2QWsyS0dzR2ZWNm9qbjVWS0RBVWhX?=
 =?utf-8?B?YUNFUytaM2laNkxPM2hja3dSVVplTklUcDJ5OTdDdjZYZTg3V0RmbUlGQ1Zm?=
 =?utf-8?B?d1kxZTREZDdHYmxmOVlKalFPTTVTaHh4Z2RzSUNsazlLYml2OWNZTG84clhs?=
 =?utf-8?B?cDVnVW1BTWczUEw0YWNvSSszSEtmeG9HTW1jMUkxS1hjdHJSMEJpRFAvOW5h?=
 =?utf-8?B?b1BSSEw4eDArdDFyV3dsajNxSEpKQ2V2K2RYVHhtM3g0eHdOTkNLQy8wTmt0?=
 =?utf-8?B?YzcrMVRxb21ucWNqd3ZIb2lGWElnR3B0MTlBK2k0WmlOWDRTZDA0UmVoNk9G?=
 =?utf-8?B?VGtvMnUyeHg2T3JIUnU0WU1OOGhlQ2g5OUN6YUVLekdsK1BDZVNCZ1JkU0lk?=
 =?utf-8?B?MERBRVpnNHlqeWZWbHg2bkhBN1NQNlNFdEtTeTNlM3k1QWNLZVBZVXNUVWNO?=
 =?utf-8?B?UEgvdHVwbUJIZko5YmxOY3NHa1JwMlY5NC9RVkJIOEhtWHR6N0hYS1JjMG95?=
 =?utf-8?B?NElVdThkbXhkL20rUitiQ0ZBbndSMS9nNGFGUGs1eUpOZ2RQSlVQVVhZUUJV?=
 =?utf-8?B?VlJOd3BSZVFwQWVRR3hMWUE3UFBDWEl5eUNXbStaRXVORldzQkN0cmg4Szdq?=
 =?utf-8?B?M2IxblFMYTdZTDJTdVNYM0RlbzRkYkN3Z0FYeVprZGpKN2FMUHJaNmN4bGxI?=
 =?utf-8?B?cDFYZnNOWUVLVmZQT3hLVVZES0wwV2hPakZOTWdYelN4azJjejUwa0RCVytM?=
 =?utf-8?B?Z1orcXFDY0RKOGVuMXF1MUI1UjJ1TldxdCtsZVN6M2NsQTdCRmI5T2RaQWVJ?=
 =?utf-8?B?SGlrM2hnRDdyR3B4V1RvNk51ZjlxbDZnakFQWmo2NEt0Qm05ZVlXRVV0ZWMw?=
 =?utf-8?B?VWRRSlkwWGRMdHRJU2VISXVVbTFuNENNaENhS0ZXWDFzNExKa2g2a3RjdURV?=
 =?utf-8?Q?0TSwQFbhb2VCmAhyCtQGl58snLkk+Mvk9Cxf04U2wx2r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cad8da0-0608-43e1-1513-08db8437e10d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 06:59:33.9466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xTHLRuXErOiiAew72wKqCwFV4Wtv3iYR/MRkZiqdBzRoBs1j78VtlRA8izVOUL4Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8509
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.07.23 um 23:32 schrieb André Almeida:
> During a GPU reset, a normal memory reclaim could block to reclaim
> memory. Giving that coredump is a best effort mechanism, it shouldn't
> disturb the reset path. Change its memory allocation flag to a
> nonblocking one.
>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
> v2: New patch
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index e25f085ee886..a824f844a984 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5011,7 +5011,7 @@ static void amdgpu_reset_capture_coredumpm(struct amdgpu_device *adev)
>   	struct drm_device *dev = adev_to_drm(adev);
>   
>   	ktime_get_ts64(&adev->reset_time);
> -	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
> +	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_NOWAIT,
>   		      amdgpu_devcoredump_read, amdgpu_devcoredump_free);
>   }
>   #endif