Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758240AbXJYCdY (ORCPT ); Wed, 24 Oct 2007 22:33:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753969AbXJYCdR (ORCPT ); Wed, 24 Oct 2007 22:33:17 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:49775 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbXJYCdR (ORCPT ); Wed, 24 Oct 2007 22:33:17 -0400 Date: Wed, 24 Oct 2007 19:29:49 -0700 From: Arjan van de Ven To: Hugh Dickins Cc: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t Message-ID: <20071024192949.346687ed@laptopd505.fenrus.org> In-Reply-To: References: Organization: Intel X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.1; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 19 > Signed-off-by: Hugh Dickins > --- > Whether this is a complete patch, suitable for all architectures, > I'm not sure: it builds, boots and runs correctly on the x86_32 box > in question, but you'll be a lot wiser than me about using dma_addr_t > for everyone. (Seems a bit of a shame to include here, > when I think all arches already get to include it one way or another, > typically via asm/scatterlist.h; but I guess it's safest to repeat > it.) there is a problem with this... sg_phys doesn't return an actual *dma* address.... at least not an address you can give to the device. Using dma_addr_t is thus a bit misleading..... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/