Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 15:11:06 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <chao.gao@intel.com>, <kai.huang@intel.com>,
        <robert.hoo.linux@gmail.com>
Subject: Re: [PATCH v3 00/11] KVM: x86/mmu: refine memtype related mmu zap
Message-ID: <ZLD1Cv9bNE9rmanj@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230616023101.7019-1-yan.y.zhao@intel.com>
 <ZJy77R5dQE3uFymG@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZJy77R5dQE3uFymG@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FexJsGyWnDw545Xi6dyOe+SaiJT87A/TQqH6rN1NjoNaqPb2ibmNxEcX40SF?=
 =?us-ascii?Q?I9I2srR8wJlAlmluJd9Z6gJ+etl6swLeNy58aOBCUd2jyUhs1nzCQ9Behfjv?=
 =?us-ascii?Q?+rYJipcYXeDohmHAmRNg/UDbG4tJH1Ipf1roTe6pC462YFzCTZhO7SXz0HVm?=
 =?us-ascii?Q?V1fVMC8yNwFJC4Yih8crwNcmPJb3SSF3mcauQVPRszU87fAohzxTb1//XoL4?=
 =?us-ascii?Q?uO94+tigDZbTIFbvF3mCIb+tR64t9diZg0KJiM9SALjaGLfCRNURVCs8+cCb?=
 =?us-ascii?Q?HyJPoQ0vzv+81s3hE4YX7+PVF0H32plXLDoazdghz6NOaHEXCHikkljCJu/g?=
 =?us-ascii?Q?QlIIfvFsuEvxKvveOVoND29OF9ZynEOb8E7pLhGTBvmS6K+S7pCg6a06cjWV?=
 =?us-ascii?Q?q1NS4YqrxOzc9pMw3MBt6tjKkLmcFqCiztVwCWH2gMfPTc9Bph6JaD52ezFD?=
 =?us-ascii?Q?z83LTmbTe2mBvfHQ56EwTHIjz3obhQJrOlD1z+lB01XIf4tQ0aG7/xCsB27T?=
 =?us-ascii?Q?aoaipyjHvNhgGcayIvlotZDRT34FDtJuSh/veJwGtzI6CN690QjoeYR4zIWl?=
 =?us-ascii?Q?syzsxs/T1kkN/f6ZC1yze2BCZCSC9k7A8pEdojRehKyYVIJcNIvS4ShyYG36?=
 =?us-ascii?Q?gJbBy/DvvwbHgwsWbajHpBoTGAa0M2Z3gcUuYcHEJlv4Z7WVXl2u+wyQfArV?=
 =?us-ascii?Q?4sqkVZdDf+aTx8CsmtXmuVG/elOHoNDaFyxp1j17brCpRDcIIUmsUOmVqbCj?=
 =?us-ascii?Q?2hgQOe332WZ7UEH9ZgxXgdHOTYamEGIqv2L50Bl3ZUrFOKhuZp6yBqv4Stnc?=
 =?us-ascii?Q?v/8uoHFyBFTBBvqqvbJ6WIqJcK23DENPl2clXqvW9jmnNzzyKAW8K4ZvNEbk?=
 =?us-ascii?Q?mWnR8cNYwhQbJZfRMYaHlPoK9Kkhrz2Z2qJZoEI5xeret9fBmBxmrO+EtbHS?=
 =?us-ascii?Q?b/A67uqhqrIzwEZLBmJiTVYXvy3B2rrT0wX2hM+FwuQZ8BgS+Bjhr0sJdQca?=
 =?us-ascii?Q?GxtWoqKkuub8PHPByDqQrQyd88w3CVfX6vHkiVGIQCkSk7QK3Xo5tGQkz4cl?=
 =?us-ascii?Q?uyEjBkr+2mePj564ROqJiPeu+zXi/NF0jupXos0f+dPd0TkLDYAGDiFympSg?=
 =?us-ascii?Q?t7UMMNsQ4WPwXdTxX35sUC0N+YiWxeJOH75XRst8WudQ1XzDyxsLslwgdtFw?=
 =?us-ascii?Q?dG22d/kRnohrjeoUG1UlQbWkWgd4Q8a3sKJqaK+q2G3H3XW0ftFaGD0+ti8K?=
 =?us-ascii?Q?+We231b7WcAjK3RiBXfFb/jf9H+k1JKTE8SSpzjxhm4/NkFg1YqMMnr16SfE?=
 =?us-ascii?Q?foYEX3R9lNLHdgQpbdro0eOk/YHNcMU9j66SdsKs9p44e5eneuBhAbOHPP1H?=
 =?us-ascii?Q?w4O+cBdDPEVjs9JMdiewh2MX5FmcVcrwE1wyUHK7S0/5LdWBr0BC8N95kRiG?=
 =?us-ascii?Q?/ICD68ZuvXWoo7MmYdEAgpOk1dP6IqkTqtrgbmkE281Xg222mLNK/tyR1hRV?=
 =?us-ascii?Q?WpeZ3CNs0O2ZwFcgoMO2Pq5W5+lAD/tY6XQAMa5SthZxuJlChooDOInk5qQE?=
 =?us-ascii?Q?UYchPEq9Gp7mpxh4YGZnzmleg7JtutxFT+DctD5y?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fba293f3-b529-467d-530c-08db843d380f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 07:37:47.3013
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SH2KiMry3I/26lHhr9TyxtT08j7AnnUVGtQ6kqad5T2cRjpBT7vwWSBIUuN9yewxve0v2kwaH9SVqaiOeZsC8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6365
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 28, 2023 at 04:02:05PM -0700, Sean Christopherson wrote:
> On Fri, Jun 16, 2023, Yan Zhao wrote:
> > This series refines mmu zap caused by EPT memory type update when guest
> > MTRRs are honored.
> 
> ...
> 
> > Yan Zhao (11):
> >   KVM: x86/mmu: helpers to return if KVM honors guest MTRRs
> >   KVM: x86/mmu: Use KVM honors guest MTRRs helper in
> >     kvm_tdp_page_fault()
> >   KVM: x86/mmu: Use KVM honors guest MTRRs helper when CR0.CD toggles
> >   KVM: x86/mmu: Use KVM honors guest MTRRs helper when update mtrr
> >   KVM: x86/mmu: zap KVM TDP when noncoherent DMA assignment starts/stops
> >   KVM: x86/mmu: move TDP zaps from guest MTRRs update to CR0.CD toggling
> >   KVM: VMX: drop IPAT in memtype when CD=1 for
> >     KVM_X86_QUIRK_CD_NW_CLEARED
> >   KVM: x86: move vmx code to get EPT memtype when CR0.CD=1 to x86 common
> >     code
> >   KVM: x86/mmu: serialize vCPUs to zap gfn when guest MTRRs are honored
> >   KVM: x86/mmu: fine-grained gfn zap when guest MTRRs are honored
> >   KVM: x86/mmu: split a single gfn zap range when guest MTRRs are
> >     honored
> 
> I got through the easy patches, I'll circle back for the last few patches in a
> few weeks (probably 3+ weeks at this point).
Thanks for this heads-up.
I addressed almost all the comments for v3 currently, except about
where to get memtype for CR0.CD=1, and feel free to decline my new
proposal in v4 as explained in another mail :)
v4 is available here
https://lore.kernel.org/all/20230714064656.20147-1-yan.y.zhao@intel.com/
Please review the new version directly.

Thanks!