Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 08:57:12 +0100
Message-ID: <86r0pbudrb.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     chenqingyun001@208suo.com
Cc:     oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org,
        kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org,
        james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com
Subject: Re: [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h>
In-Reply-To: <3d56cf129c2cf1cf53f19ebe3c23a803@208suo.com>
References: <tencent_2099141F01FC6C32AAA20B385053A477C507@qq.com>
        <3d56cf129c2cf1cf53f19ebe3c23a803@208suo.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 14 Jul 2023 05:57:42 +0100,
chenqingyun001@208suo.com wrote:
> 
> Since <asm/kprobes.h> is a kernel-proprietary header file, it
> should not be included by user-space programs.

There is no userspace involved here.

> And <linux/kprobes.h> is a public header file,
> which provides some functions for registering
> and unregistering probes

How is that relevant? Have you checked *why* we're including this
file?

> 
> Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com>
> ---
>  arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> index b35a178e7e0d..072471df8b1b 100644
> --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c
> @@ -9,7 +9,7 @@
>  #include <linux/compiler.h>
>  #include <linux/kvm_host.h>
> 
> -#include <asm/kprobes.h>
> +#include <linux/kprobes.h>

And this is at the wrong thing to do.

>  #include <asm/kvm_asm.h>
>  #include <asm/kvm_emulate.h>
>  #include <asm/kvm_hyp.h>
> 

I'd rather you *stop* sending these patches. There is no justification
for them, and you keep doing the wrong thing.

	M.

-- 
Without deviation from the norm, progress is not possible.