Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 10:22:47 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     huzhi001@208suo.com
Cc:     tglx@linutronix.de, senozhatsky@chromium.org, adobriyan@gmail.com,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c
Message-ID: <ZLEF16qgcTOaLMIk@alley>
References: <tencent_053A1A860EFB7AAD92B2409B9D5AE06AB507@qq.com>
 <2f88487fa9f29eeb5a5bd4b6946a7e4c@208suo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2f88487fa9f29eeb5a5bd4b6946a7e4c@208suo.com>
Precedence: bulk

On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote:
> The following checkpatch errors are removed:
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl.
It is not worth the effort. In fact, it is contra productive.
It complicates the git history, backports.

I suggest to find an area in the kernel which might be interesting
for you (any driver or subsystem, ...) and try to fix a real bug
there or implement a real feature.

You might start with reading the related discussions on lkml or
related mailing list, reviewing or testing patches, ...

Best Regards,
Petr