Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2171116rwp; Fri, 14 Jul 2023 01:45:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlF/KNTS0KSiWbYzZtvxj3p4D0k9sEeiU7rc3yk7kGJgBUwydi8d1oGrVEpbd4kNnmojlm8Q X-Received: by 2002:a19:7716:0:b0:4f6:1b45:e8aa with SMTP id s22-20020a197716000000b004f61b45e8aamr2966011lfc.50.1689324317990; Fri, 14 Jul 2023 01:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689324317; cv=none; d=google.com; s=arc-20160816; b=dY+PDx6s2zRzpvrkUuwExShvD08gGekTPVyj1wThEeZDoFN38v/F2XP+9EIy1SFLk8 ytc6ixKP+0e/Y8/etzEr9L2DUw73w4q3aYNLs1UbZ0YEW+q5YzCKeDerPqOlglav1yz0 sPrNc6NxI0jQfJv6IGFeAab3oJ8LQeo54uvJ7VDukoC7UM8CEgYmbTbw4/lhy2XDyOoG fQ3BCMK+2skvmEwIhXdDI1q5zr2LfWuOGNMJNhPtohvztooPJe6fHnrW8FWXE38mex4k Nnm22oqRvLxUyBa0hZtUVq5uxu01TGGwatMTjX9hgId5tA9Ukn1LVrFQBDwGbp4qaf5k +/Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5QhgMcxLrCOJceW2qDrEP0VVk9ydlAYkW2ZZG9lWHYU=; fh=oUgjoEaDOi/B2zt7cgkJ/NAakRX2mRUP7VHTKgYsXwc=; b=vZWtrnsK9cunXffroYQc2pV1ADRe3JtMDUNIcdoQ9hcIcGcLV130GQuMa7vtQ6bwS2 bOsb2u+1HURl7mZvr38mTfnYll5bSKWU541mbKghNgsMdXRfmdsfaOEwWgyvjpw/jAMm 5uJNHOg3Kj15OHdrgqf7tACQDOpefMfOPr9ftbf5IhFa5n7OdwidK9MBx2yjaqxhOg2W TrMS49NxEG5PO1uIpbGdlS7Xef+BoomE0hvHq0IVTcMrrJ3+3NGeVxNRDCV/78juXyJJ +UGGwnN+sPOTOORnsv5QlM8Vl3uSzjkKzZuZHdnOX25jDlUqNnjyfFtOdy/h8z97g6YN SJXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=FvvQ9YCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020a056402151900b0051e4728e759si8783961edw.520.2023.07.14.01.44.54; Fri, 14 Jul 2023 01:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=FvvQ9YCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235279AbjGNIbl (ORCPT + 99 others); Fri, 14 Jul 2023 04:31:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235060AbjGNIbf (ORCPT ); Fri, 14 Jul 2023 04:31:35 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5111FDB; Fri, 14 Jul 2023 01:31:33 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 9DB6A1FD60; Fri, 14 Jul 2023 08:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1689323492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5QhgMcxLrCOJceW2qDrEP0VVk9ydlAYkW2ZZG9lWHYU=; b=FvvQ9YCvAdL4LvIgbXynv6ZhxMygRtwtwXrRd9977cNjSeMIoy1SrQCXnizsGWes5Xd0DJ E5hKiEQ0gZkLux3MPF8vXU6Uh19yoBlbHHD9mDEZR9fSdWrhwmMXolBQCgDCLR8qGVySub 4c0wDldvEsZ94n0PtefUxR39MFGHI0I= Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 721212C142; Fri, 14 Jul 2023 08:31:32 +0000 (UTC) Date: Fri, 14 Jul 2023 10:31:32 +0200 From: Petr Mladek To: huzhi001@208suo.com Cc: tglx@linutronix.de, senozhatsky@chromium.org, adobriyan@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] proc: Fix four errors in kmsg.c Message-ID: References: <2f88487fa9f29eeb5a5bd4b6946a7e4c@208suo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2023-07-14 10:22:48, Petr Mladek wrote: > On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote: > > The following checkpatch errors are removed: > > ERROR: "foo * bar" should be "foo *bar" > > ERROR: "foo * bar" should be "foo *bar" > > ERROR: "foo * bar" should be "foo *bar" > > ERROR: "foo * bar" should be "foo *bar" > > Please, do not do fix these cosmetic issues reported by checkpatch.pl. > It is not worth the effort. In fact, it is contra productive. > It complicates the git history, backports. BTW, Did anyone suggest you to fix errors/warnings reported by checkpatch.pl? You seem to be 2nd person who sent similar patch from @suo.com within the last week. The first patch was rejected as well, see https://lore.kernel.org/all/f2d8eb955890bc1db1b307db713d4a4a@208suo.com/ You might want to tell this person that there are better ways how to get involved into the kernel development. Best Regards, Petr