Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b4dc1cc6-a0b1-1da2-6e22-edc44340c012@amlogic.com>
Date:   Fri, 14 Jul 2023 16:43:15 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH V2 1/2] dt-bindings: gpio: Add a header file for Amlogic
 C3 SoCs
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Conor Dooley <conor@kernel.org>,
        Huqiang Qin <huqiang.qin@amlogic.com>
Cc:     linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230710042812.2007928-1-huqiang.qin@amlogic.com>
 <20230710042812.2007928-2-huqiang.qin@amlogic.com>
 <20230710-maybe-mantis-e647d94fd13a@spud>
 <424cb61a-9102-9a43-c999-36939e8d6cc0@amlogic.com>
 <20230711-monthly-return-8792ce346c26@spud>
 <33bcb7c0-0bf9-e3fc-ec55-476c0cbd6105@linaro.org>
Content-Language: en-US
From:   Kelvin Zhang <kelvin.zhang@amlogic.com>
In-Reply-To: <33bcb7c0-0bf9-e3fc-ec55-476c0cbd6105@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sy9jWEcyRy9QUFk1QnFDejcyMFpkTmY2M0ZlbFpMSFdrTTFNdnZqUkJzRWJJ?=
 =?utf-8?B?NjA0d21HWThSZ3RWczdLaEc2eUhUYS8vSWJWdmViVURNMTJlcWRZZ2l4eHdn?=
 =?utf-8?B?azB6UmtOUXhZMlR5TDZzUnVlcThXbGdtb0lLUit1VGNJTXdIaW52aGprT1Jt?=
 =?utf-8?B?SW8yMzVvWlZBWW0wMlRHYjJRTzV6WWtCcEl0VE9LY3BDeHJmTGV6cWMzZlpE?=
 =?utf-8?B?UGVwMkhxWSswWUZxM3BYV2o3SWFSb1daVEswYS9FZFJGb2tWQmRZUjRqVTJB?=
 =?utf-8?B?YjJ1eWtuMlNXUnBIaHduckhVKzE4YnlCRGZjSTZzUkROU3BTVTU4ZVlYbHFV?=
 =?utf-8?B?N2cwa3J4aHgzeSsyc0cxMTFGcVBmb3NTSUlXRlpMVnQ5SGxwVTNIeUlpWTk0?=
 =?utf-8?B?cDJ0aGtPZFFkQ2hPb2l1WnZwZHduRll0QkRFWUVvOC91Q2wvRXRKYy9zVjk3?=
 =?utf-8?B?cCtFMWJDdDJCaGN5eVNhOEJmanZZeFZ2SU5sMG9EekN0RTlybnNiY2V2WnBI?=
 =?utf-8?B?cEVPOUM4dzVmZjQ3S05NaFhuNi9aK1BxMm9xc2ZkakZvc1N0VEtZc0g2VlMx?=
 =?utf-8?B?djdzWHVhc2U4K1BzZ1djRkdVVjB2aVBHbktMYUVtSWpWWXlkSVJUSDI2M2ls?=
 =?utf-8?B?ZFdHbWxFWVJHQnZuTDUrRis4UTRCMTRDSFExU2dURjQ1VnhmRE05SVBOeEZx?=
 =?utf-8?B?RVVualM0b3J6bHBQaUw5dnBuOFdGSnBGejczRTN3Rnh6K3hkZktEOVlzaHc3?=
 =?utf-8?B?Wi9FaUJ4UVlyTzhpKzdpdTRwVVNmemxVQnMrdnA3QlYwWlB3SXl6MXZHMTJJ?=
 =?utf-8?B?QWxDWGZIMkVNaEJJRERQN0VmSEZPNjRKVnJFMFJKdmg4WEl6VnRlMEZKR3pn?=
 =?utf-8?B?S1dBSTdBMXBlOGJ4dGRKaTY3MkwwaktraHJaNlJCaXprekdqT2c1a1NIUE1B?=
 =?utf-8?B?VGlPVlBNamJLWGVkQk96bGxwT1FHdTNMN0E2dUlYTUhQVno0QkRHMVpsSk4w?=
 =?utf-8?B?TW1XUDgwd2N0dUc0VFlWQ1pybi80RkQrMnNrbGdITDhTMkZnRmlkV0Zkc2tV?=
 =?utf-8?B?ZVVzaDhBRWE2RjMxWWFvWkxLcGFFc05abThiV3FsQnhoZHZWemRTa05BZTk2?=
 =?utf-8?B?Zmw4K2hoNDZrU1ZDdVpkWUQzam1IbDJiRDJhYTB2YkpGTzRuZVVpYkM0NnlP?=
 =?utf-8?B?SUprUnVWMUxMTVBMOUlrM1pULy9WWUtLZzhzUWtwRUpYUlpMcnlYQk1mWktR?=
 =?utf-8?B?cWtrVzdOWmFZM0pBWFZyQ3JYZXVYSzNvY01vZ0s2dU9XQWE5bjBCK3EwekNY?=
 =?utf-8?B?UmNselVXVWZrNE9GS3VFaXAzcm1DMk1aRmwxeDZjdFhMWmhuNitpaEVCNHBq?=
 =?utf-8?B?MUxod01qZkNCdmhaSGtiV3R2Nm5DQnhObFViNU9VcjJDWXN6MEk5dlIxdmsz?=
 =?utf-8?B?cUloaUx3WDBKOUdtMC9SUkhHSm5uKytYSnJaZXppa0JxWFVyUzduZEhhY2h1?=
 =?utf-8?B?WHY5L0pQNHFwWlZ0bGllSU93eVpDdmZzbVM5blp6Q3JaUzRDQ0JvLzk4M3Mr?=
 =?utf-8?B?dXdWbDdYb1htdzFXMUNFbzhWaVN6UGpsMCtaRUZ2cSs5YkdXTmVkMDNXQUNr?=
 =?utf-8?B?cmo4NEM5ek8vZW1tYXFJOHNidGhpcG1GaFVwK3dnL000UlA0SUtxSzFwL2VK?=
 =?utf-8?B?WFlpNk4xSUw3czBzeU9DWExmOTNEZmZiWHV1SkxTbkI3Z1loMlAxdWp5M1ph?=
 =?utf-8?B?d2doK3RFcUNqMHF3bGs3ZXQ3aVMyeFRGaHIzalE5alhjc2JaZHVKMFExa1k1?=
 =?utf-8?B?ZnRyN0ZENUw5Q0pDaVdxalhab2x0QkNYc2dyejZ5SXh1K1d0eTU1OXl3S1N5?=
 =?utf-8?B?TnlUY09Ib254T3RJcGVjM0JIN2t4cyt3NzBWclhXOXZaM0ZqaW1UcFFSVFVp?=
 =?utf-8?B?UU5ERmxaUVFFSS9BOTlGLzRieDBzT0RSV21QejdKMEJHRDJJUTAxMElpanFW?=
 =?utf-8?B?WCtHWU1NdVI2eVJ2RUJSRlRMU1A3V1IzOHlTQVRPdkVoWHl4UkorRys0Z1Z5?=
 =?utf-8?B?UDB0K1lHM3cwRW5jNE5OT2lBbGEvalVRNFppRWcrUUJoREc0Smh1SGFZM3A3?=
 =?utf-8?B?UHZQMS9TWEtiNy9GUWljRUw5RVI2L0Z6dkFlL2JOUFRMeTJiRmhSQmpWNzJx?=
 =?utf-8?B?MEE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28d2421d-d4ed-4377-e3d9-08db844663d0
X-MS-Exchange-CrossTenant-AuthSource: JH0PR03MB7384.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 08:43:26.7051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vLxkLvB17AZaw/nayrR1ML03WBqlD3liPv7+9L7haBKxoq7427sduR5oauKVOPCPmyFCMI2/WkwOxWyDf8sjmBPk3Z3CciXQS85S4JS1wM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB7836
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/7/12 13:56, Krzysztof Kozlowski wrote:
> 
> On 11/07/2023 20:05, Conor Dooley wrote:
>>>>> +++ b/include/dt-bindings/gpio/amlogic-c3-gpio.h
>>>>> @@ -0,0 +1,72 @@
>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>>>> Any reason to deviate from the usual license terms for bindings, which is
>>>> "GPL-2.0-only OR BSD-2-Clause"?
>>>
>>> I initially used the license commonly used by Amlogic (reference: meson-s4-gpio.h):
>>> ```
>>> /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>>> ```
>>>
>>> But when I checked the patch, some warnings appeared:
>>> ```
>>> WARNING: DT binding headers should be licensed (GPL-2.0-only OR .*)
>>> #37: FILE: include/dt-bindings/gpio/amlogic-c3-gpio.h:1:
>>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
>>> ```
>>> So I followed the prompts and changed the license.
>>>
>>> Can I ignore this warning and use the (GPL-2.0+ OR MIT) license?
>>
>> If the tools are happy then I suppose you are okay.. I'll leave that to
>> Rob or Krzysztof, but if you have a reason for diverging that seems fine
>> to me.
> 
> It is very weird that company wants GPLv3 and even weirder that it
> agrees for GPLv4 and GPLv5 (GPLv5 might force Amlogic to do some
> interesting things...). I am pretty sure company lawyers don't want it
> and just do not understand licenses or someone forgot to actually check
> it. Anyway, it's fine for Linux kernel, if you really need it.
> 

That's true.
We will follow the checkpatch suggestion.
Thanks!

> However the argument was "meson-s4-gpio.h" has it, which is not really
> correct argument or accurate. Is it derivative work that you need the
> same license? If not, why presence of something causes you to do the
> same without thinking?
> 
> If Amlogic requires GPLv3 or GPL4 or GPLv2000, please confirm it here
> with your official email. Otherwise, if it is not a derivative work
> confirm that. Otherwise just go with what checkpatch asks you.
> 
> Best regards,
> Krzysztof
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic