Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 10:41:03 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     =?utf-8?B?5p2c5pWP5p2w?= <duminjie@vivo.com>
Cc:     Baolu Lu <baolu.lu@linux.intel.com>,
        Krishna Reddy <vdumpa@nvidia.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>,
        Thierry Reding <treding@nvidia.com>
Subject: Re: =?utf-8?B?5Zue5aSNOiBbUEFUQ0ggdjRdIGlv?=
 =?utf-8?Q?mmu=3A_remov?= =?utf-8?Q?e?= redundant parameter check in
 tegra_smmu_debugfs_init()
Message-ID: <ZLEKH8ixyRH7IzLK@orome>
References: <20230713072825.10348-1-duminjie@vivo.com>
 <362e4343-dcf1-58fc-7ac9-756c65bb0df6@linux.intel.com>
 <SG2PR06MB5288ED578DB3CE7DA2B25AB5AE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="sWp9+yLAQfcZfBiY"
Content-Disposition: inline
In-Reply-To: <SG2PR06MB5288ED578DB3CE7DA2B25AB5AE34A@SG2PR06MB5288.apcprd06.prod.outlook.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--sWp9+yLAQfcZfBiY
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 14, 2023 at 03:21:47AM +0000, =E6=9D=9C=E6=95=8F=E6=9D=B0 wrote:
> Hi Baolu!
>=20
> It seems that 'smmu->debugfs' check is still needed.
> Then I will modify the patch.
> Thanks!
>=20
> regards,
> Minjie

Don't top-post, please. See Documentation/process/2.Process.rst and
Documentation/process/submitting-patches.rst.

Also, how did you come to the above conclusion? Baolu said that Greg
keeps reminding people that we shouldn't do error handling for debugfs
and gave a Reviewed-by:, so why the 180?

Thierry

> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Baolu Lu <baolu.lu@linux.intel.com>=20
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B47=E6=9C=8814=E6=97=A5 =
10:58
> =E6=94=B6=E4=BB=B6=E4=BA=BA: =E6=9D=9C=E6=95=8F=E6=9D=B0 <duminjie@vivo.c=
om>; Thierry Reding <thierry.reding@gmail.com>; Krishna Reddy <vdumpa@nvidi=
a.com>; Joerg Roedel <joro@8bytes.org>; Will Deacon <will@kernel.org>; Robi=
n Murphy <robin.murphy@arm.com>; Jonathan Hunter <jonathanh@nvidia.com>; op=
en list:TEGRA IOMMU DRIVERS <linux-tegra@vger.kernel.org>; open list:IOMMU =
SUBSYSTEM <iommu@lists.linux.dev>; open list <linux-kernel@vger.kernel.org>
> =E6=8A=84=E9=80=81: baolu.lu@linux.intel.com; opensource.kernel <opensour=
ce.kernel@vivo.com>; Thierry Reding <treding@nvidia.com>
> =E4=B8=BB=E9=A2=98: Re: [PATCH v4] iommu: remove redundant parameter chec=
k in tegra_smmu_debugfs_init()
>=20
> [Some people who received this message don't often get email from baolu.l=
u@linux.intel.com. Learn why this is important at https://aka.ms/LearnAbout=
SenderIdentification ]
>=20
> On 2023/7/13 15:28, Minjie Du wrote:
> > debugfs_create_file() will return early if smmu->debugfs is an error=20
> > pointer, so an extra error check is not needed.
> >
> > Signed-off-by: Minjie Du<duminjie@vivo.com>
> > Acked-by: Thierry Reding<treding@nvidia.com>
>=20
> Greg keeps reminding that no error branch for debugfs, so
>=20
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>=20
> Best regards,
> baolu

--sWp9+yLAQfcZfBiY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSxCh0ACgkQ3SOs138+
s6FoQxAAqLECF0cZvl6wXvAO8Kz53hrol4zJ2QZiSt+XzufD1uZDKVW/EYFWs90x
0q7zpyohghBoiffKQ3byPHg7NZtLjdfxFEBR9i15/YSCTO6hxjQOUItA4uvS/40p
R2hyTEAdwPa/UvsZbrldAOCq4gy9jaymvtZe3GLSiZmL60rDT+U2uti0WzXhRdQE
drthzwKIdkOE46D4gDtQAT/L2I1KTkyc+b79484vB5rnQ4iFLLvp3FjtS2q9dZtx
ppzSHlUvsxSHf3ujtjTrKEi8cF6p4m5pXhYCSyuClxeqHZmf6i9y06e7AGZaj2J5
3OQLH4l7ppVroDhpM+6HEHUEtJNr9ORk7PmNKvfcMJuc+8AYCr939BXKloPEFTGC
4Wdl6nCRNCPc53EYGbCw0S9ma3re6bwzAwjNwpME1rITQpkTJtPBTUCjX+8LM1HZ
ZOBubBQ+iWCzSZVSsJMlJpb71D+b4ztzC9e0fyDwdLQXc7lQMfawnwHuh0tzvFdo
mNM4baUFrvuuGjL0ItkS3cXRqSmdlrKzRrBhEDBByXAvsgP1Bsit8jTJUpqiAT45
wDxm8AxmdY6uXBQv3Ar5Uov5XQ30OzLLbPtarX3ya7f/oFBcmDbVUitf9woQf0nv
xYVfSXJAJDDvqLQ9UfEl/6TtVMI6VnIyd91ByJrV7mmXOXgTl9A=
=yASD
-----END PGP SIGNATURE-----

--sWp9+yLAQfcZfBiY--