Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 15:53:05 +0800
From:   Li Chen <me@linux.beauty>
To:     "Rob Herring" <robh+dt@kernel.org>
Cc:     "Frank Rowand" <frowand.list@gmail.com>,
        "devicetree" <devicetree@vger.kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Message-ID: <1895363a02c.112ba0843416665.413138938060634927@linux.beauty>
In-Reply-To: <CAL_JsqKSnhvgDfXA46v_CzFn1q1U_Lr7N=JA8bMYMrPAgENOWA@mail.gmail.com>
References: <1894ed7a1a9.f5e49d5d141371.2744760538860302017@linux.beauty> <1894edd07ee.b7245352142935.3234373322799059936@linux.beauty> <CAL_JsqKSnhvgDfXA46v_CzFn1q1U_Lr7N=JA8bMYMrPAgENOWA@mail.gmail.com>
Subject: Re: [PATCH V2] of: property: fw_devlink: fixup return value check
 of strcmp_suffix in parse_gpios
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

Hi Rob,
 ---- On Fri, 14 Jul 2023 00:45:24 +0800  Rob Herring  wrote ---=20
 > On Thu, Jul 13, 2023 at 4:47=E2=80=AFAM Li Chen me@linux.beauty> wrote:
 > >
 > > This commit addresses an issue where enabling fw_devlink=3Don was caus=
ing
 > > a PCIe malfunction, resulting in endpoints missing.
 > > After thorough investigation, it was determined that the root cause wa=
s
 > > an incorrect usage of strcmp_suffix in parse_gpios.
 > >
 > > Fixes: d473d32c2fba ("of: property: fw_devlink: do not link ".*,nr-gpi=
os"")
 > > Signed-off-by: Li Chen lchen@ambarella.com>
 > > Cc: stable@vger.kernel.org
 > > ---
 > > changes:
 > > v1->v2: add Cc stable
 > >
 > >  drivers/of/property.c | 2 +-
 > >  1 file changed, 1 insertion(+), 1 deletion(-)
 > >
 > > diff --git a/drivers/of/property.c b/drivers/of/property.c
 > > index ddc75cd50825..261eb8f3be08 100644
 > > --- a/drivers/of/property.c
 > > +++ b/drivers/of/property.c
 > > @@ -1272,7 +1272,7 @@ DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 > >  static struct device_node *parse_gpios(struct device_node *np,
 > >                                        const char *prop_name, int inde=
x)
 > >  {
 > > -       if (!strcmp_suffix(prop_name, ",nr-gpios"))
 > > +       if (strcmp_suffix(prop_name, ",nr-gpios"))
 >=20
 > strcmp returns 0 when there is a match. When we match ",nr-gpios", we
 > want to bail out. The existing code was correct. Your patch just
 > disables fw_devlink for all GPIO dependencies.
=20
Yes, your are correct, thanks!

Regards,
Li