Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: Fixes issue with dequeuing not queued
 requests
Thread-Topic: [PATCH] usb: cdnsp: Fixes issue with dequeuing not queued
 requests
Thread-Index: AQHZtWIUOnzlmDC91EyICLRPIn7cGq+4hxoAgABUPOA=
Date:   Fri, 14 Jul 2023 07:19:21 +0000
Message-ID: <BYAPR07MB5381BA3F7A34D18BC16B86DFDD34A@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20230713081429.326660-1-pawell@cadence.com>
 <20230714021436.GA2520702@nchen-desktop>
In-Reply-To: <20230714021436.GA2520702@nchen-desktop>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+Njh/prtfWY6H7KR7rqWyiKdPGR0KICi+cgxM0uR6OXyDq5EI08b0KF0u7fc?=
 =?us-ascii?Q?XaOP9qppFCBPwvrrzGg5qRlb4iO0+1djA3S5TvMOP/ay+VFsVjVSphoGjYT2?=
 =?us-ascii?Q?P0lx3PT5n9AEELkwV56+unCK0Hy0c9ju9m9fSrMFWNummLBhUXWszuuSijMA?=
 =?us-ascii?Q?kv+ACDJygguQchgGqlMp+Zi8clhQMw84r2dqfBEDAkP6npMswLkRW69vGqLM?=
 =?us-ascii?Q?F3gofk2AfRkrZPhdQrbBmr8CrHElaDUGRpmbLjYff+9xADTumR1bY7RHahVe?=
 =?us-ascii?Q?diK3Gc2CpnN7qGfATtwX3JcM9cMdGuB9w+IjOxacQ09fiKK2z0IXo5odHCZl?=
 =?us-ascii?Q?+zXVWVGGP3Td60v/9f2F98mdKXKnORndSLVxSg86zikhjxJCATL0/Ms452ha?=
 =?us-ascii?Q?X7m/PxhBjNFdmmnA2X6l2TiN0tTEl3Rlgc5rWOWTWsjGsw35+cgOWAewWM0n?=
 =?us-ascii?Q?BL8p0obTTasQnJCtshNci0eyLY9ryxByD0Td2nIxdGGLg9jFFP5uZr02V/lb?=
 =?us-ascii?Q?bK6rMJ2GKsPt2qhCUNOPlSY8gBarYk8JfYkAh8zOvxBelA2hzZJgdv8G08l9?=
 =?us-ascii?Q?9Yn+L8Nib0vG1eN1tFp7J86cK3FGO/9Rw0uIiqpoBNYVYQtTvQl1yK5/rZx+?=
 =?us-ascii?Q?cPnwY/pN3UhprJRkRySHJKWNAWpI9Oqf2TgcROR/DKAa+A52UxayY1vOXgTL?=
 =?us-ascii?Q?Q5bqt3T1BUo+IpDY8Xtwkmz5ePZ1DguvoXne3T0doEQEe+fguUtYgJrzbzFc?=
 =?us-ascii?Q?Zc1Vll+v52mYpeoNrABVko8PnDhy+K4cjp2rJJCIlUEoKHnCLa5HNb9ye8aC?=
 =?us-ascii?Q?xZ837RSslvpnl+6ORxvs93l45yHL/k6wEtQDqbI8w9+FmWVAPjsvVsBXNffI?=
 =?us-ascii?Q?px24fDQYug0F5IbYh1K19E4dge6mFrmRxhCkS5HufMEWssjaSKDNLzhOg4I1?=
 =?us-ascii?Q?Vnr7Dm3B04fC/nIMvXIRd/Bol16OGFiccz4AudceQBxSY+XVuLJMSwYOT8wL?=
 =?us-ascii?Q?Juu0dPOH/YQXPEov0yckjx+RIqAF0zexWflDL0ly7ysTEs2Cgodh1l/xIXJR?=
 =?us-ascii?Q?0boKkzfiXiFATSXUvN8Rjrw1My+4Xhw/6zRDB2No67BN0fxAO3koSK8QoqQa?=
 =?us-ascii?Q?MMPDayR/lrYEpou6jWYJQidx2LVFKmtnR/jZYFzf5OKQRM7bavWBjGAZc1ah?=
 =?us-ascii?Q?Ee3mhHNQ9DPoQiN6D85JyqL6KrPcb1u3DuBPO7d9z4BAAruU6UDqX69DhNgN?=
 =?us-ascii?Q?IlNg5jScWcSoAFyUxbyIa0lVHPjeIgTNUPETeL/u6BzEsKNy3kJOEw77Dqsk?=
 =?us-ascii?Q?dTpqAgLYIgVY90xELE0OzzCbQ69LmbiHefp0FMixCdLW2/lrQHincGNGIPcz?=
 =?us-ascii?Q?qSUotVQwBMbGqJI3XB+OT+8lh0w4MKXa7TMAkHih/gisbpuZxbQE0JO3FJaj?=
 =?us-ascii?Q?KfkZx7Ibbaex4ervwILEfAC1HWDVe6v4VocGrgNkCwV7ahHwfY95l37aGDGQ?=
 =?us-ascii?Q?fcrb6MQwuQt4JPdwHjL2vI7fVjYGie73+Fg93LCYbsYlRcMaZydEBXvRaJ6V?=
 =?us-ascii?Q?SYcaErqxOROEm6YNktrivMUhdlnqCnmPyG4pxBkR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e908f0a-b8cc-4a82-5d73-08db843aa52c
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2023 07:19:21.6647
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PTfVc3dheZNqLb6w5LmANv73mwkj+rXRlMsBfETEgl/xYsPZtQOgKebxXipmQESQ8DWvvp4nqsmC6XVOzqjeR7kqlBdxVLJrbiHwjJVHThs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR07MB9236
X-Proofpoint-GUID: F3vnk_sZ-Nrg3WHSfCrEhALP9npCNnI_
X-Proofpoint-ORIG-GUID: F3vnk_sZ-Nrg3WHSfCrEhALP9npCNnI_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-14_04,2023-07-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 clxscore=1015 bulkscore=0 mlxscore=0 phishscore=0
 impostorscore=0 suspectscore=0 spamscore=0 mlxlogscore=551 malwarescore=0
 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2306200000 definitions=main-2307140067
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On 23-07-13 04:14:29, Pawel Laszczak wrote:
>> Gadget ACM while unloading module try to dequeue not queued usb
>> request which causes the kernel to crash.
>> Patch adds extra condition to check whether usb request is processed
>> by CDNSP driver.
>>
>
>Why ACM does that?
>
>> cc: <stable@vger.kernel.org>
>> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence
>> USBSSP DRD Driver")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/cdnsp-gadget.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c
>> b/drivers/usb/cdns3/cdnsp-gadget.c
>> index fff9ec9c391f..3a30c2af0c00 100644
>> --- a/drivers/usb/cdns3/cdnsp-gadget.c
>> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
>> @@ -1125,6 +1125,9 @@ static int cdnsp_gadget_ep_dequeue(struct
>usb_ep *ep,
>>  	unsigned long flags;
>>  	int ret;
>>
>> +	if (request->status !=3D -EINPROGRESS)
>> +		return 0;
>> +
>
>Why not you use pending list which used at cdnsp_ep_enqueue to do this?

It's just simpler and faster way - no other reasons.=20

Thank,
Pawel

>
>
>>  	if (!pep->endpoint.desc) {
>>  		dev_err(pdev->dev,
>>  			"%s: can't dequeue to disabled endpoint\n",
>> --
>> 2.37.2
>>
>
>--
>
>Thanks,
>Peter Chen