Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2230795rwp; Fri, 14 Jul 2023 03:01:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGgJr+VqsSKLRKpxcWIkefq+BNb/06F5D69dArVK9p2rc60EsAR75mGRxNQAQiEco3GCKSP X-Received: by 2002:ac2:46d4:0:b0:4f8:56c8:e6b4 with SMTP id p20-20020ac246d4000000b004f856c8e6b4mr3272417lfo.47.1689328869395; Fri, 14 Jul 2023 03:01:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689328869; cv=none; d=google.com; s=arc-20160816; b=fEDv3ZHF2CDxa8r4/9NeVHVw+p1ZGfchBIK2Guin5BujkkyjwhyKTtvyqerQxndyvp cF8NKIMCWlyBJ4wSFojes7YAyShDhaxauMXp78RmPoq16ZpnTlj6YVpzE1Dt8OBiComT Pzs8Z9AtJgfd6sinHw3FQ42tRPQWj3it1p+ivGSrohsfDYrVowmJyvr6xIZBZV1+9q0Q cnIIJuuxcHRiZqNul5nebAUr3aTUP6QEye7MI1802lhxlh7WAmbeDFj7JmdrfKaZoEnK 90jkKpcfOwXPJ+s5QeRvErXZP+/q926BUSvQAa7cVYF4QQMi05lXl3U9DtRLUszxt+2S kCLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GH8CMfUmOJpE9gd+H4iroJkL0rclNflkWxyF8IZniXk=; fh=TkwgLRvzqrPJZIhPlApMAOes8jGwnFuXeDGCf1w/hyc=; b=vS7bMYdXAv0m78owqeddeY13JiBrvFYqmQDA/+TfeHI3DQ8o1UrFL1ySQhFYdQt4Qs /1b6FL1aCP18+Py/zYdiIlix6BOUeBNtbX3EDeudUqA9UtNGxJ7D29VW/RcYXv/EUIB4 VImAtqYpD6QWjtqgMMnDlgZl1lAgWM3aHcFiFfD0Y76qtxQ0fHO+WA0UGf5gxEjWbK3W yCaCwgGQq8pAOxBz4iAdI7S6FlWsvTYPUc5RhLuOb5LTr91dXzQD0W8VwF5cy6jIjSdK qu0eKlFPe9B3tk7mrce035O2LnGHJVqbyotDoZdriEAIHaeKpN1N6ueoJjQtXZtDWqLF VRnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qZcg/XDO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o12-20020aa7c50c000000b0051dd50ceaa3si8675874edq.180.2023.07.14.03.00.45; Fri, 14 Jul 2023 03:01:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qZcg/XDO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235836AbjGNJbC (ORCPT + 99 others); Fri, 14 Jul 2023 05:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235426AbjGNJbA (ORCPT ); Fri, 14 Jul 2023 05:31:00 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F40F82D78 for ; Fri, 14 Jul 2023 02:30:29 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-579ed2829a8so16838907b3.1 for ; Fri, 14 Jul 2023 02:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689327028; x=1691919028; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GH8CMfUmOJpE9gd+H4iroJkL0rclNflkWxyF8IZniXk=; b=qZcg/XDOZUtXrelRLc7puAIjVSD3iBp0U1/g5G206gLcehHc367RZBkCxbaGui+NM6 wlBYFarEg+zCiHhyGNYb+r4Isv2bIeBc8YgUUVfq/ZuDC9QHcf3cbNFd+b/tl+i9OQEE dGmTMqc1LwhcB6tqP3GNtm1Jk6yw2af81K04PXRLurAwpdUYIJYQ3Y5Vg1Db6grWKzeT 56s6Sn9uNDK1RrUScx4COgDq6MONtsFZ4cHRyfw6Zl/JFdpA287iMt415MxZI0HTfMk5 fz1lOiuhxOmqFvIKqTd4AXLY0wa9FEF7NeleZdLDVfXKjV3gXrMMzo5da0kkrrkghZEd OzlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689327028; x=1691919028; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GH8CMfUmOJpE9gd+H4iroJkL0rclNflkWxyF8IZniXk=; b=Ol0s6hY5usamBBCAB2MOhZAfjjrDhCeHlEttbjSkmoiTVPZDQk5zOpuw8XrIPNtbhr wrzsMYarHyqTvr80VHOhEZMEdkSNzrX08MejC09DMVmBxCG0t3k8zgI1crBYEh4X8BQ1 gm0LxMkKkC4dROSG/SYETK6Bzr+Wlw9ZpNEqar/3xYXTWDPqGou05eX/u/BXx6TaksLG sBWtp0lz+llm6Etbn5/rBeITFSnc8d7lYqtkOs44YZymlZxNE+QD5hdxz2XD0NG1WSPR 3FTvsSeVlTIU0P7/stIGLK7YMLBZn+VR0QtEmCwGSmHhMan1IasnV00w4slvRECUmH5z 5Wuw== X-Gm-Message-State: ABy/qLZjYIt/LRO+tv4IyqDhPAghRYug0eWfz/b6YheHZ4H+ojbemITo SAJuzGLhp/LJcCB9QCiJ1cL6S7+dOcLOZitS5eQ29g== X-Received: by 2002:a81:4757:0:b0:54f:9cd0:990 with SMTP id u84-20020a814757000000b0054f9cd00990mr4245400ywa.18.1689327028459; Fri, 14 Jul 2023 02:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20230630004533.26644-1-hayashi.kunihiko@socionext.com> <1d924f9a-54b7-e70b-304c-284e5bf90b59@socionext.com> In-Reply-To: <1d924f9a-54b7-e70b-304c-284e5bf90b59@socionext.com> From: Ulf Hansson Date: Fri, 14 Jul 2023 11:29:52 +0200 Message-ID: Subject: Re: [PATCH v2] mmc: sdhci-f-sdh30: Replace with sdhci_pltfm To: Kunihiko Hayashi Cc: Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Jul 2023 at 13:38, Kunihiko Hayashi wrote: > > Hi Ulf, > > On 2023/07/13 20:06, Ulf Hansson wrote: > > On Fri, 30 Jun 2023 at 02:45, Kunihiko Hayashi > > wrote: > >> > >> Even if sdhci_pltfm_pmops is specified for PM, this driver doesn't apply > >> sdhci_pltfm, so the structure is not correctly referenced in PM functions. > >> This applies sdhci_pltfm to this driver to fix this issue. > >> > >> - Call sdhci_pltfm_init() instead of sdhci_alloc_host() and > >> other functions that covered by sdhci_pltfm. > >> - Move ops and quirks to sdhci_pltfm_data > >> - Replace sdhci_priv() with own private function sdhci_f_sdh30_priv(). > >> > >> Fixes: 87a507459f49 ("mmc: sdhci: host: add new f_sdh30") > >> Signed-off-by: Kunihiko Hayashi > >> Acked-by: Adrian Hunter > > > > Applied for next, thanks! > > > > Or maybe this should go for fixes and have a stable tag too? > > Thank you for applying! > I think this should be applied to the stable branch if possible. Alright, I have moved the patch to fixes and added a stable tag, thanks! Kind regards Uffe