Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230713112404.2022373-1-imagedong@tencent.com> <04a96ba2-6952-e6de-93a2-dc2998ce519d@infradead.org>
In-Reply-To: <04a96ba2-6952-e6de-93a2-dc2998ce519d@infradead.org>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Fri, 14 Jul 2023 17:56:03 +0800
Message-ID: <CADxym3Y2f6-FfyG3RfvPDXLS3b3FqUfxaDPgju6OoQPy-0i9bQ@mail.gmail.com>
Subject: Re: [PATCH net-next v2] net: tcp: support to probe tcp receiver OOM
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     edumazet@google.com, ncardwell@google.com, davem@davemloft.net,
        kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net,
        dsahern@kernel.org, kuniyu@amazon.com, morleyd@google.com,
        imagedong@tencent.com, mfreemon@cloudflare.com,
        mubashirq@google.com, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 13, 2023 at 11:43=E2=80=AFPM Randy Dunlap <rdunlap@infradead.or=
g> wrote:
>
>
>
> On 7/13/23 04:24, menglong8.dong@gmail.com wrote:
> > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/net=
working/ip-sysctl.rst
> > index 4a010a7cde7f..3de2dce74037 100644
> > --- a/Documentation/networking/ip-sysctl.rst
> > +++ b/Documentation/networking/ip-sysctl.rst
> > @@ -694,6 +694,20 @@ tcp_retries2 - INTEGER
> >       RFC 1122 recommends at least 100 seconds for the timeout,
> >       which corresponds to a value of at least 8.
> >
> > +tcp_oom_retries - INTEGER
> > +     RTO retransmissions count of the receiver is recognised as OOM.
> > +     Given a value N, a hypothetical TCP connection will enter probe
> > +     state if N times RTO retransmissions performed and every
> > +     retransmission gets a pure ack, who doesn't contain SACK block.
>
>                                    ACK
> > +
> > +     The default value is 0, which means disable the OOM detection.
> > +     If disabled, skb will be dropped directly, without sending an
> > +     ACK, when rmem schedule fails. The function is valid only if sack
>
>                                                                      SACK
>
> > +     is enabled.
> > +
> > +     3 is the suggested value to enable this function. Do't make it
>
>                                                           Don't
>
> > +     greater than tcp_retries2.
>

Thanks! I'll fix them in the next version.

> --
> ~Randy