Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 13:35:22 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Reinette Chatre <reinette.chatre@intel.com>
cc:     linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        Babu Moger <babu.moger@amd.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 04/19] selftests/resctrl: Close perf value read fd on
 errors
In-Reply-To: <a4fa6303-4637-815a-e0fa-57f33babfb10@intel.com>
Message-ID: <c14286ec-807c-8613-a4cc-d8ac733a87a1@linux.intel.com>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com> <20230713131932.133258-5-ilpo.jarvinen@linux.intel.com> <a4fa6303-4637-815a-e0fa-57f33babfb10@intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-782494842-1689327854=:1695"
Content-ID: <a04ebfa5-62bf-328d-457c-43abfcbef33a@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-782494842-1689327854=:1695
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <42226133-5e22-b1fa-fb3-7cc2ac9b62@linux.intel.com>

On Thu, 13 Jul 2023, Reinette Chatre wrote:

> Hi Ilpo,
> 
> On 7/13/2023 6:19 AM, Ilpo J?rvinen wrote:
> > Perf event fd (fd_lm) is not closed on some error paths.
> > 
> > Always close fd_lm in get_llc_perf() and add close into an error
> > handling block in cat_val().
> > 
> > Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> > Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> >  tools/testing/selftests/resctrl/cache.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c
> > index 8a4fe8693be6..ced47b445d1e 100644
> > --- a/tools/testing/selftests/resctrl/cache.c
> > +++ b/tools/testing/selftests/resctrl/cache.c
> > @@ -87,21 +87,20 @@ static int reset_enable_llc_perf(pid_t pid, int cpu_no)
> >  static int get_llc_perf(unsigned long *llc_perf_miss)
> >  {
> >  	__u64 total_misses;
> > +	int ret;
> >  
> >  	/* Stop counters after one span to get miss rate */
> >  
> >  	ioctl(fd_lm, PERF_EVENT_IOC_DISABLE, 0);
> >  
> > -	if (read(fd_lm, &rf_cqm, sizeof(struct read_format)) == -1) {
> > +	ret = read(fd_lm, &rf_cqm, sizeof(struct read_format));
> > +	close(fd_lm);
> > +	if (ret == -1) {
> >  		perror("Could not get llc misses through perf");
> > -
> >  		return -1;
> >  	}
> >  
> >  	total_misses = rf_cqm.values[0].value;
> > -
> > -	close(fd_lm);
> > -
> >  	*llc_perf_miss = total_misses;
> >  
> >  	return 0;
> > @@ -253,6 +252,7 @@ int cat_val(struct resctrl_val_param *param)
> >  					 memflush, operation, resctrl_val)) {
> >  				fprintf(stderr, "Error-running fill buffer\n");
> >  				ret = -1;
> > +				close(fd_lm);
> >  				break;
> >  			}
> >  
> 
> Instead of fixing these existing patterns I think it would make the code
> easier to understand and maintain if it is made symmetrical.
> Having the perf event fd opened in one place but its close()
> scattered elsewhere has the potential for confusion and making later
> mistakes easy to miss.
> 
> What if perf event fd is closed in a new "disable_llc_perf()" that
> is matched with "reset_enable_llc_perf()" and called
> from cat_val()?
> 
> I think this raises another issue with the test trickery where
> measure_cache_vals() has some assumptions about state based on the
> test name.

I very much agree on the principle here, and thus I already have created 
patches which will do a major cleanup on this area. The cleaned-up code 
has pe_fd local var to cat_val() and handles closing it in cat_val() with 
the usual patterns.

However, the patch is currently resides post L3 CAT test rewrite. 
Backporting the cleanups/refactors into this series would require 
considerable effort due to how convoluted all those n-step cleanup patches 
and L3 CAT test rewrite are in this area. There's just very much to 
cleanup here and L3 rewrite will touch the same areas so its a net 
full of conflicts.

Do you want me to spend the effort to backport them into this series 
(I expect will take some time)?

I currently have these items pending besides this series (in order):
- L3 CAT test rewrite and its preparatory patches
- More cleanups (including the pe_fd cleanup)
- New generalized test framework
- L2 CAT test

-- 
 i.
--8323329-782494842-1689327854=:1695--