Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71f8c48d-8e28-9292-ae31-a1a11498ec1b@linux.intel.com>
Date:   Fri, 14 Jul 2023 13:23:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 07/15] ALSA: hda/i915: Use global PCI match macro
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>
References: <20230714185615.370597-1-amadeuszx.slawinski@linux.intel.com>
 <20230714185615.370597-8-amadeuszx.slawinski@linux.intel.com>
 <ZLEvZ3Ss05A+x1ty@smile.fi.intel.com>
From:   =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <ZLEvZ3Ss05A+x1ty@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/14/2023 1:20 PM, Andy Shevchenko wrote:
> On Fri, Jul 14, 2023 at 08:56:07PM +0200, Amadeusz Sławiński wrote:
>> Instead of using local macro to match PCI device, use global one.
> 
> ...
> 
>> @@ -2718,7 +2718,6 @@
>>   #define PCI_DEVICE_ID_INTEL_82840_HB	0x1a21
>>   #define PCI_DEVICE_ID_INTEL_82845_HB	0x1a30
>>   #define PCI_DEVICE_ID_INTEL_IOAT	0x1a38
>> -#define PCI_DEVICE_ID_INTEL_HDA_APL_T	0x1a98
>>   #define PCI_DEVICE_ID_INTEL_HDA_CPT	0x1c20
>>   #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN	0x1c41
>>   #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX	0x1c5f
> 
> Looks like it should be a separate change.
> 

Oops... must have fixed up wrong patch, and I even looked at all patches 
before sending them, to check for something like that :|