Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2365526rwp; Fri, 14 Jul 2023 05:15:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlGZtbYmao/VUWqVdr7VH985RS/bFnAtbknSPP41JAWDHtGy3CelcwX2vUTLxt9lza5H997y X-Received: by 2002:a05:6a20:8e1a:b0:133:b3a9:90d with SMTP id y26-20020a056a208e1a00b00133b3a9090dmr1456988pzj.36.1689336911901; Fri, 14 Jul 2023 05:15:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689336911; cv=none; d=google.com; s=arc-20160816; b=DUU4aZqDvIeCX08qk7XrHrK0rrKX1yjqrJYlCiEYOaP73rUIe619N+DUFFYJ+FuJAz WQ8D1NuLRoNjlJxyLc6ny0kxt4L8Iw98zmF/WsQfo9yYV5Lja7Xn06+5X49/pvZKBObz kbMacsVLcTerb1DVydiW0wnXuoGXp1PwVR0+yuJlRkjkCAXPBniZ1yGjwF/M3V6ify7q VLn/INuD4pavgipvHNrUGY/Zmj3DTnD7sS1x57vwaLsvLyt5KrCIbmDcALrtsSrQRnkK FS0xM4jXxwvzsze97iIAb1ynTlwUcuWn6WPem0JtzhxuAZCs+9kDMPlpP63sluezqrw6 GGzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=At0xbxSbJqBndkT5E1gEuaNWyCKn9gXZSodJ0QJAaUU=; fh=K5ChGqC0TbqU+KjxnzVzYdD+LOFTVqwBq6XXn3hiVwA=; b=NlY1EIZHeUW9Tb7/MaLNKt6S/Ow6mBuDupB7eG25nM80uWndbzLEUvByMjwjTn3FyR 63392eZi2QVfpHMJntJaVdVcI35O2aKDGV1UZauvTSaPFUzU7ZBr3spOJc9TMNFKtD85 oT/P50vuVRC31vQc1b9SleIxDfBL4KGUo3IDsaH9LIg6oBDPdUcdo3sSeWA3NvX4yq+d mEf4IaXA+xkK8meOn3jyVXF2HbziBQ07fTklOkfVBvw4iasH51i0dYTMApAc2yWNcAEJ RBBgyInHixIxouhoMxmyiKpU6hBnqVvr7Ni8g80Nix3BRe4SWKCkD6wQk7B74SdLkrfC eTKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="U/kh/Ou3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a056a00178d00b0067f03c85d88si7229311pfg.177.2023.07.14.05.14.56; Fri, 14 Jul 2023 05:15:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="U/kh/Ou3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235393AbjGNLmd (ORCPT + 99 others); Fri, 14 Jul 2023 07:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235343AbjGNLm3 (ORCPT ); Fri, 14 Jul 2023 07:42:29 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C373035B5; Fri, 14 Jul 2023 04:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=At0xbxSbJqBndkT5E1gEuaNWyCKn9gXZSodJ0QJAaUU=; b=U/kh/Ou3OtrX/gDcuCTa0TVUAj q/Bn8DYekaFfX+QF/LXcgW/R5Eq0/Ei0Om4xQT4kyPRzDvkJBQR+9Fkv6jCaHwar9LfU9KsWnVmSg H0ORBcooY1DbZEbAFWBMiUpmQZJcXO4b2rbX0Wf0clMizYQKpi6QcrlpbkU2k+8mI1gyZkvugmrOC OjeJ5xW2QJ3lk8aT7sONIxN/32KiRhELtgjrdUtrTx2zn+xiUADlZAUsJsv1QB+sQ2x5+FwHrcSh0 O2325oH4m2JFslo4vhPNNYqUjPKb588vY/cNd6isGP1ISq/yFn+1WIDDmF06Of5rTi5EEKNEQCefp rQD4VunA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57218) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qKHBI-0000cr-2y; Fri, 14 Jul 2023 12:41:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qKHBI-0007CK-Io; Fri, 14 Jul 2023 12:41:52 +0100 Date: Fri, 14 Jul 2023 12:41:52 +0100 From: "Russell King (Oracle)" To: Luo Jie Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] net: phy: at803x: add qca8081 fifo reset on the link changed Message-ID: References: <20230714063136.21368-1-quic_luoj@quicinc.com> <20230714063136.21368-7-quic_luoj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714063136.21368-7-quic_luoj@quicinc.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 02:31:36PM +0800, Luo Jie wrote: > The qca8081 sgmii fifo needs to be reset on link down and > released on the link up in case of any abnormal issue > such as the packet blocked on the PHY. > > Signed-off-by: Luo Jie > Reviewed-by: Andrew Lunn Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!