Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a5ed2266138cc61cbe27577424bb53cda72378d.camel@xry111.site>
Subject: Re: [PATCH v16 05/30] LoongArch: KVM: Add vcpu related header files
From:   Xi Ruoyao <xry111@xry111.site>
To:     WANG Xuerui <kernel@xen0n.name>, bibo mao <maobibo@loongson.cn>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        loongarch@lists.linux.dev, Jens Axboe <axboe@kernel.dk>,
        Mark Brown <broonie@kernel.org>,
        Oliver Upton <oliver.upton@linux.dev>, hejinyang@loongson.cn,
        Tianrui Zhao <zhaotianrui@loongson.cn>
Date:   Fri, 14 Jul 2023 20:06:20 +0800
In-Reply-To: <d58a20c9-1f52-c398-292b-2d2501a302e6@xen0n.name>
References: <20230629075538.4063701-1-zhaotianrui@loongson.cn>
         <20230629075538.4063701-6-zhaotianrui@loongson.cn>
         <CAAhV-H7P_GSsoo+g5o0BTCzK4fxwH5d2dQOYde-VpcGvn4SXQA@mail.gmail.com>
         <152f7869-d591-0134-cf9d-b55774a135e8@loongson.cn>
         <CAAhV-H4N2wdB8n7Pindv9WdVPLPOboK0Ys75SWOkMZU+=NWEbQ@mail.gmail.com>
         <152fbdd1-a21c-8ee1-d386-ec7f80b0bb97@loongson.cn>
         <d58a20c9-1f52-c398-292b-2d2501a302e6@xen0n.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-07-14 at 18:16 +0800, WANG Xuerui wrote:
> > > > > As all needed instructions have already upstream in binutils now =
and
> > > > > binutils 2.41 will be released soon, I suggest again to introduce
> > > > > AS_HAS_LVZ_EXTENSION and make KVM depend on AS_HAS_LVZ_EXTENSION.
> > > > It is a good news that binutils 2.41 has supported LVZ assemble lan=
guage.
> > > > we will add AS_HAS_LVZ_EXTENSION support, however KVM need not depe=
nd on
> > > > AS_HAS_LVZ_EXTENSION since bintuils 2.41 is not popularly used. yea=
p we
> > > > need write beautiful code, also we should write code with pratical =
usage.

I've raised this for a very early version of this series, but Paolo
decided using .word here should be fine:

https://lore.kernel.org/all/87268dce-1b5d-0556-7e65-2a75a7893cd1@redhat.com=
/

So in this case we should respect the decision of the KVM reviewer.  If
this breaks Clang build, we should improve Clang to support using .word
for hard coding an opcode.

Frankly I'm quite frustrated by "a new architecture needs so many
feature tests and hacks, here and there" and sometimes I just want to go
laid-up in bed instead of writing code or porting the distro (Linux From
Scratch).  But today I just got [a board from another Chinese vendor
targeting another new architecture] and to me they are doing things even
worse...  So maybe we are facing some inherent "no silver bullet
engineering issue".

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University