Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2377820rwp; Fri, 14 Jul 2023 05:25:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlGBb4YB8AUedjUt5Ey+MD4yG47iBrAmRuwpRyZQgLIi9RviH1kGRx7OBM1EpWB88udinw1h X-Received: by 2002:a17:902:c40c:b0:1b8:862:74ee with SMTP id k12-20020a170902c40c00b001b8086274eemr5039733plk.11.1689337551096; Fri, 14 Jul 2023 05:25:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689337551; cv=none; d=google.com; s=arc-20160816; b=1BAVLLgn4GesSm9XEIU0+VXG9BamzivmXOCmii1AtJrInhonrHgGVBSOr9PkYU2/07 FcJWVmnfnXICMWDC4B6JqWBRhtJi2aqKzqLDrS7iYuEeKT7HZyabBHEU0QII/vgm1uUQ vMb/myQnw7XOn6Rrg3VfE4zsR/OWZyew1PnscoE6tPik2dcD+k816jqionQGSl/sRsxL NVDYhwLC/DFr5oOEbXoMWhQadiKiLLgc6JYa9At0zlC3m1wHZgrKXej+jswoh6vJAiwG v8LpDW3voxNT4n3OC3zE/G3Gt3fnt+zWFNrV3XJV43AlqeuykTfDneWo+Ve0OlF4bhDz Xbfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DmeN79exEsvAJkYJDMMvtjBsg+ueHrWKD/Uu8Yhd95s=; fh=nF8GdUnhV/As8KkzAnJFc/yWigxNkdCATns/wtbOFxc=; b=hpC9zAsufn8Ft/fM5hiMl5xsBn9Xnhxm7TMuqozuaM+t3o4F7l75f/7wkv/4zK7rGC YvO/o754BLsoNQfBcE66y1DOAy/lKTELyMbm+75emMI1IYBUaejAyAg6iBi9HIFkYQcP L4jcgpFW2Ycv7mPNzLig81Nc+MXmCxKjdU/vqWSBwV8+MswwFLeGZMdD39vixS9NW6aJ crPJpW734lGqXXToP+bQdFdJkZjf6adD+h9Ip9ASe9udrTCcZZgliS53VE2WY27Mj1x/ lB33uB0iRA38qGOdIOiasl69ag7hd83NjYGrj03pI71Srx7krgH8N0OfObSDdjhNyKj8 X/5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZFgr2mIb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a170903234800b001b569049666si7570809plh.617.2023.07.14.05.25.39; Fri, 14 Jul 2023 05:25:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZFgr2mIb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234638AbjGNLwR (ORCPT + 99 others); Fri, 14 Jul 2023 07:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235666AbjGNLwM (ORCPT ); Fri, 14 Jul 2023 07:52:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8FA30CB; Fri, 14 Jul 2023 04:52:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F3BE61C01; Fri, 14 Jul 2023 11:52:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A81EC433C8; Fri, 14 Jul 2023 11:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689335530; bh=DmeN79exEsvAJkYJDMMvtjBsg+ueHrWKD/Uu8Yhd95s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZFgr2mIbpn5LNqHS9h3NzsCoyBKi3V2KXEm12VaSFzsIAt/Ou+NJQaiJDjs5qJGNj qD3XdXf3qAflXE6sVsXlVfbCVQoJf2N/fMyyM3oKy5EVlC9+bMcMnEVUcsJYelbk0R TcDR3gTCvxKdaC4oeXurBvlb3DCosJKfgSSW0M6vyJNO+9ZAVCPxStVKFHpnGLumJG JdaVa4AVGlF8AXCs1TjqoJOGbeDmfTjEKPw6/Vod1glWLKb13LWtxAlLP09uWoJ+Rn Dtj7SAvA0tJq9OFY6FX7xexEI+g0gKFLh4PirN/RNhi765CFK223rdSxLo8B1g1NOG PRVe4do9xGLHw== Date: Fri, 14 Jul 2023 12:52:04 +0100 From: Mark Brown To: William Qiu Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Linus Walleij Subject: Re: [PATCH v2 2/3] dt-bindings: spi: constrain minItems of clocks and clock-names Message-ID: <9891a7e3-0fce-4d05-8ead-3c0ed155d725@sirena.org.uk> References: <20230713090015.127541-1-william.qiu@starfivetech.com> <20230713090015.127541-3-william.qiu@starfivetech.com> <20230713145724.GA3975811-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="klm57L7u8qYMNEjf" Content-Disposition: inline In-Reply-To: X-Cookie: Preserve the old, but know the new. X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --klm57L7u8qYMNEjf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 03:14:59PM +0800, William Qiu wrote: > On 2023/7/13 22:57, Rob Herring wrote: > > I suspect that PCLK and SSPCLK are tied to the same clock source. There= =20 > > must be an SSPCLK because that is the one used to clock the SPI bus and= =20 > > we need to know the frequency of it. > After communicating with colleagues in SoC FE, I learned that PCLK and > SSPCLK were homologous on JH7110. He said that SSPCLK would divide the > frequency internally anyway, and there was no need for external part freq= uency, > so he directly gave them together. > So, should I call this clock ssp_apb or keep it SSPCLK? I'd expect this to be handled in the DTS for the SoC - connect both clocks the binding requires to whatever the upstream clock is, it's not clear to me that any binding change is required. --klm57L7u8qYMNEjf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSxNuQACgkQJNaLcl1U h9BFZgf9HdG+QzvFSo2OFGvw81HEFNCptH1B6hNOBEplLpmTioP2hTn7SE22nAoP M8yy78/dMrerUMSs8l8nTWX2MvtyEhMPWrYi3vUyQhzDz1vPAj2ao4V/5zBD2P/s xQ00phl+51kJqZ+YX5WXydz9G5EP+usoFq2i2R9ZNPgCm9Y9txRr3+CVOXQOBixW dOFZYO+/6jfEoEOZyL1Ine5ggi4tD5Q9Q8zLMhS47XKv3me71twVFVxatUate6Cu gg8tpmFVCiR63fSnrgbRunZjF7R2Ogfg3M7Pg5AUSiJjbMMPAnTKcZrIRM9q11sg hZ+IpYQkDLUbk5g9cJlhw+cy1Y2egw== =1P4J -----END PGP SIGNATURE----- --klm57L7u8qYMNEjf--