Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230714015238.47931-1-ajd@linux.ibm.com>
In-Reply-To: <20230714015238.47931-1-ajd@linux.ibm.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Fri, 14 Jul 2023 14:09:39 +0200
Message-ID: <CAG_fn=WLot3UecUrbTQKRrx-QNskuTiBwQr8RbtesbGYkK4wLA@mail.gmail.com>
Subject: Re: [PATCH] lib/test_meminit: Allocate pages up to order MAX_ORDER
To:     Andrew Donnellan <ajd@linux.ibm.com>
Cc:     akpm@linux-foundation.org, xkernel.wang@foxmail.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 14, 2023 at 3:53=E2=80=AFAM Andrew Donnellan <ajd@linux.ibm.com=
> wrote:
>
> test_pages() tests the page allocator by calling alloc_pages() with
> different orders up to order 10.
>
> However, different architectures and platforms support different maximum
> contiguous allocation sizes. The default maximum allocation order
> (MAX_ORDER) is 10, but architectures can use CONFIG_ARCH_FORCE_MAX_ORDER
> to override this. On platforms where this is less than 10, test_meminit()
> will blow up with a WARN(). This is expected, so let's not do that.
>
> Replace the hardcoded "10" with the MAX_ORDER macro so that we test
> allocations up to the expected platform limit.
>
> Fixes: 5015a300a522 ("lib: introduce test_meminit module")
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
Reviewed-by: Alexander Potapenko <glider@google.com>