Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <574a6b44-38bf-85ce-1dd0-2414fa389c48@suse.com>
Date:   Fri, 14 Jul 2023 15:28:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 04/10] x86/tdx: Make macros of TDCALLs consistent with the
 spec
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, peterz@infradead.org,
        kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org
Cc:     dave.hansen@intel.com, tglx@linutronix.de, bp@alien8.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org, seanjc@google.com,
        pbonzini@redhat.com, kvm@vger.kernel.org, isaku.yamahata@intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
References: <cover.1689151537.git.kai.huang@intel.com>
 <ba4b4ff1fe77ca76cca370b2fd4aa57a2d23c86d.1689151537.git.kai.huang@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <ba4b4ff1fe77ca76cca370b2fd4aa57a2d23c86d.1689151537.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tzhud3Q0U0FBaUVud00yMDZFNWJOWnJJTlhkeDFTOHlyUzcvT1RDekx5Qk0z?=
 =?utf-8?B?UDRDaVpWR2RZUUIwMVMzTVF3R0F6Z1kxQk5vSStRQWUreDh4a1B4NURvblRt?=
 =?utf-8?B?bi81aEljRmxnK0hzSXJieFVlcG1qcEtheVYrTDdxRUhWeWFqUHVUSnFDTzlM?=
 =?utf-8?B?VlN6MnFxMlhMcUI4NmZVcWxTVlJXanFMampiMllqb0I3TTRXSE1WVTExemcr?=
 =?utf-8?B?TmFCUnZsM1pISndZQVBWaFVVQ2xDK2doZ240VkNsdTFRa3FoejFzdHJ6dGpH?=
 =?utf-8?B?YWh1WGowcFVMWDhsYlNLejZqTWVhTWtjQ0lYRFlLYlJKVDJ3SGRXNWVXSC8x?=
 =?utf-8?B?OCtCVHdsSW5URXhOR21PQXJQVHMyd2RSdnIvaFlxdzNHWlBBUXJ2YXBsUGl6?=
 =?utf-8?B?RjNFU3NMRUx1emIzVHNXQ1FLOTIybFY1dTB6YTZSYXlsNHF2YmRTa3BwREtH?=
 =?utf-8?B?MTNKaW9EMldKYXMxRm5WQnJobkFNd2RXUGovRWY1MGlXc3IvSkJ5VmttNG5I?=
 =?utf-8?B?RzZSci9BdllpS1pXM2VkSTNlNzJMNjllUjFXSlA0V0M1ZFFnMk5STndaRm1v?=
 =?utf-8?B?V1lxeGlTYXBvOHlmWGJzYXpvOWIwOTN1MkNscXZrSlRUWkY5QUVmbXRzYnFv?=
 =?utf-8?B?VUVwSzltZTdDQTlqeTFUK3Q4SHpvRnlTTHN6ajJLTk1GVTVmRThnRG5icUky?=
 =?utf-8?B?cTVmeko3bk42U21PalpXZjAyMXpnVzF0TFJoUWoxbkxRLytDSW1JUFFTank3?=
 =?utf-8?B?blh5MEZxWFY3L01FQ3c2eTdoK3Vpc2ZaRjRkYWxMalVrcTlXaXBaZlFveUk1?=
 =?utf-8?B?bGtPUUt2a0paeFBGNFU4MGp4UWZSeW1JanJVc0Q3ckJHaVdhN21CUjVBeFdV?=
 =?utf-8?B?YnRudjZJbzZvbEo0NkozZUZ4cTB5WnZMcDZTdVVLZEx1WVpRTlZFNmgzcU5B?=
 =?utf-8?B?amlLMy9Wc0U5c3YvMzh1NzkrREJ1Q1VsSlhDT3prbkVYSWV5M0FKZ3BULyt3?=
 =?utf-8?B?ODJwb0YzR3JCN3JYUUtjY0dkQVova09Qd0hXNTZaU0F0ZnJvM3VyMjR0Q1Fk?=
 =?utf-8?B?cGxENUxpVWdPQWZTT05WNlg4YW9JanU4OXlSQURpWTlCZWpzMDFOOTVzNWx3?=
 =?utf-8?B?UC9OZDN2aEsrQlpuTnZheXJaYy81SjEyVkxicWxiRjhua3o1RUE2emNUVEI2?=
 =?utf-8?B?YUJ6S3RzaXJIWkpES29obUFYWnhUT3M1K28yVnBIV1NTR0p2SkUrd09QaU44?=
 =?utf-8?B?ZURyczNaRy9HMWswRVdyMyt6YUZyRFNyMTB0b0s5b0tYNlo4TGdxY2syaDNB?=
 =?utf-8?B?eEpJK2dKMUllaE0rUmxjdHFJOHlaeXVjTGhtVDdUWlNCZ0lCcUVsVnBWM1l0?=
 =?utf-8?B?RFp3T3U3QkZXQnlFZGoxQnQ1VFlHMXVETk4veWJhbkc0YktuOGIxMnNGeWhm?=
 =?utf-8?B?VFpMcVJCbHA0NHBtN2crMnJFMEdZZndsbExvdVdVS1VuWkhLVGJyL2VPbGl3?=
 =?utf-8?B?RWRTc2lGeVN6dng5ZjVvZmVzMFU3QUFkTnY2RkhCWWhvZ2RQM29uOXBIVVU5?=
 =?utf-8?B?cDl4cXQrdzdLUU00SUNha0oxNmVrNjNNY0lsSHlTL1g1dlQ0RFFMZUVkWFBE?=
 =?utf-8?B?ZGlhZDcxNkZablplZDN3enRkbkdiSzlLZGF6VmdyZ1JGNWRFSWhoYm5sZDgw?=
 =?utf-8?B?Nmo5NFVpczFZRGY1RFRMc3Zzd080OGFkUjhnaGVRR2o3NVllQ2k0MDVhMTdI?=
 =?utf-8?B?NENvQlF4Wm9tNXQwdEdXWGVCaGdIK3l3L3dzT1I2S3RPcXFBV3FveWs3Z3Vs?=
 =?utf-8?B?YTlvZitralVIK2RUNFNIYk00cmdwQitzYlNmblBnYUliUytNaExGZVRiREJI?=
 =?utf-8?B?RzBMNFhrNVdoYWxNc2Q5b2RPZTNRdnNmbVJzRGJZWE1Mc0VXbTZ3a2wzS1Nu?=
 =?utf-8?B?d1h1cFdKb09OUE16MU8way9uTHZVMnJVdGhpSGNzT2pIQW1qOTN2ZU9TRkEr?=
 =?utf-8?B?YlVtdllLaDl5Rm5ORkhTNzlVNzN1Z3dkZzFJYzdLak41RmxjbUVRNUVoak1r?=
 =?utf-8?B?ZzhEMlpCcGtDZ1FSMTRPVnlyYzNZVlN3Q24wb0lyckFDSDVEYlB6QlljdjJO?=
 =?utf-8?B?NHd2bzFsbklyeWhhK0NwcW5VVFhhZW1EMllva1h5RFN4MUYrdmluNm9JTitV?=
 =?utf-8?Q?M/rd+E7V8203j3S4CYBih/SdN3+X/6hTD209ocOuTZ4r?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b10b629f-45bf-46b9-3d95-08db8465de6e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 12:28:46.3189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G6tEBXe+4gK+2hT5ydzPdzYbcuoVKMCjx8PJ/XEn2IDrqvJkVNjVwSOTF8iIvqDnOtmjmEcTs+UI3o9r+vguFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9065
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12.07.23 г. 11:55 ч., Kai Huang wrote:
> The TDX spec names all TDCALLs with prefix "TDG".  Currently, the kernel
> doesn't follow such convention for the macros of those TDCALLs but uses
> prefix "TDX_" for all of them.  Although it's arguable whether the TDX
> spec names those TDCALLs properly, it's better for the kernel to follow
> the spec when naming those macros.
> 
> Change all macros of TDCALLs to make them consistent with the spec.  As
> a bonus, they get distinguished easily from the host-side SEAMCALLs,
> which all have prefix "TDH".
> 
> No functional change intended.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
>   arch/x86/coco/tdx/tdx.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index 5b8056f6c83f..de021df92009 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -15,11 +15,11 @@
>   #include <asm/pgtable.h>
>   
>   /* TDX module Call Leaf IDs */
> -#define TDX_GET_INFO			1
> -#define TDX_GET_VEINFO			3
> -#define TDX_GET_REPORT			4
> -#define TDX_ACCEPT_PAGE			6
> -#define TDX_WR				8
> +#define TDG_VP_INFO			1
> +#define TDG_VP_VEINFO_GET		3
> +#define TDG_MR_REPORT			4
> +#define TDG_MEM_PAGE_ACCEPT		6
> +#define TDG_VM_WR			8
>   
What branch is this patch set based off? Because the existing TDX_GET_* 
defines are in arch/x86/include/asm/shared/tdx.h due to ff40b5769a50f ?


<snip>