Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c9ab901161e8c1cc552e8486a847296ce3662be2.camel@gmail.com>
Subject: Re: [PATCH v2] Revert "usb: dwc3: core: Enable AutoRetry feature in
 the controller"
From:   Jakub =?iso-8859-2?Q?Van=ECk?= <linuxtardis@gmail.com>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Mauro Ribeiro <mauro.ribeiro@hardkernel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date:   Fri, 14 Jul 2023 14:28:15 +0200
In-Reply-To: <20230714003032.qcl7jnnm2ou34ucy@synopsys.com>
References: <20230712224037.24948-1-linuxtardis@gmail.com>
         <20230712225518.2smu7wse6djc7l5o@synopsys.com>
         <aad3936c41c6520f6863a859eb4c4cdb5fdc0549.camel@gmail.com>
         <20230714003032.qcl7jnnm2ou34ucy@synopsys.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Thinh,

On Fri, 2023-07-14 at 00:30 +0000, Thinh Nguyen wrote:
> On Thu, Jul 13, 2023, Jakub Van=C4=9Bk wrote:
> > Hi Thinh,
> >=20
> > On Wed, 2023-07-12 at 22:55 +0000, Thinh Nguyen wrote:
> > > On Thu, Jul 13, 2023, Jakub Vanek wrote:
> > > > This reverts commit b138e23d3dff90c0494925b4c1874227b81bddf7.
> > > >=20
> > > > AutoRetry has been found to cause some issues. This feature
> > > > allows
> > > > the controller in host mode (further referred to as the xHC) to
> > > > send
> > > > non-terminating/burst retry ACKs (Retry=3D1 and Nump!=3D0) instead
> > > > of
> > > > terminating retry ACKs (Retry=3D1 and Nump=3D0) to devices when
> > > > a transaction error occurs.
> > > >=20
> > > > Unfortunately, some USB devices fail to retry transactions when
> > > > the xHC sends them a burst retry ACK. When this happens, the
> > > > xHC
> > >=20
> > > For some clarity: if the device continues to respond with CRC
> > > error,
> > > the xHC will not complete endpoint related commands while it
> > > keeps
> > > autoretry.
> >=20
> > Acknowledged. Do you think it it would be better to respin this
> > patch
> > once more to include this in the changelog?
> >=20
>=20
> It'll be better to provide more detail. However, I'm fine whether you
> want to send v3 with this or not.

The urge to scratch the itch was too strong :D I have sent a v3 in
https://lore.kernel.org/linux-usb/20230714122419.27741-1-linuxtardis@gmail.=
com/
with an updated changelog.

>=20
> Thanks,
> Thinh

Thanks,
Jakub