Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2460970rwp; Fri, 14 Jul 2023 06:36:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlFfmZ16Maw1LqPaX1F1O/lgOE/I69IpHDTtwlbqSVrN6qS4JmJrAO5EDlQAdhR9JQmt0rlc X-Received: by 2002:a05:6402:503:b0:518:721e:f594 with SMTP id m3-20020a056402050300b00518721ef594mr4667178edv.37.1689341798980; Fri, 14 Jul 2023 06:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689341798; cv=none; d=google.com; s=arc-20160816; b=jTxoZYsewCI7Bbd/ZFPLn18mQgaAYJkafoTLKDLeV7h4SQqTeUIGMTdAb7jcCUWJpl UIt5lS3Q7NKYRCsBm289ZwkWUv+PkouMrVw2d1AwT+11QA4Qk/0HEKsBMXZ1MmxYAikE pCN52n7RFDIJetDdvmmVHuxIC/7XiphdNkBEXd3NtlV/6HvwyY7MYQZJWdgABmdk/8cT AuVqGT7/U01KFY74Z17iEVws+BjohGxSDXVdLJ/xBQFR0c9rGH4f4NkR4xAN6FdRX7wp PWh4NHFDya41MrP3SzcJ471Hc1V3j2Xs903DEFSXa+V88kot7lbAr8WcP0+FtyfsSP/F Xa8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kY9kWgPRsbUG2PwMOsb8zyln8FszRPF2CwtQS5KEw50=; fh=uXzM6f2ruIIbdVB0rFa/N3lgVEoJPam3nUA0Zu4F+0s=; b=V3cT6Si9oueX6w0r7pUho2tQVgXSCKRwjf9uIfAFIHhGoAsoSmCY76iM4Y1ytmkhy9 o5Sje6j/E+pXHI6wTM53Nd6xciRqeiIJz3ZEcaktfpduTu/fA9/wm0WHcSZaauATvWYf k5YCgaIthtIYMeUSY/caCH0By7XzVQ1Qrex2tRg5KO565f8i6lEwg0rNvq9eQPWke6kg bG4C8nUSjIU2ey5Bi9wjAmsqrpdMbFkYAO9XLE2WdkqbMXEj8jQspfRwP+poz0qtMfRb V7YmEhxxAynboT5qHBeIXz7N1Y8aAi1T21ewEEoPxWJa+sHawdS4JvJx+2nAthYirVuV B/Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZBNqoO45; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m19-20020aa7c493000000b0051e05cd617fsi9661306edq.39.2023.07.14.06.36.14; Fri, 14 Jul 2023 06:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZBNqoO45; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235366AbjGNNRA (ORCPT + 99 others); Fri, 14 Jul 2023 09:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233638AbjGNNQ7 (ORCPT ); Fri, 14 Jul 2023 09:16:59 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACAAF30DE; Fri, 14 Jul 2023 06:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kY9kWgPRsbUG2PwMOsb8zyln8FszRPF2CwtQS5KEw50=; b=ZBNqoO4508QGdlm4xwIwriY4I+ yBv9AnZXqMeuoerpvlqk7FfUni3J/C21vKpvgbytPD8aIKyqFa5kL9kpf7SV0hzEy8H7e886FAbS5 +R53T+aPb+b4zOhLrkM5y6cqWUQ6ZZvaSI5EWcYho+r2LYbm1wMRJ75+AbPr2EHpYZUY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qKIey-001M4n-DH; Fri, 14 Jul 2023 15:16:36 +0200 Date: Fri, 14 Jul 2023 15:16:36 +0200 From: Andrew Lunn To: Luo Jie Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] net: phy: at803x: enable qca8081 slave seed conditionally Message-ID: References: <20230714063136.21368-1-quic_luoj@quicinc.com> <20230714063136.21368-4-quic_luoj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714063136.21368-4-quic_luoj@quicinc.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 02:31:33PM +0800, Luo Jie wrote: > qca8081 is the single port PHY, the slave prefer mode is used > by default. > > if the phy master perfer mode is configured, the slave seed > configuration should not be enabled, since the slave seed > enablement ignores the master/slave perfer configuration, > which is not expected. > > disable slave seed if the master mode is preferred. > > Signed-off-by: Luo Jie Reviewed-by: Andrew Lunn Andrew