Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 14:46:27 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kevin Lu <luminlong@139.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        kevin-lu@ti.com, shenghao-ding@ti.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: tas2505: Add tas2505 driver
Message-ID: <9358b427-faa7-48be-b386-bf1287906873@sirena.org.uk>
References: <20230712044321.48530-1-luminlong@139.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fkB7w4zBomSv3qDK"
Content-Disposition: inline
In-Reply-To: <20230712044321.48530-1-luminlong@139.com>
Precedence: bulk


--fkB7w4zBomSv3qDK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 12, 2023 at 12:43:21PM +0800, Kevin Lu wrote:

> +	val = (ucontrol->value.integer.value[0] & 0x7f);
> +	val = mc->invert ? mc->max - val : val;
> +	val = (val < 0) ? 0 : val;

Please write normal if statements, it helps with legibility.

> +	.num_reg_defaults = ARRAY_SIZE(tas2505_reg_defaults),
> +	.cache_type = REGCACHE_RBTREE,

Please use REGCACHE_MAPLE for new devices where you'd otherwise have
used RBTREE unless there's a particular reason - it's more modern.

--fkB7w4zBomSv3qDK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSxUbIACgkQJNaLcl1U
h9Bm9Af/Vmv/c7d6mMKNRJ+Kq/VFegwM1YkIGeForVA0+QYnx52ji0YoqOW82WHH
ULAUcg7xy7NcVbJCwUbOEYC5O9ZgxG1pnzYiu1vFJa5Z0i8wF/HkmR577K2qPrjY
44bFdOHrE9dTB4XiRK1Bxe8Q67oylR2z45qnt2nqrCCLdnJgDqwVrSgaDelNBWM4
KUBWI7rNee8Iy+CPGMA77stRPX/mNeeRNAYKmofnu8HZ677SpglczskoSDBMyC8m
MTeuSk5I58N8pWyAufMROBrNuQiN5FL7NPIKQ2K9OO7n7Im3InF7+wxv2PkjKvcI
hb6qU4y1IYxjA/CT50+lkLemlGum1w==
=4jrU
-----END PGP SIGNATURE-----

--fkB7w4zBomSv3qDK--