Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1511443-c220-1012-c6b3-595285ec338c@intel.com>
Date:   Fri, 14 Jul 2023 16:17:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [Intel-wired-lan] [PATCH RFC net-next v4 1/9] net: intel:
 introduce Intel Ethernet common library
Content-Language: en-US
To:     Alexander Lobakin <aleksander.lobakin@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        <netdev@vger.kernel.org>, Alexander Duyck <alexanderduyck@fb.com>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        "David Christensen" <drc@linux.vnet.ibm.com>
References: <20230705155551.1317583-1-aleksander.lobakin@intel.com>
 <20230705155551.1317583-2-aleksander.lobakin@intel.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20230705155551.1317583-2-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OS9sYUZVanVGUXlibDhXUXpaVUFobkRML0RvM2kzREp0RHVFR3BzcHFKRk5Q?=
 =?utf-8?B?eUthWktrT1NiZ2RjaEROMXdaYU9KL2ZSSTNIQmw1aDVmNkovMzFXMzVoSWs3?=
 =?utf-8?B?TFMrbG9PaEhDUmhCd2piQmwxYkpPckpzbzZVTUdwd1VOQlA1QWoxUTlocy9r?=
 =?utf-8?B?MlNSaFJvb2ZYOVRpOWZLNGRpa0FBOWJpSjF0blJyUHh6VFBoZmx4d1oyZmky?=
 =?utf-8?B?QTNzR1pVVWEvREh2VHUvdHZ4ZWhMNmFMUUR6ZXMzM214VFdvSzFqZHVYWS9N?=
 =?utf-8?B?MUJjNWhaRVgzT0RucmZrc1FpWWhSSHd3MWpkV1JqOERFYXNWcVlyQjZzU1Vj?=
 =?utf-8?B?TGNCMDR0eERSYVZBYzdvMzZlZWhmbDlRNjBpbUhvREpkcE5rV1BaazZsUnhT?=
 =?utf-8?B?aVJYQWh5VXIrWDVnTWowN2lMWklLNzBNbGJoS1VXQmpMOEl6N0RaWkErSCtP?=
 =?utf-8?B?MC9TUjVWaXlRbXE2bWpjeEdNbkYwaG9aRW5saDhDVEp1UjNzVG4yV1BPa2hG?=
 =?utf-8?B?NjhYR0lpMVhUejZrSjk0c1ZwaGdUbkh4NlRSN2RoSFdLTTRrSFExSnNEenhQ?=
 =?utf-8?B?Yk9vZUllOXpwbVR5S2dCOEVjSDVtc3VDRXhuVXl6M0syalptMU9FUk83Vk9E?=
 =?utf-8?B?eFNFanZPU3NKRm9mdjVVejhhYWlCbmdESi9lMTRGTWxzVEZnZGxhVG5ZMkJw?=
 =?utf-8?B?TjdoY3VDdFo0bHpXeWl6VDZyOFRUdW9sMHFoQXZsSlExdTBGakQxYm1GRVlm?=
 =?utf-8?B?VWptaFY5ZkRjL3U2aDd3ZVRmS2RBbXlBbktTWVdFeW1sajAzbzY2eTY1L2tX?=
 =?utf-8?B?SHFWVkxHMURZTWgvcmFra3NYSUFuSVh6eU8wZ2RONEdYaUFPTkJJUHpRQjNR?=
 =?utf-8?B?M0IwY1pTMlBCK1ljMEhjUVJGQzB4VmZoWHRSNm5QbitKWDF5dFZOQzlYSHRW?=
 =?utf-8?B?SzFDbGlVU2RwOTVZNUVPU0RMWmtsaGpXTlp5M0pLblA3alBua2NRb0wyMUdC?=
 =?utf-8?B?bWcyaXErNDMxVUdReXgyS2Y5SlNGQmU3Y3lqTnZ3WGZUVzhXWmdhWXJ0dE5w?=
 =?utf-8?B?Zkgva0IxcGZpVUZXTTJudGU0RyswQXFuRWI4RkxMWDljeHhoRURyVTBkWlFN?=
 =?utf-8?B?TzkwSEdyM3ZRVlk2UHBTanpOL1BNSUtZWElvU085R0U0TnBwdnNSUlgxV2Jy?=
 =?utf-8?B?bDhYUlpLNUUxcXJDYVRwNGdodFZ6Z1F3Wkk0YlQ2SDA1QlFtTDdMcEhuYmtm?=
 =?utf-8?B?RUhkVFYraTlmc3c2bVdubno0d2pqUWlwS2FKZlZJRGppdjJXd2tzV2FMd3Bl?=
 =?utf-8?B?K3hMYlRKUXZEVDVnb3FOVDZhSlZSYkJrWEpPOTVlUG16SnJjM1dpdWtQMk0r?=
 =?utf-8?B?YlJHWGJ5blpVQTBWOHV5VDdRdGM2NzVXaklMTUFtNlFpZ2N2dzU2a2tHNlIz?=
 =?utf-8?B?cTE4aDRyc2JNMzhpbEY5VVlhQ2RXeG5mclpYYjJnUG9COGVTTForVStxMkxz?=
 =?utf-8?B?VDNrK2ZPUytLNnh2NFZ4QWNyaVk2Rjh1eHQzcDBCM1BNejJjcFhqWXczTVBj?=
 =?utf-8?B?OWVZZHFlSWFjNkhmK3YwYUtwcEg4SDBvOTlQTWxJcXZqUnE5VFVYbzA5SDRv?=
 =?utf-8?B?ZWlwMlFhVWhYOUsyZmFSOFJ5akNZeDZsVTN5TFBUbzZtelgzdFd1NmpqVFBZ?=
 =?utf-8?B?cERaenFieXQ0YWQ1OTNMMWhUUHJSVmtPZWVKcCtQWE5ZZ1lQMmlZUTlMQ2x3?=
 =?utf-8?B?VVJHenpaSXMvblhvbHorTjZYZ21kR0o4bUtzNm9JQWFpRTZ2Y1psOWEvdXJE?=
 =?utf-8?B?RUFQL3BhaFJ3RFhLOUs3VjcvZHN4V2k3Z00rMlRKTE1xZWpUL3BkVVBxS00w?=
 =?utf-8?B?OHJPVVh2bWsvVDJFUUlKY1VxWGxHQlFTemVSK0M0bHhDTzU3Lzl1MzVxLzgr?=
 =?utf-8?B?SzI1RWhydkFIaS85ZG1jZ1dwS3BsWXZRS0VhN05heEVnZEV0MnJ6aGR4VFRh?=
 =?utf-8?B?U0t3UlY0V0hwWkJBaEU0K3RuTHFobXIyZjJueUdlYW0wNlFpbEVQSnlFUWFS?=
 =?utf-8?B?b28rTjlDSmRNaEFTSSs3UnlIVEhIaWlTUW9qRXNYQ1MrUzNPL3BkSzM2OUlX?=
 =?utf-8?B?N0J5NUh0OWJDUXhKa3NKenNGTmpaTEx2OEFQREcwRE9zK2hMc1BSVnZnMDhS?=
 =?utf-8?B?MUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 32d70035-a835-456c-cb45-08db847525e8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 14:18:08.9676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5n9eS4MswLbKRDczEnFE9/uPdQY4LCkeH80wti2WwXn7K/93mtuKJeS/ncqqi/xZoJC3AnOuIOZnTL2l2uH5R2hl0UDzbUVNMqebjlBSNco=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8082
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/23 17:55, Alexander Lobakin wrote:
> Not a secret there's a ton of code duplication between two and more Intel
> ethernet modules.
> Before introducing new changes, which would need to be copied over again,
> start decoupling the already existing duplicate functionality into a new
> module, which will be shared between several Intel Ethernet drivers.
> Add the lookup table which converts 8/10-bit hardware packet type into
> a parsed bitfield structure for easy checking packet format parameters,
> such as payload level, IP version, etc. This is currently used by i40e,
> ice and iavf and it's all the same in all three drivers.
> The only difference introduced in this implementation is that instead of
> defining a 256 (or 1024 in case of ice) element array, add unlikely()
> condition to limit the input to 154 (current maximum non-reserved packet
> type). There's no reason to waste 600 (or even 3600) bytes only to not
> hurt very unlikely exception packets.
> The hash computation function now takes payload level directly as a
> pkt_hash_type. There's a couple cases when non-IP ptypes are marked as
> L3 payload and in the previous versions their hash level would be 2, not
> 3. But skb_set_hash() only sees difference between L4 and non-L4, thus
> this won't change anything at all.
> The module is behind the hidden Kconfig symbol, which the drivers will
> select when needed. The exports are behind 'LIBIE' namespace to limit
> the scope of the functions.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
>   MAINTAINERS                                   |   3 +-
>   drivers/net/ethernet/intel/Kconfig            |  10 +
>   drivers/net/ethernet/intel/Makefile           |   1 +
>   drivers/net/ethernet/intel/i40e/i40e_common.c | 253 --------------
>   drivers/net/ethernet/intel/i40e/i40e_main.c   |   1 +
>   .../net/ethernet/intel/i40e/i40e_prototype.h  |   7 -
>   drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  74 +---
>   drivers/net/ethernet/intel/i40e/i40e_type.h   |  88 -----
>   drivers/net/ethernet/intel/iavf/iavf_common.c | 253 --------------
>   drivers/net/ethernet/intel/iavf/iavf_main.c   |   1 +
>   .../net/ethernet/intel/iavf/iavf_prototype.h  |   7 -
>   drivers/net/ethernet/intel/iavf/iavf_txrx.c   |  70 +---
>   drivers/net/ethernet/intel/iavf/iavf_type.h   |  88 -----
>   .../net/ethernet/intel/ice/ice_lan_tx_rx.h    | 316 ------------------
>   drivers/net/ethernet/intel/ice/ice_main.c     |   1 +
>   drivers/net/ethernet/intel/ice/ice_txrx_lib.c |  74 +---
>   drivers/net/ethernet/intel/libie/Makefile     |   6 +
>   drivers/net/ethernet/intel/libie/rx.c         | 110 ++++++
>   include/linux/net/intel/libie/rx.h            | 128 +++++++
>   19 files changed, 312 insertions(+), 1179 deletions(-)
>   create mode 100644 drivers/net/ethernet/intel/libie/Makefile
>   create mode 100644 drivers/net/ethernet/intel/libie/rx.c
>   create mode 100644 include/linux/net/intel/libie/rx.h


Thanks a lot for whole effort on this series, it's refreshing to see a 
move in that direction.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>