Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 16:38:26 +0200
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Fabio Estevam <festevam@gmail.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de,
        linux-imx@nxp.com, marex@denx.de, frieder.schrempf@kontron.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O
 Board support
Message-ID: <20230714143826.p3blstr5dpsgr46j@pengutronix.de>
References: <20230704184109.991104-1-m.felsch@pengutronix.de>
 <20230704184109.991104-3-m.felsch@pengutronix.de>
 <CAOMZO5C21f9+ByLVHMaK9wHcCSF3R9W1c1ZCfirx7TuX=786Rw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOMZO5C21f9+ByLVHMaK9wHcCSF3R9W1c1ZCfirx7TuX=786Rw@mail.gmail.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hi Fabio,

On 23-07-04, Fabio Estevam wrote:
> Hi Marco,
> 
> On Tue, Jul 4, 2023 at 3:41 PM Marco Felsch <m.felsch@pengutronix.de> wrote:
> 
> > +&fec {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_fec>;
> > +       phy-mode = "rgmii-id";
> > +       phy-handle = <&ethphy1>;
> > +       fsl,magic-packet;
> > +       phy-reset-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
> > +       phy-reset-duration = <10>;
> > +       phy-reset-post-delay = <150>;
> 
> These properties are deprecated. Please move them under the mdio node.

right

> > +               /*
> > +                * Since USB1 is binded to peripheral mode we need to ensure
> 
> s/binded/bound

sure

> > +/* µSD Card */
> > +&usdhc2 {
> > +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +       pinctrl-0 = <&pinctrl_usdhc2>;
> > +       pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
> > +       pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> > +       vmmc-supply = <&reg_usdhc2_vmmc>;
> > +       bus-width = <4>;
> > +       disable-wp;
> > +       no-sdio;
> > +       no-mmc;
> > +
> 
> No need for this blank line.

I added the blank lines for a better separation, but I can drop these.

> > +       assigned-clocks = <&clk IMX8MP_CLK_USDHC2>;
> > +       assigned-clock-rates = <400000000>;
> > +
> 
> Ditto.
> 
> > +
> > +       pmic@25 {
> > +               compatible = "nxp,pca9450c";
> > +               reg = <0x25>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_pmic>;
> > +
> > +               interrupt-parent = <&gpio1>;
> > +               interrupts = <3 GPIO_ACTIVE_LOW>;
> > +
> > +               regulators {
> > +                       buck1: BUCK1 {
> > +                               regulator-name = "BUCK1";
> > +                               regulator-min-microvolt = <600000>;
> > +                               regulator-max-microvolt = <2187500>;
> > +                               regulator-boot-on;
> > +                               regulator-always-on;
> > +                               regulator-ramp-delay = <3125>;
> > +                       };
> > +
> > +                       buck2: BUCK2 {
> > +                               regulator-name = "BUCK2";
> > +                               regulator-min-microvolt = <600000>;
> > +                               regulator-max-microvolt = <2187500>;
> > +                               regulator-boot-on;
> > +                               regulator-always-on;
> > +                               regulator-ramp-delay = <3125>;
> > +                               nxp,dvs-run-voltage = <950000>;
> > +                               nxp,dvs-standby-voltage = <850000>;
> > +                       };
> > +
> > +                       buck4: BUCK4{
> 
> Missing space after BUCK4.

yes.

> > +                               regulator-name = "BUCK4";
> > +                               regulator-min-microvolt = <600000>;
> > +                               regulator-max-microvolt = <3400000>;
> > +                               regulator-boot-on;
> > +                               regulator-always-on;
> > +                       };
> > +
> > +                       buck5: BUCK5{
> 
> Ditto.

yes.

> > +&usdhc3 {
> > +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +       pinctrl-0 = <&pinctrl_usdhc3>;
> > +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> > +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> > +       bus-width = <8>;
> > +       non-removable;
> > +
> 
> No need for this blank line.
> 
> 
> > +       assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
> > +       assigned-clock-rates = <400000000>;
> > +
> 
> Ditto.

Removed these as well. Thanks for your review :)

Regards,
  Marco