Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2637263rwp; Fri, 14 Jul 2023 09:01:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlEQ5Rr+aZ2+V44E/Uj5rXZigVAuiGYoSOp68kWworJacJsGztMomfE3IoxcC/XFwbr/tu1x X-Received: by 2002:a05:6402:50ca:b0:51e:5bb5:8b22 with SMTP id h10-20020a05640250ca00b0051e5bb58b22mr4003524edb.0.1689350512351; Fri, 14 Jul 2023 09:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689350512; cv=none; d=google.com; s=arc-20160816; b=EKS0VO+9dsv4NLm3mBA81JC6p7orEE3/XFQdMTNdXx4rx22QVtbKw3L31yqDkrN2D/ Zc1Ynm8lQbS9w+mbcl8BVyAmumH5+oxo+CHUnHsfSLhRooAlKBbAW/2YbZFKPtyPkPDe 6SrD7jS9TbRejc57BjJNuJapHLM7QzuJSgwUF5qR78Zvm821MVJGXYPvV/vHtHv7rCq2 BYnuC1O8Q9G8iNU/ITMGp24dFpwJAnC0u0sMizxiR/YjFGwK6RINJCHikXCE670caNT/ zUBIMDqtxrflJf+zr7QEB7fVwzTL5iYFrty7J6ZOJGsxw4IIWwl5w6zbk3+QLMF3rQCl vTjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RMwnFSaX+SjxhZqr2OAUjgEYCqmkTknvytvmm1c894E=; fh=cYgC5Xho7OjFkTNPIdtXzS+hMjjGVNCvR87A6vshCd4=; b=NDbmYQa03CqvR+C2f2cgnDiw3eX5RfwyF3PX8rol8Rx93+q6hjG2fyB/PjOkMSibiJ vNn7SCQtZ6aPAwTmdcUhzvnDcbi695sY7/f3+jZXy+GIXJypJ9jAruDBFvmwR2nbrivN uffOnJRAWCYqVXCz9aE9K9UZTemQ86C1x5sl3IMdJ0r4jb/1gJhTrEYM/8PD4zpUddoe 2HLpduuGAW1B3P0ltoAkiriqbvIi445MHk1Bh1GlPnvI7dgSwqlt107lmDWjomkz8ILy 5I2ijGWlSRQzn5AnB6wTkiZnGgSsiS1d+xa3WW6z+JEX11r+E5XyRj7T6VAxAXG1fxHo ydCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BU+cMt3a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f24-20020a05640214d800b0051be9317ccasi9514995edx.508.2023.07.14.09.01.26; Fri, 14 Jul 2023 09:01:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BU+cMt3a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236375AbjGNPc1 (ORCPT + 99 others); Fri, 14 Jul 2023 11:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236372AbjGNPcY (ORCPT ); Fri, 14 Jul 2023 11:32:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C34F2D68; Fri, 14 Jul 2023 08:32:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE44B61D27; Fri, 14 Jul 2023 15:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28098C433C8; Fri, 14 Jul 2023 15:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689348739; bh=/JpD1lpXF+MJn+oRxWFHX3NKrdTgLNG55ZY6x8Dgfa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BU+cMt3aFMv2DYMoU8EI99NC/uGinRVKy0UcITXiPYaWScXbboqhuHC2d29VGMj6a uLKUKScHh+yXBfMsjmDH7TTp9O9WnR7+HKC3qx2r4FTN51poZxs0vK+rPSNY3kliKh QGaRJ4nFSNn81MeQnxubUeoS4eWgM8KqQ6Lm4PA4ppRvNGqlnL2tZtqR6ZeZdpOW5M QoGV9qAV/VpW1GVNPXFbnaRRPwLNVfKvuiXsk2PmhtYRrU08zpelRu5C3Jq+iyMRxX 1jQdxDX7N5aVb0QzqFiKoeqoMvw6rBl1PAu2N3jsXPSQ6miQE4HHrb1dh0SQuRpufF +s9xxV/VqJYiQ== Date: Fri, 14 Jul 2023 17:32:15 +0200 From: Christian Brauner To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH 2/5] exit: move core of do_wait() into helper Message-ID: <20230714-anreden-zeitmanagement-c3947dfddbe5@brauner> References: <20230711204352.214086-1-axboe@kernel.dk> <20230711204352.214086-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230711204352.214086-3-axboe@kernel.dk> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 02:43:49PM -0600, Jens Axboe wrote: > Rather than have a maze of gotos, put the actual logic in __do_wait() > and have do_wait() loop deal with waitqueue setup/teardown and whether > to call __do_wait() again. > > No functional changes intended in this patch. > > Signed-off-by: Jens Axboe > --- Honestly just makes the code easier to read in general, Acked-by: Christian Brauner